Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 23 Nov 2022 10:39:59 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     zhengjun.xing@linux.intel.com, Ian Rogers <irogers@google.com>
Cc:     peterz@infradead.org, mingo@redhat.com,
        alexander.shishkin@intel.com, jolsa@kernel.org,
        namhyung@kernel.org, linux-kernel@vger.kernel.org,
        linux-perf-users@vger.kernel.org, ak@linux.intel.com,
        kan.liang@linux.intel.com
Subject: Re: [PATCH v2 1/5] perf vendor events intel: Add core event list for
 Alderlake-N
Message-ID: <Y34irx0jffj8NXRY@kernel.org>
References: <20221121082058.64578-1-zhengjun.xing@linux.intel.com>
 <CAP-5=fUQUe0UvLhaSBnm-dAPHc3_k8vZWNxhZajg8mg6R8og0g@mail.gmail.com>
 <Y34iAVLGAGhVH/ta@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <Y34iAVLGAGhVH/ta@kernel.org>
Precedence: bulk

Em Wed, Nov 23, 2022 at 10:37:05AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Mon, Nov 21, 2022 at 01:17:12PM -0800, Ian Rogers escreveu:
> > On Mon, Nov 21, 2022 at 12:19 AM <zhengjun.xing@linux.intel.com> wrote:
> > >
> > > From: Zhengjun Xing <zhengjun.xing@linux.intel.com>
> > >
> > > Alderlake-N only has E-core, it has been moved to non-hybrid code path on
> > > the kernel side. Add core event list for Alderlake-N, it is based on the
> > > ADL gracemont v1.16 JSON file.
> > >
> > > https://github.com/intel/perfmon/tree/main/ADL/events/
> > >
> > > Signed-off-by: Zhengjun Xing <zhengjun.xing@linux.intel.com>
> > > Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
> > 
> > Acked-by: Ian Rogers <irogers@google.com>
> 
> Is this just for 1/5? Or can I stick it to the whole series?

But, after applying 1/5 I get:

  CC      /tmp/build/perf/util/data-convert-bt.o
  CC      /tmp/build/perf/util/data-convert-json.o
/tmp/build/perf/pmu-events/pmu-events.c:55354:39: error: ‘pme_alderlaken’ defined but not used [-Werror=unused-const-variable=]
55354 | static const struct compact_pmu_event pme_alderlaken[] = {
      |                                       ^~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[3]: *** [/var/home/acme/git/perf/tools/build/Makefile.build:97: /tmp/build/perf/pmu-events/pmu-events.o] Error 1
make[2]: *** [Makefile.perf:711: /tmp/build/perf/pmu-events/pmu-events-in.o] Error 2
make[2]: *** Waiting for unfinished jobs....
  CC      /tmp/build/perf/util/lzma.o
  CC      /tmp/build/perf/util/zlib.o
  CC      /tmp/build/perf/util/jitdump.o
  CC      /tmp/build/perf/util/bpf-event.o
  LD      /tmp/build/perf/util/perf-in.o
  LD      /tmp/build/perf/perf-in.o
make[1]: *** [Makefile.perf:240: sub-make] Error 2
make: *** [Makefile:113: install-bin] Error 2
make: Leaving directory '/var/home/acme/git/perf/tools/perf'

 Performance counter stats for 'make -k BUILD_BPF_SKEL=1 CORESIGHT=1 O=/tmp/build/perf -C tools/perf install-bin':

    26,049,918,108      cycles:u
    47,580,273,158      instructions:u                   #    1.83  insn per cycle

       4.655423698 seconds time elapsed

       6.211852000 seconds user
       5.060661000 seconds sys


⬢[acme@toolbox perf]$

Please fix it and send a v2.

- Arnaldo