Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <799672c1-c2fa-900d-326d-8673ce9e6e7a@amd.com>
Date:   Wed, 23 Nov 2022 06:02:29 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v4 0/4] new subsystem for compute accelerator devices
To:     Dave Airlie <airlied@gmail.com>, Oded Gabbay <ogabbay@kernel.org>,
        Daniel Vetter <daniel@ffwll.ch>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
References: <20221119204435.97113-1-ogabbay@kernel.org>
 <02c514c0-62c4-1cdf-5d3f-b3d8942ef005@amd.com>
 <CAPM=9ty_YHrM5QhAjgFvNdpkEwnB_WHsouhYG8m5XGrb+kmWAQ@mail.gmail.com>
 <Y3ziqU2vrgwIY4HB@phenom.ffwll.local>
Content-Language: en-US
From:   Sonal Santan <sonal.santan@amd.com>
Cc:     Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>,
        Jeffrey Hugo <quic_jhugo@quicinc.com>,
        Jason Gunthorpe <jgg@nvidia.com>,
        Arnd Bergmann <arnd@arndb.de>, Jiho Chu <jiho.chu@samsung.com>,
        John Hubbard <jhubbard@nvidia.com>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        Christoph Hellwig <hch@infradead.org>,
        Christopher Friedt <chrisfriedt@gmail.com>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Kevin Hilman <khilman@baylibre.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        Yuji Ishikawa <yuji2.ishikawa@toshiba.co.jp>,
        Maciej Kwapulinski <maciej.kwapulinski@linux.intel.com>,
        Jagan Teki <jagan@amarulasolutions.com>
In-Reply-To: <Y3ziqU2vrgwIY4HB@phenom.ffwll.local>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T3JTYnVJSm9qNlQ5Rm5zNDRPNm1NdjBZV3l4UzhIU0ZYQnBCMXd0bm1NdFVJ?=
 =?utf-8?B?SGx2aklGeSs1eEhiUUtzQmxkbmN4VnBqQzhRSzdoOUF0UE1FMWZjTXh6NStX?=
 =?utf-8?B?cXVKakVvODM0NzZUdzFIc2lRRWNMM2hlWjVLd3lUM3gyNlROaWVQa0pHZ0Yw?=
 =?utf-8?B?eG9IbU10MUlsZVd5blhrUkpWOXpiOTI1Qk4wWVJRRlhVQXBaczEzcldaa3lj?=
 =?utf-8?B?WDN2RnpQVmtnQVlvVkRzdlRLSS8vM09qdldPOUN2QllsRVBiT0JhOHQ5djFa?=
 =?utf-8?B?YU9HcC8yVGozd2ZtTDloUjRkOWluMSs5eXdKNlZibTg5dmo1QnlJKzIyVEsr?=
 =?utf-8?B?Vlk4NGtLNjFCdEpmVDZaUHhyL3ZhMUZMY0h3blFBdnkwNHlMazlzY25kbFZP?=
 =?utf-8?B?cEswNzVTdkN4UEZoeG0wcWtwYmVJd0NTOHhKdDlLNGE2Ylg4QlhRWVA1Qngy?=
 =?utf-8?B?MlJGVlNOd2pqNGRWdi9mVkJKYnQ0QkYrbmdkdm91R0NTM2JkQlJ3VVVBRzh5?=
 =?utf-8?B?Rnhhamxuclo2S2huQUFYQXhSRjJOek03NG5SOGJHM2s4akdFbVM4QU05VnRK?=
 =?utf-8?B?eFR5R3hsQ0kxZWZnbUNIVjYwY3VPaXlvMS8wYkxUQUZBd09OZHYwWkpzeU9t?=
 =?utf-8?B?VGdCQUhVdW03Sm4xeWdSMVNsR0N4U25zUVJoNXFWZlBsNkNiQjRxZGpWTStW?=
 =?utf-8?B?bFd1RTVJZXRsQTBkekExNzU4M3VnYjZmUlpLZHp3MU5sb3pyTHJnVTZweW9B?=
 =?utf-8?B?ZzZMdjFaQTNiOFNzMlQ0Z0FSWW0yVjJnWHh4dlpqN3Jsc204U1U3QVlyK2lG?=
 =?utf-8?B?Tzg2eTM2YVkwc0NhT2hMWTMvbWNrTFJYWUJud3JuTzduVzJUMU1Vc05uVStX?=
 =?utf-8?B?d3lEQ3ozbmFjN2RPRnFPWXdRQzhpMDFmZ3BDcndzVWJrZTQ3ZDdXVGl6WjJ3?=
 =?utf-8?B?bWprSGI5VUJuMko2WEkrQnlwUGpHN283LzB4LzlKL3FNN0E0UnljbWh2SlpH?=
 =?utf-8?B?V2dZNXB2cllTb0l2QTFEdUdCcm9kNTR3Mk82N3QrN2JodXBYRWNaWG9pZkxI?=
 =?utf-8?B?YVBjWnhGeG1CUWpJMTREVFBvdmJSaksrV2d3OFAwNFM0SkN0a1MwL20xdnB1?=
 =?utf-8?B?QjB6cHNSMHdFYWZ6SUhYVjA5RmgrcHdwYWFaamRHaGZBaG8rN1owTTErRG9w?=
 =?utf-8?B?VUkxY2JhSyt3ckgwcFpqZzNXOHVmaE1BekhUdVNJM2JNNHk5TjBTZHk0aEx1?=
 =?utf-8?B?UDR5cXRGaSs2YldLcUd0c1BOOTN3Y3ZqRnVzeVUzRjR5anQwM2l3SE9KdEMy?=
 =?utf-8?B?U2wyUEJHc0Y3WFcyVFRNc1VSTTVBZitCSnRaM1AyM0kxZC95YngySldrWFBW?=
 =?utf-8?B?RzFoUDZJMUR2QXgvTnp3ZDcreUxQVDBIdjZJckxJOGcvUHY3RGE1M3lIa3Ro?=
 =?utf-8?B?anMybnZpTzFqL1RoS0tzK3dycjYvUGR5Vit0R29YR3dnSXl5WTBaNmxuUFVp?=
 =?utf-8?B?clZ2UGZkdnlHd1JNMkVaVTBQYW5Kbyt3Rk9VZFJoMEVQdmhuMzdEYjVzUzZs?=
 =?utf-8?B?U3RyRTNzNU1NQWRiamc0b1pzSWpUd1B4SjNGVE5iNVJmNE1DL2FZN29aR2J3?=
 =?utf-8?B?TjNmZUpkZUFnRW1XM1FORHhQNUdDdlVoNDJ4QThUaHZBUVZXMWVzcjdkeWVZ?=
 =?utf-8?B?VWlpdVllYzFyZ1phNkRpQm1SdHJtU1BnSDA0UzltWFIzS0R0SjlGcExCN1RI?=
 =?utf-8?B?QnVuVmJIblFtb1UwYVdvTW9IM1c2Y0FIdEV1WldnQVpSVU9aQVdqWkpmSU1E?=
 =?utf-8?B?VnN3djFyNy9FcUlKQnoxdG8weXFmNXpqUU5yQ1FIK0dBNGVGejBMbk5kRzJP?=
 =?utf-8?B?czgrZUpSSjFmK1Rqc3RZa3J4NUs1NTRjMmVhcXF3TTFpMG5CZ3BhYWpvek5a?=
 =?utf-8?B?cmZTa3B4aWErd1RDcUtmMTJyV3M5cDVpSmU5ekw2dEVkMlpUWW5DVzhuYk9G?=
 =?utf-8?B?dkRyVVpOTVhLdDZ3WXNyeFh3N2QxNWlsRWtNZHI5L3loenhSeHRzc2Vpanpu?=
 =?utf-8?B?RVhWaDBkYlpKUlA0bHlmODFGWW5rbmNBQ3ZQL1QwM01iUGZOMzRuejZ0VGt0?=
 =?utf-8?Q?v4qG68raKVXpT2bcDQgjVpDnn?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 52b9d575-cdcd-4607-9c4b-08dacd5b5ee0
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4502.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 14:02:34.5405
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fL/xpenKoLl4x09UVTt+XDAd6MB8EKcGquH2kY6LdMkgbjy8P2o9u1M6BJu8khUU
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7146
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/22/22 06:54, Daniel Vetter wrote:
> On Tue, Nov 22, 2022 at 03:46:25PM +1000, Dave Airlie wrote:
>> On Tue, 22 Nov 2022 at 09:06, Sonal Santan <sonal.santan@amd.com> wrote:
>>>
>>> On 11/19/22 12:44, Oded Gabbay wrote:
>>>> This is the fourth (and hopefully last) version of the patch-set to add the
>>>> new subsystem for compute accelerators. I removed the RFC headline as
>>>> I believe it is now ready for merging.
>>>>
>>>> Compare to v3, this patch-set contains one additional patch that adds
>>>> documentation regarding the accel subsystem. I hope it's good enough for
>>>> this stage. In addition, there were few very minor fixes according to
>>>> comments received on v3.
>>>>
>>>> The patches are in the following repo:
>>>> https://git.kernel.org/pub/scm/linux/kernel/git/ogabbay/accel.git/log/?h=accel_v4
>>>>
>>>> As in v3, The HEAD of that branch is a commit adding a dummy driver that
>>>> registers an accel device using the new framework. This can be served
>>>> as a simple reference.
>>>>
>>>> v1 cover letter:
>>>> https://lkml.org/lkml/2022/10/22/544
>>>>
>>>> v2 cover letter:
>>>> https://lore.kernel.org/lkml/20221102203405.1797491-1-ogabbay@kernel.org/T/
>>>>
>>>> v3 cover letter:
>>>> https://lore.kernel.org/lkml/20221106210225.2065371-1-ogabbay@kernel.org/T/
>>>
>>> Thanks for defining the new accel subsystem. We are currently working on
>>> DRM based drivers for unannounced acceleration devices. I am fine with
>>> these changes with the assumption that the choice of using classic DRM
>>> or accel is left up to the individual driver.
>>
>> I don't think that decision should be up to any individual driver
>> author. It will have to be consensus with me/Daniel/Oded and the
>> driver authors.
> 
> Plus the entire point of this is that it's _still_ a drm based driver. So
> aside from changing a flag in the kernel driver and adjusting userspace to
> find the right chardev, there should be zero changes need for an existing
> drm based driver stack that gets ported to drivers/accel.
> 
> And of course if we realize there's issues as we add drivers, we can fix
> things up. This is just to kick things off, not something that's going to
> be cast in stone for all eternity.
> 
> Sonal, with that clarification/explanation, is this entire thing
> reasonable in principal and you can drop an Ack onto the series?
> 
> Thanks, Daniel


Sounds good. The accel patch series is:
Acked-by: Sonal Santan <sonal.santan@amd.com>

-Sonal