Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f8f95d37211bac6ce4322a715740d2b2ae20db84.camel@huaweicloud.com>
Subject: Re: [PATCH] ima: Make a copy of sig and digest in
 asymmetric_verify()
From:   Roberto Sassu <roberto.sassu@huaweicloud.com>
To:     Mimi Zohar <zohar@linux.ibm.com>, dmitry.kasatkin@gmail.com,
        paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com,
        rusty@rustcorp.com.au, axboe@kernel.dk
Cc:     linux-integrity@vger.kernel.org,
        linux-security-module@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Roberto Sassu <roberto.sassu@huawei.com>,
        stable@vger.kernel.org
Date:   Wed, 23 Nov 2022 14:49:31 +0100
In-Reply-To: <c6c448c2acc07caf840046067322f3e1110cedff.camel@linux.ibm.com>
References: <20221104122023.1750333-1-roberto.sassu@huaweicloud.com>
         <9ef25f1b8621dab8b3cd4373bf6ce1633daae70e.camel@linux.ibm.com>
         <a676b387d23f9ca630418ece20a6761a9437ce76.camel@huaweicloud.com>
         <c6c448c2acc07caf840046067322f3e1110cedff.camel@linux.ibm.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5-0ubuntu1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 2022-11-23 at 08:40 -0500, Mimi Zohar wrote:
> On Wed, 2022-11-23 at 13:56 +0100, Roberto Sassu wrote:
> > On Tue, 2022-11-22 at 14:39 -0500, Mimi Zohar wrote:
> > > Hi Roberto,
> > > 
> > > On Fri, 2022-11-04 at 13:20 +0100, Roberto Sassu wrote:
> > > > From: Roberto Sassu <roberto.sassu@huawei.com>
> > > > 
> > > > Commit ac4e97abce9b8 ("scatterlist: sg_set_buf() argument must be in linear
> > > > mapping") requires that both the signature and the digest resides in the
> > > > linear mapping area.
> > > > 
> > > > However, more recently commit ba14a194a434c ("fork: Add generic vmalloced
> > > > stack support"), made it possible to move the stack in the vmalloc area,
> > > > which could make the requirement of the first commit not satisfied anymore.
> > > > 
> > > > If CONFIG_SG=y and CONFIG_VMAP_STACK=y, the following BUG() is triggered:
> > > 
> > > ^CONFIG_DEBUG_SG
> > > 
> > > > [  467.077359] kernel BUG at include/linux/scatterlist.h:163!
> > > > [  467.077939] invalid opcode: 0000 [#1] PREEMPT SMP NOPTI
> > > > 
> > > > [...]
> > > > 
> > > > [  467.095225] Call Trace:
> > > > [  467.096088]  <TASK>
> > > > [  467.096928]  ? rcu_read_lock_held_common+0xe/0x50
> > > > [  467.097569]  ? rcu_read_lock_sched_held+0x13/0x70
> > > > [  467.098123]  ? trace_hardirqs_on+0x2c/0xd0
> > > > [  467.098647]  ? public_key_verify_signature+0x470/0x470
> > > > [  467.099237]  asymmetric_verify+0x14c/0x300
> > > > [  467.099869]  evm_verify_hmac+0x245/0x360
> > > > [  467.100391]  evm_inode_setattr+0x43/0x190
> > > > 
> > > > The failure happens only for the digest, as the pointer comes from the
> > > > stack, and not for the signature, which instead was allocated by
> > > > vfs_getxattr_alloc().
> > > 
> > > Only after enabling CONFIG_DEBUG_SG does EVM fail.
> > > 
> > > > Fix this by making a copy of both in asymmetric_verify(), so that the
> > > > linear mapping requirement is always satisfied, regardless of the caller.
> > > 
> > > As only EVM is affected, it would make more sense to limit the change
> > > to EVM.
> > 
> > I found another occurrence:
> > 
> > static int xattr_verify(enum ima_hooks func, struct integrity_iint_cache *iint,
> > 			struct evm_ima_xattr_data *xattr_value, int xattr_len,
> > 			enum integrity_status *status, const char **cause)
> > {
> > 
> > [...]
> > 
> > 		rc = integrity_digsig_verify(INTEGRITY_KEYRING_IMA,
> > 					     (const char *)xattr_value,
> > 					     xattr_len, hash.digest,
> > 					     hash.hdr.length);
> > 
> > Should I do two patches?
> 
> I'm just not getting it.  Why did you enable CONFIG_DEBUG_SIG?  Were
> you testing random kernel configs?  Are you actually seeing signature
> verifications errors without it enabled?  Or is it causing other
> problems?  Is the "BUG_ON" still needed?

When I test patches, I tend to enable more debugging options.

To be honest, I didn't check if there is any issue without enabling
CONFIG_DEBUG_SG. I thought that if there is a linear mapping
requirement, that should be satisfied regardless of whether the
debugging option is enabled or not.

+ Rusty, Jens for explanations.

> If you're going to fix the EVM and IMA callers, then make them separate
> patches.

Ok.

Thanks

Roberto