Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 23 Nov 2022 13:31:24 +0000
Message-ID: <86h6ypol03.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     Icenowy Zheng <uwu@icenowy.me>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Samuel Holland <samuel@sholland.org>,
        linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH] irqchip/sifive-plic: drop quirk for two-cell variant
In-Reply-To: <402eb920c5ca84e7d751ec7bd9b7f4f512a66921.camel@icenowy.me>
References: <20221121042026.419383-1-uwu@icenowy.me>
        <86o7syoq4t.wl-maz@kernel.org>
        <16d01eebc1693916fc74e1e75458d6c0f080cf37.camel@icenowy.me>
        <86ilj5oltb.wl-maz@kernel.org>
        <402eb920c5ca84e7d751ec7bd9b7f4f512a66921.camel@icenowy.me>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1
 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, 23 Nov 2022 13:16:01 +0000,
Icenowy Zheng <uwu@icenowy.me> wrote:
>=20
> =E5=9C=A8 2022-11-23=E6=98=9F=E6=9C=9F=E4=B8=89=E7=9A=84 13:13 +0000=EF=
=BC=8CMarc Zyngier=E5=86=99=E9=81=93=EF=BC=9A
> > On Wed, 23 Nov 2022 12:38:56 +0000,
> > Icenowy Zheng <uwu@icenowy.me> wrote:
> > >=20
> > > =E5=9C=A8 2022-11-22=E6=98=9F=E6=9C=9F=E4=BA=8C=E7=9A=84 17:28 +0000=
=EF=BC=8CMarc Zyngier=E5=86=99=E9=81=93=EF=BC=9A
> > > > On Mon, 21 Nov 2022 04:20:26 +0000,
> > > > Icenowy Zheng <uwu@icenowy.me> wrote:
> > > > >=20
> > > > > As the special handling of edge-triggered interrupts are
> > > > > defined in
> > > > > the
> > > > > PLIC spec, we can assume it's not a quirk, but a feature of the
> > > > > PLIC
> > > > > spec; thus making it a quirk and use quirk-based codepath is
> > > > > not so
> > > > > necessary.
> > > >=20
> > > > It *is* necessary.
> > > >=20
> > > > >=20
> > > > > Move to a #interrupt-cells-based practice which will allow both
> > > > > device
> > > > > trees without interrupt flags and with interrupt flags work for
> > > > > all
> > > > > compatible strings.
> > > >=20
> > > > No. You're tying together two unrelated concepts:
> > > >=20
> > > > - Edges get dropped in some implementations (and only some). You
> > > > can
> > > > =C2=A0 argue that the architecture allows it, but I see it is an
> > > > =C2=A0 implementation bug.
> > >=20
> > > As the specification allows it, it's not an implementation bug --
> > > and
> > > for those which do not show this problem, it's possible that it's
> > > just
> > > all using the same trigger type (e.g. Rocket).
> >=20
> > What are you against? The fact that this is flagged as a quirk?
> > Honestly, I don't care about that. If we can fold all implementations
> > into the same scheme, that's fine by me.
>=20
> Then what should I do?

Make all edge-triggered interrupts use the edge flow.

>=20
> >=20
> > >=20
> > > >=20
> > > > - The need for expressing additional information in the interrupt
> > > > =C2=A0 specifier is not necessarily related to the above. Other
> > > > interrupt
> > > > =C2=A0 controllers use extra cells to encode the interrupt affinity,
> > > > for
> > > > =C2=A0 example.
> > >=20
> > > I think in these situations, if the interrupt controller does not
> > > contain any special handling for edge interrupts, we can just
> > > describe
> > > them as level ones in SW.
> >=20
> > No, that's utterly wrong. We don't describe an edge as level. Ever.
> >=20
> > >=20
> > > >=20
> > > > I want these two things to be kept separate. Otherwise, once we
> > > > get
> > > > some fancy ACPI support for RISCV (no, please...), we'll have to
> > > > redo
> > > > the whole thing...
> > > >=20
> > > > > In addition, this addresses a stable version DT binding
> > > > > violation -
> > > > > -
> > > > > Linux v5.19 comes with "thead,c900-plic" with #interrupt-cells
> > > > > defined to
> > > > > be 1 instead of 2, this commit will allow DTs that complies to
> > > > > Linux
> > > > > v5.19 binding work (although no such DT is devliered to the
> > > > > public
> > > > > now).
> > > >=20
> > > > *That* is what should get fixed.
> > >=20
> > > Supporting all stable versions' DT binding is our promise, I think.
> >=20
> > Absolutely. And I'm asking you to fix it. And only that.
>=20
> Then what should I do? Mask this as another quirk that is only
> applicable to c900-plic?

No. Make interrupts with a single cell use the level flow.

> Sounds more crazy...

There is obviously no accounting for taste.

      M.

--=20
Without deviation from the norm, progress is not possible.