Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Sriranjani P" <sriranjani.p@samsung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
        <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <lee@kernel.org>, <devicetree@vger.kernel.org>,
        <alim.akhtar@samsung.com>, <pankaj.dubey@samsung.com>,
        <ravi.patel@samsung.com>
Cc:     <linux-kernel@vger.kernel.org>
In-Reply-To: <a98ac5d7-0c0e-110e-5405-83a09c77ceac@linaro.org>
Subject: RE: [PATCH 2/2] arm64: dts: fsd: add sysreg device node
Date:   Wed, 23 Nov 2022 17:27:35 +0530
Message-ID: <000001d8ff32$c8b78e30$5a26aa90$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQGtZdCQDJwhTh87CLfF3yzsQrDlqwDaao/AAgr8Mq4BlHJjc65/yl5A
Content-Language: en-in
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <20221121091118.48628-1-sriranjani.p@samsung.com>
        <CGME20221121090647epcas5p439dc84f0c4f435a703a1f8396a11202f@epcas5p4.samsung.com>
        <20221121091118.48628-3-sriranjani.p@samsung.com>
        <a98ac5d7-0c0e-110e-5405-83a09c77ceac@linaro.org>
Precedence: bulk


> -----Original Message-----
> From: Krzysztof Kozlowski =5Bmailto:krzysztof.kozlowski=40linaro.org=5D
> Sent: 21 November 2022 17:58
> To: Sriranjani P <sriranjani.p=40samsung.com>; robh+dt=40kernel.org;
> krzysztof.kozlowski+dt=40linaro.org; lee=40kernel.org;
> devicetree=40vger.kernel.org; alim.akhtar=40samsung.com;
> pankaj.dubey=40samsung.com; ravi.patel=40samsung.com
> Cc: linux-kernel=40vger.kernel.org
> Subject: Re: =5BPATCH 2/2=5D arm64: dts: fsd: add sysreg device node
>=20
> On 21/11/2022 10:11, Sriranjani P wrote:
> > Add SYSREG controller device node, which is available in PERIC, FSYS0
> > and
> > FSYS1 block of FSD SoC.
> >
> > Signed-off-by: Alim Akhtar <alim.akhtar=40samsung.com>
> > Signed-off-by: Pankaj Dubey <pankaj.dubey=40samsung.com>
> > Signed-off-by: Sriranjani P <sriranjani.p=40samsung.com>
> > ---
> >  arch/arm64/boot/dts/tesla/fsd.dtsi =7C 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi
> > b/arch/arm64/boot/dts/tesla/fsd.dtsi
> > index f35bc5a288c2..db78816ba0bf 100644
> > --- a/arch/arm64/boot/dts/tesla/fsd.dtsi
> > +++ b/arch/arm64/boot/dts/tesla/fsd.dtsi
> > =40=40 -518,6 +518,21 =40=40
> >  				=22dout_cmu_fsys1_shared0div4=22;
> >  		=7D;
> >
> > +		sysreg_peric: syscon=4014030000 =7B
>=20
> Node name system-controller
=5BSriranjani P=5D Will fix it in the next version. We added =E2=80=9Csysco=
n=E2=80=9D=20since=20I=20referred=20other=20dtsi=20files=20in=20mainline=20=
for=20example=20exynosautov9.dtsi=20used=20syscon=20as=20node=20name.=20If=
=20this=20is=20the=20name=20we=20should=20add=20then=20I=E2=80=99ll=20post=
=20few=20more=20patches=20fixing=20this=20node=20name=20in=20other=20Exynos=
=20dtsi=20files.=0D=0A>=20and=20either=20put=20it=20next=20to=20existing=20=
one=20or=20next=20to=20functional=20block=20(peric=0D=0A>=20clocks?)=20orde=
red=20by=20unit=20address.=0D=0A=5BSriranjani=20P=5D=20We=20thought=20of=20=
it=20but=20as=20I=20saw=20current=20fsd.dtsi=20file=20and=20other=20exynos=
=20file=20like=20exynosautov9.dtsi,=20in=20that=20nodes=20are=20not=20prope=
rly=20arranged=20as=20per=20unit=20address.=0D=0A=0D=0ASo=20I=20can=20think=
=20of=20following=20two=20approaches:=20=0D=0A1:=20For=20the=20time=20being=
=20I=20will=20put=20this=20sysreg=20node=20in=20between=20clock_peric=20nod=
e=20and=20clock_fysys0=20node=20and=20clock_fsys1=20node=20as=20per=20incre=
asing=20unit=20address.=20I=20will=20clean=20up=20other=20exynos=20and=20FS=
D=20DTSI=20files=20and=20post=20a=20new=20patch=20=0D=0A2:=20First=20I=20wi=
ll=20clean=20up=20exynos=20and=20FSD=20DTSI=20files=20and=20then=20post=20t=
his=20sysreg=20patch=20keeping=20it=20at=20appropriate=20place.=20=0D=0A=0D=
=0APlease=20let=20me=20know=20which=20way=20it=20will=20be=20more=20appropr=
iate.=0D=0A>=20=0D=0A>=20>=20+=09=09=09compatible=20=3D=20=22tesla,fsd-sysr=
eg=22,=20=22syscon=22;=0D=0A>=20>=20+=09=09=09reg=20=3D=20<0x0=200x14030000=
=200x0=200x1000>;=0D=0A>=20>=20+=09=09=7D;=0D=0A>=20=0D=0A>=20Best=20regard=
s,=0D=0A>=20Krzysztof=0D=0A=5BSriranjani=20P=5D=20Thank=20you=20for=20revie=
wing=20the=20patch.=0D=0A=0D=0A=0D=0A