Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 23 Nov 2022 07:06:12 -0800
From:   Lucas De Marchi <lucas.demarchi@intel.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
CC:     Jakob Koschel <jakobkoschel@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Mathias Nyman <mathias.nyman@linux.intel.com>,
        <intel-gfx@lists.freedesktop.org>,
        <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        <linux-usb@vger.kernel.org>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        Kevin Cernekee <cernekee@gmail.com>,
        Mathias Nyman <mathias.nyman@intel.com>,
        Jani Nikula <jani.nikula@intel.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH v4 1/4] i915: Move list_count() to list.h for broader use
Message-ID: <20221123150612.y35wdfeujdjqabsx@ldmartin-desk2.lan>
References: <20221123144901.40493-1-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset="us-ascii"; format=flowed
Content-Disposition: inline
In-Reply-To: <20221123144901.40493-1-andriy.shevchenko@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JYImttvTKWxQM1uyJgIIT6fCbXVHRY5sSKWAnupwK9wyax7WYZf97SBwcxWw?=
 =?us-ascii?Q?rjlI/5abvpXqj4i82GB7e3FA1M2XAJ1WXpnFhwa5RiMCV6hrkvA3VYMQmKY7?=
 =?us-ascii?Q?u+lp3dxi+k3//QqRVJO4P96g8nBcW7HRc42yVcfSOOn9PmNrurKXnTPfmBdF?=
 =?us-ascii?Q?CXLsg0j5UgGlo4As1YI02IGDaAOGjG6lo5f8GIGO6R3qh4NkSjXNc8X0PR5b?=
 =?us-ascii?Q?ByjnzFae/FG315xO8axqFMOChPqGTF6iPQWFovFHEwjfYbn+rMCTR447Ychj?=
 =?us-ascii?Q?zz9XKwJ3F0PddfmF6Tc0riW9o9CSs8TJzxnxmL2qCAC2sCoOp8uyGM2sskMN?=
 =?us-ascii?Q?TvcNMSUWCnCB2D8O9E6FVnrbP/wHlA2jtgEk2ozKKTOBThOZV0hKRZYvtVJ8?=
 =?us-ascii?Q?auDisNTXbHG5LrQkT0rhXX3w7Ei8x6tXwqpvdM5nNO4j8defLooR52d3I+tO?=
 =?us-ascii?Q?ofQfCENlLgp2ioBvqVaU40CJRi4xhMtxgzMZPHm7HNlmjkNhb4uczu614GgF?=
 =?us-ascii?Q?H/vop3eOEmsTacf6PQzESHwqTZ+b0Ny6laU2AQNI1eDIoGRxdr/C/0+LLC1m?=
 =?us-ascii?Q?KH7f6YB5nFCgVpNcQcwFtSjCYEZ+0WgMWsP4eK41cLHHSF+9+55XbQgmCQQE?=
 =?us-ascii?Q?rvXzraqOIgzUCVWRmU9wf46WultYOVji8j3m5XeC4GuU1jXE2mdxZdqiIRku?=
 =?us-ascii?Q?j5GT2id7sfn8R8KoWsFU5LOCdrk5pYAP6KM4Y6mDXNKrA9mzD3hTi0pjs1Wb?=
 =?us-ascii?Q?reCJveairS0JbYioWU4AJ5XsEVo9flXh/4l2Hzsv0NUB6apXnqZuF3O0U3y+?=
 =?us-ascii?Q?lDfDnixm87NiGa9mNHSMlSTbWoX3scLwoU4zQpI1vw9aUjgE3cWmD+L3Y/2X?=
 =?us-ascii?Q?6e4c4dcMj1sC8MJ/0lWGpo4VYV5gKTfmgDxZ41WCJbqFP/1/XaTGDrx9QXDq?=
 =?us-ascii?Q?XxmTpJTbPOOtoGqH+k/fNrGzLzBgHpEgcJ4JzrgaTOtgSDM/o463rIh0VAeM?=
 =?us-ascii?Q?JbOplOFyNIW7WOhrbRjy1tz1MtiezHws3OFZtLfB6g8VcKbmLbyDcGI9QLfG?=
 =?us-ascii?Q?4rfIaia82Yz4av1wewyFdN/RoAuxq8CN5D5/xNN9NZ/ZvCLLdr4o70viQxrH?=
 =?us-ascii?Q?RX/up8J6SRB/3rVBM7wCV7s/y6COROgHesbaq3tVBCaYD0iuTZv1ws25IAAm?=
 =?us-ascii?Q?jb74fQzlmN71nEmpX5z69JxiTRzm36g9sIuMRUsjsFA1yAKgs2pfRmfJQ6vu?=
 =?us-ascii?Q?GhG5nKLV6tCFPo7TWAtMjIk30P7V4DkvZtnpZkZS75nRaRhdZEsWeTHnddRG?=
 =?us-ascii?Q?+Fd8Q+E7UuD5SvKqe4c4KvIXy7wEd39uAKjfANgtSOYwg+McANAF9ESWMo/5?=
 =?us-ascii?Q?PmIsb2OAp793Q4O9bFdtozGGjLNCLrHI6LUElMkF6XPbmSkyiUP2W994gDIg?=
 =?us-ascii?Q?3Hcdd/n6ag+Qri4sq3SfE+UAqgjVivYncIikr70hoBEFwT2nYYMGphkrkks6?=
 =?us-ascii?Q?uTO4Br7ePd09M5qPdzeOQpj9qT425M86RHBSAe3OHyyAZHSbLjwtRDiaPfUL?=
 =?us-ascii?Q?M4L1PPIqOwwnUVUdvNCygx7uBHPiFesuWstigLhN7hGn+DPm+E/6Bo9Ul3vx?=
 =?us-ascii?Q?DA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bbd3b11a-6000-4475-2a62-08dacd644460
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6139.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 15:06:15.5954
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: i8k5wNGIWGBE4I0DBuoIomu/v+/Dy7tlp6tQQDb5ChwOLDB6iwLYkxbEf0OoVr9inno7dF4VUONFJ71kgVPMGJ0uRuXOGPofqrCE/s1vQ1c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB5873
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Nov 23, 2022 at 04:48:58PM +0200, Andy Shevchenko wrote:
>Some of the existing users, and definitely will be new ones, want to
>count existing nodes in the list. Provide a generic API for that by
>moving code from i915 to list.h.
>
>Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>Acked-by: Jani Nikula <jani.nikula@intel.com>


Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>

thanks
Lucas De Marchi

>---
>v4: fixed prototype when converting to static inline
>v3: added tag (Jani), changed to be static inline (Mike)
>v2: dropped the duplicate code in i915 (LKP)
> drivers/gpu/drm/i915/gt/intel_engine_cs.c | 13 +------------
> include/linux/list.h                      | 15 +++++++++++++++
> 2 files changed, 16 insertions(+), 12 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
>index c33e0d72d670..b96c8217743c 100644
>--- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c
>+++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
>@@ -2094,17 +2094,6 @@ static void print_request_ring(struct drm_printer *m, struct i915_request *rq)
> 	}
> }
>
>-static unsigned long list_count(struct list_head *list)
>-{
>-	struct list_head *pos;
>-	unsigned long count = 0;
>-
>-	list_for_each(pos, list)
>-		count++;
>-
>-	return count;
>-}
>-
> static unsigned long read_ul(void *p, size_t x)
> {
> 	return *(unsigned long *)(p + x);
>@@ -2279,7 +2268,7 @@ void intel_engine_dump(struct intel_engine_cs *engine,
> 	spin_lock_irqsave(&engine->sched_engine->lock, flags);
> 	engine_dump_active_requests(engine, m);
>
>-	drm_printf(m, "\tOn hold?: %lu\n",
>+	drm_printf(m, "\tOn hold?: %zu\n",
> 		   list_count(&engine->sched_engine->hold));
> 	spin_unlock_irqrestore(&engine->sched_engine->lock, flags);
>
>diff --git a/include/linux/list.h b/include/linux/list.h
>index 61762054b4be..632a298c7018 100644
>--- a/include/linux/list.h
>+++ b/include/linux/list.h
>@@ -655,6 +655,21 @@ static inline void list_splice_tail_init(struct list_head *list,
> 	     !list_is_head(pos, (head)); \
> 	     pos = n, n = pos->prev)
>
>+/**
>+ * list_count - count nodes in the list
>+ * @head:	the head for your list.
>+ */
>+static inline size_t list_count(struct list_head *head)
>+{
>+	struct list_head *pos;
>+	size_t count = 0;
>+
>+	list_for_each(pos, head)
>+		count++;
>+
>+	return count;
>+}
>+
> /**
>  * list_entry_is_head - test if the entry points to the head of the list
>  * @pos:	the type * to cursor
>-- 
>2.35.1
>