Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 23 Nov 2022 16:33:54 +0100
From:   Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To:     Akihiko Odaki <akihiko.odaki@daynix.com>
CC:     <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
        <intel-wired-lan@lists.osuosl.org>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "Yan Vugenfirer" <yan@daynix.com>,
        Yuri Benditovich <yuri.benditovich@daynix.com>
Subject: Re: [PATCH v2] igb: Allocate MSI-X vector when testing
Message-ID: <Y349YhHLzG7FwomD@boxer>
References: <20221122131145.68107-1-akihiko.odaki@daynix.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221122131145.68107-1-akihiko.odaki@daynix.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gztX+GSaEFO9QCBvftgNi632pBp2T9msFzWKVq3NmL+U5IXZPuOaoA6f8qzU?=
 =?us-ascii?Q?WUBpCs2heGONpYiuyqPugErNMP0wsbylyGgv/Fr/vA92q3rsFMqKmv9Lkc3o?=
 =?us-ascii?Q?thES085kiUP0sJOpY0V5D1z/ekQsVKly3x6Lzxi9/CJOgAeY0EgLXVZTcaCV?=
 =?us-ascii?Q?3iV7CpL5yJWw3+k9ov7YKPh1/fK3H4KbXRYQneQOd7oFZg9ld2eLUyPN0E3I?=
 =?us-ascii?Q?UlQMT+4kJiLGUhn2MsDaLhY+cAgvrQYJx2M4st8QVrcH/Vb6LrF5ex9yX54r?=
 =?us-ascii?Q?PHAcM7jqZwJgovaMVeQ7cTyfHCTVi0sPtS86zl9JhWttTgK77XYU3ia76Z/K?=
 =?us-ascii?Q?9GbxtvfJKS7ioJo6hpSho5it8/mYGc86hlTF63AOD8wsD6vjZFlf5/e4tr+T?=
 =?us-ascii?Q?nPQ03IOQK+noIr3OV0HD/tlYpEpG204k14NlL/Cs6axVUVcVf+/yDsAcC65S?=
 =?us-ascii?Q?mM4rAyHSCwvZvghGy/xCtpIwhi/KlHtnPEPKK4SJR3zvjA88P4bm+sBc1aIQ?=
 =?us-ascii?Q?y6R/MjPPn2Kksf2wi4MJRkEJ2clRg9vhvlR4jdfiUe8KsXdc+tMmMuOGYf9y?=
 =?us-ascii?Q?UVwiO+sJ3OifDbXzfTBw4zPO99UT+xqHbscDYqgS1jLppv8Ksw75zJ5rnwfR?=
 =?us-ascii?Q?XW4VR6VpJRQKE1SL6lZUk6e5nW6eY+n20bqVgPvsj54TOsIbAlQChWQKHXKo?=
 =?us-ascii?Q?XbWdn/d212qMY6ibpw+09AObXHQPyKLieFbi96f4OejNZ2OQffs+OIaH/d8Q?=
 =?us-ascii?Q?Q8djvBLOLDPpmiff/tLOcQG2Tt3ip34vHkOe7jSSP8CT4gHnRIZEiTbzUgqP?=
 =?us-ascii?Q?ysQks+Jy3dihAqbGPkiY1nc7zKilWlDyun3bx/9aJgNEJVrcFbZvksLfblqc?=
 =?us-ascii?Q?r7+iB4Uu7rMSU5fP3cVfVqt3wpz0h+TgtMEPbIzfkRBTBcO67aiBWgCaeeeC?=
 =?us-ascii?Q?9g3qPcoVpGjxM2YTCKW7P6o6+OIz3g4wCi+TakfCDWgOCL4XPoQ6WIHFyAeE?=
 =?us-ascii?Q?oOTefXC8+LooqfcbxVXH8yE9VqgzV/BujMVK4Quw7RA80wzyIhK7gNPzqHyo?=
 =?us-ascii?Q?Fsyyu+seD/mqUV+77loUGg11noiZwRGM/FRdIPIKAE0sUP22SeOe1S1cq/Ey?=
 =?us-ascii?Q?6Ap728QLw7AEPKboN+RYuBkEF3m/c3XtyBWH+XYFCb0bHCgLsuew4S7lrO0K?=
 =?us-ascii?Q?s8TaY1hR29Xrid+oTftWOklOXTjzuHe/whmBqsGkmA2yk0Ds2Wh0tofgBN3l?=
 =?us-ascii?Q?4Yo+ZzEbiTvP+99wNBw4zUq2vpmj0CVt14fhP4I71qpeU9Vg0rlVfNu8UjwD?=
 =?us-ascii?Q?GVM4zVAinDzM+++GA6RSMLnyQY+73T9ocdVGeFdt8J1ffl2JLEUeJ7mNMqkM?=
 =?us-ascii?Q?6j5QjfAOhNJ2PB6zkhK/VcExQY98b31/b0vuREXOWdZlCgtvk8MEM59LDtmx?=
 =?us-ascii?Q?FwiCARIHhjcqA8BQi80GXkjXx7uP+yfKM6CxMsyTxLK/hjHGRIuUCVmiXyrO?=
 =?us-ascii?Q?hoeGIto5aZqvdLd3jHFOy9xA4RUrVojVrlUXntoWQpGeZszy8MUNCp7E2nwB?=
 =?us-ascii?Q?Y2OloRLoJ2f3j7kMdFl6cuNJ1fTpCXPAIR/6UPiu0LJLeO+1BEpGx0+CUBnd?=
 =?us-ascii?Q?yQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3a4c9579-07d5-4647-80d6-08dacd682a5d
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6117.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 15:34:09.8816
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: N/2MRq+QIeu14kJQu5+k9KNSuWOMmB6o9yC4Qu9NOCrt9QY025hqWuN1F0rXdJCqW9XKJH54KWvy7V5fW2lFgoHIfPddY1fPNFNdO7QlrJY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7685
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Nov 22, 2022 at 10:11:45PM +0900, Akihiko Odaki wrote:
> Without this change, the interrupt test fail with MSI-X environment:
> 
> $ sudo ethtool -t enp0s2 offline
> [   43.921783] igb 0000:00:02.0: offline testing starting
> [   44.855824] igb 0000:00:02.0 enp0s2: igb: enp0s2 NIC Link is Down
> [   44.961249] igb 0000:00:02.0 enp0s2: igb: enp0s2 NIC Link is Up 1000 Mbps Full Duplex, Flow Control: RX/TX
> [   51.272202] igb 0000:00:02.0: testing shared interrupt
> [   56.996975] igb 0000:00:02.0 enp0s2: igb: enp0s2 NIC Link is Up 1000 Mbps Full Duplex, Flow Control: RX/TX
> The test result is FAIL
> The test extra info:
> Register test  (offline)	 0
> Eeprom test    (offline)	 0
> Interrupt test (offline)	 4
> Loopback test  (offline)	 0
> Link test   (on/offline)	 0
> 
> Here, "4" means an expected interrupt was not delivered.
> 
> This change routes interrupts correctly to the first MSI-X vector, and
> fixes the test:

Imperative mood, please - "To fix this, route interrupts correctly..."

> 
> $ sudo ethtool -t enp0s2 offline
> [   42.762985] igb 0000:00:02.0: offline testing starting
> [   50.141967] igb 0000:00:02.0: testing shared interrupt
> [   56.163957] igb 0000:00:02.0 enp0s2: igb: enp0s2 NIC Link is Up 1000 Mbps Full Duplex, Flow Control: RX/TX
> The test result is PASS
> The test extra info:
> Register test  (offline)	 0
> Eeprom test    (offline)	 0
> Interrupt test (offline)	 0
> Loopback test  (offline)	 0
> Link test   (on/offline)	 0
> 

You still didn't specify the tree. If it's 'net' and you're not sure about
fixes tag, then please provide some explanation to maintainers why you're
not adding this.

> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
>  drivers/net/ethernet/intel/igb/igb_ethtool.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c
> index e5f3e7680dc6..ff911af16a4b 100644
> --- a/drivers/net/ethernet/intel/igb/igb_ethtool.c
> +++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c
> @@ -1413,6 +1413,8 @@ static int igb_intr_test(struct igb_adapter *adapter, u64 *data)
>  			*data = 1;
>  			return -1;
>  		}
> +		wr32(E1000_IVAR_MISC, E1000_IVAR_VALID << 8);
> +		wr32(E1000_EIMS, BIT(0));
>  	} else if (adapter->flags & IGB_FLAG_HAS_MSI) {
>  		shared_int = false;
>  		if (request_irq(irq,
> -- 
> 2.38.1
>