Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <53680a59-ff01-bc50-ee28-ba0aaff41f3c@socionext.com>
Date:   Thu, 24 Nov 2022 01:09:59 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v2 1/2] dt-bindings: spi: Add Socionext F_OSPI controller
 bindings
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Mark Brown <broonie@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc:     linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20221121014800.13989-1-hayashi.kunihiko@socionext.com>
 <20221121014800.13989-2-hayashi.kunihiko@socionext.com>
 <579f9320-f114-2977-bb70-d5a26a3d2279@linaro.org>
Content-Language: en-US
From:   Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
In-Reply-To: <579f9320-f114-2977-bb70-d5a26a3d2279@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Krzysztof,

Thank you for reviewing.

On 2022/11/23 18:33, Krzysztof Kozlowski wrote:
> On 21/11/2022 02:47, Kunihiko Hayashi wrote:
>> Add devicetree binding documentation for Socionext F_OSPI SPI flash
>> controller.
> 
> Subject: drop second, redundant "bindings".

Ah, ok. I didn't notice it. I'll remove it in next.

>> >> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>> ---
>>   .../bindings/spi/socionext,f-ospi.yaml        | 57 +++++++++++++++++++
>>   1 file changed, 57 insertions(+)
>>   create mode 100644
>> Documentation/devicetree/bindings/spi/socionext,f-ospi.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/spi/socionext,f-ospi.yaml
>> b/Documentation/devicetree/bindings/spi/socionext,f-ospi.yaml
>> new file mode 100644
>> index 000000000000..e04492c4fc84
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/spi/socionext,f-ospi.yaml
>> @@ -0,0 +1,57 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: "http://devicetree.org/schemas/spi/socionext,f-ospi.yaml#"
>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> 
> Drop quotes from both lines.

I see. I'll keep it in mind.

>> +
>> +title: Socionext F_OSPI controller
>> +
>> +description: |
>> +  The Socionext F_OSPI is a controller used to interface with flash
>> +  memories using the SPI communication interface.
>> +
>> +maintainers:
>> +  - Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>> +
>> +allOf:
>> +  - $ref: "spi-controller.yaml#"
> 
> Drop quotes.

Ditto.

> With above:
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

I'll fix the above in v3.

Thank you,

---
Best Regards
Kunihiko Hayashi