Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 23 Nov 2022 16:41:32 +0100
From:   Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To:     Akihiko Odaki <akihiko.odaki@daynix.com>
CC:     <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
        <intel-wired-lan@lists.osuosl.org>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "Yan Vugenfirer" <yan@daynix.com>,
        Yuri Benditovich <yuri.benditovich@daynix.com>
Subject: Re: [PATCH v3] igb: Allocate MSI-X vector when testing
Message-ID: <Y34/LDxCnYd6VGJ2@boxer>
References: <20221123010926.7924-1-akihiko.odaki@daynix.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221123010926.7924-1-akihiko.odaki@daynix.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+Dmct6oijr2ewdLC882EGqo/I4x1sPN7F7hjqNfSLa2mH8nTnZXhuzMdYcLT?=
 =?us-ascii?Q?NhSAqaX5t4G4vqWxNwN3Oei8r6ACF99Tncs7+nCrEMmfYLWbLCQ1zHHLroAa?=
 =?us-ascii?Q?jiKZvLeEbu8YfOETgjBIc3vPVZhY/U22Y3M60h+2OnI56VEI++Mo4H8+IsUa?=
 =?us-ascii?Q?YwsLMvs5rum9l2k0SUmXrCfuU9Ql2GyG6d08eOWpJZjlvHXAjHOn6A71Odiq?=
 =?us-ascii?Q?kd+dxR5usfzaok7iHEFout578D7uLGTmWIJxHG/1iell72NPT4eAayJ6x91r?=
 =?us-ascii?Q?WXjpzxDIh4XPmSWVX8UFCZYnKSTruBxZoh1CXfe2p7FZWWIrHQDE9b2ca15A?=
 =?us-ascii?Q?LvGZG1qRNfJB7hYnmkMEL/PLmHqQvXbbLlfr79jr8MtJsb4lQWyOm6EF7nus?=
 =?us-ascii?Q?Hm1FiUsDm2OlPrTb6NFl+vo0mdy3gqJq0i/BDGNJBc01mIFqCZl+KpgDiNRD?=
 =?us-ascii?Q?5ei2WDzIRudJjpZQeBcTkMAArczyLttAxN2Cr3mBhVzvgH/OFRdDZL2foaFK?=
 =?us-ascii?Q?jWRq5knPIvwvbVQwLk1BRTZjwxy9DAhGc34sRQb3zcH7g4PsRlitSsSf/U97?=
 =?us-ascii?Q?Y4cFLmCVZ6Fde9uuuIUyLDW4SH6NWJ1UywcV8k6Pvpsd7U8ZY+Fr49aIILss?=
 =?us-ascii?Q?HzqiaoOIW77B9Mmcsu/qLA6Ca7TIxQ+8Rbl2CgP3PNhm8swQgtxVSTgLf/cJ?=
 =?us-ascii?Q?QczDg3OedvxVaf6uyOSXII1EDkxjkU/iq4+lJ+QRLxB1gB1zcRA+ibPhduIC?=
 =?us-ascii?Q?9hAS/qCELuS3e+8/S02bHM3IjKHN4ACGzfwDBrDjAmzO5ASlJ30UtFClU3Mg?=
 =?us-ascii?Q?XV0u1Te4i2aC8gTeXY6o3VI2oJqVtgto9dbO0vLqlyfqnuPKesY2Ui1nwO3g?=
 =?us-ascii?Q?bJPHm/Yn+03O7GcNh2PzWwdpusiXNYGptt49O19WvNS+rmjHQ+jzSYZKvqqs?=
 =?us-ascii?Q?sobFVJqqUTQGf+/HxZqB4OlUjccLdewo1fb+Am6961y5Xvl8wBLuclaoY2B4?=
 =?us-ascii?Q?qABlGTg0YwrpscM456IQ5Nr+PkPpBjpjRV5dFSNU0b6nDCDbDuIbaVSfaTZ1?=
 =?us-ascii?Q?XWxYEk7JQfhh9T4gEvHjT8h+E8cu4Nm7fX9h94QwOVAgJuSAUmZW1A2/ur23?=
 =?us-ascii?Q?QJgKQNVooOPlj044Ymf2WVtQxsqnsglJmbFA+SahR2VuJTOlMo6I39QH+fHZ?=
 =?us-ascii?Q?6dhUdEaCiBVejmY34avSvIDphtwR3iEKscNfHHH1t7KVmexxOetIo2qJNGmu?=
 =?us-ascii?Q?1JzLX5BA5pPIUgMtuRpLi9gk3Go0i8pzYfoD4i4XQtImYcWCGoCBM3kmf+LE?=
 =?us-ascii?Q?Z5Hgbhqp+8KGtB9OcRdhiwlR8WSl+su8vfuBx/8Z9nuXclI1WIN7J5eutQ04?=
 =?us-ascii?Q?x7JzLIeSuvsm7q+FVNnonmQYTDuyibJshD74LDZeKn0xciPnV4vtGBo+jybO?=
 =?us-ascii?Q?PG18p5bJ1IuzyelLztRNU1PTsnj51S6D3xQglpiG8QZ7nueE5J7QkUHjtJ0T?=
 =?us-ascii?Q?uPfIkMQd84dlnHsTDU8QiD01bEZ0QVzHEJ63efBw6DFdh/NxJOIkHh9EyFzM?=
 =?us-ascii?Q?KQqeZKiLTmB+73Cl0d4iXECp6aOniGz5nzwlRaH6nF/d4K7k0SjSAE9Y++6e?=
 =?us-ascii?Q?XA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f6a45b3-a985-4444-f57e-08dacd6935c0
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6117.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 15:41:38.5803
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kXu1VKbRhcrHddo4ecZ5PwmICJV72hGm+1CuFdMIpbORa4pdrBppfV9MF9H+R1l4H5tx4Pv2yLV9cWL22DQ8GAICMJHi0Rp+RgxKvCzQTJw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4908
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Nov 23, 2022 at 10:09:26AM +0900, Akihiko Odaki wrote:
> Without this change, the interrupt test fail with MSI-X environment:
> 
> $ sudo ethtool -t enp0s2 offline
> [   43.921783] igb 0000:00:02.0: offline testing starting
> [   44.855824] igb 0000:00:02.0 enp0s2: igb: enp0s2 NIC Link is Down
> [   44.961249] igb 0000:00:02.0 enp0s2: igb: enp0s2 NIC Link is Up 1000 Mbps Full Duplex, Flow Control: RX/TX
> [   51.272202] igb 0000:00:02.0: testing shared interrupt
> [   56.996975] igb 0000:00:02.0 enp0s2: igb: enp0s2 NIC Link is Up 1000 Mbps Full Duplex, Flow Control: RX/TX
> The test result is FAIL
> The test extra info:
> Register test  (offline)	 0
> Eeprom test    (offline)	 0
> Interrupt test (offline)	 4
> Loopback test  (offline)	 0
> Link test   (on/offline)	 0
> 
> Here, "4" means an expected interrupt was not delivered.
> 
> To fix this, route IRQs correctly to the first MSI-X vector by setting
> IVAR_MISC. Also, set bit 0 of EIMS so that the vector will not be
> masked. The interrupt test now runs properly with this change:

Much better!

> 
> $ sudo ethtool -t enp0s2 offline
> [   42.762985] igb 0000:00:02.0: offline testing starting
> [   50.141967] igb 0000:00:02.0: testing shared interrupt
> [   56.163957] igb 0000:00:02.0 enp0s2: igb: enp0s2 NIC Link is Up 1000 Mbps Full Duplex, Flow Control: RX/TX
> The test result is PASS
> The test extra info:
> Register test  (offline)	 0
> Eeprom test    (offline)	 0
> Interrupt test (offline)	 0
> Loopback test  (offline)	 0
> Link test   (on/offline)	 0
> 
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>

Same comment as on other patch - justify why there is no fixes tag and
specify the tree in subject.

> ---
>  drivers/net/ethernet/intel/igb/igb_ethtool.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c
> index e5f3e7680dc6..ff911af16a4b 100644
> --- a/drivers/net/ethernet/intel/igb/igb_ethtool.c
> +++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c
> @@ -1413,6 +1413,8 @@ static int igb_intr_test(struct igb_adapter *adapter, u64 *data)
>  			*data = 1;
>  			return -1;
>  		}
> +		wr32(E1000_IVAR_MISC, E1000_IVAR_VALID << 8);
> +		wr32(E1000_EIMS, BIT(0));
>  	} else if (adapter->flags & IGB_FLAG_HAS_MSI) {
>  		shared_int = false;
>  		if (request_irq(irq,
> -- 
> 2.38.1
>