Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 23 Nov 2022 18:00:12 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Alexander Lobakin <alexandr.lobakin@intel.com>
Cc:     netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: enetc: preserve TX ring priority across
 reconfiguration
Message-ID: <20221123160012.k3h3og6f5tjxpjcg@skbuf>
References: <20221122130936.1704151-1-vladimir.oltean@nxp.com>
 <20221123155116.484163-1-alexandr.lobakin@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221123155116.484163-1-alexandr.lobakin@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8IViytByvMBhilOKp02zCS7RqYA8gJbOA1sYXzdtP7+TWnlSpR/Wq+YrYYaP?=
 =?us-ascii?Q?t2O5XcVp0fDvjnzh008AK8AsdST9jPjV0/LMo+HfsFQXjsDQyvlyzOCc8gD/?=
 =?us-ascii?Q?o0kB51p8VAjL3WWoGXANiL5Kz+QPq2Ajg/jzE7YpqFhrV2Es5Wfb1zuSP7vC?=
 =?us-ascii?Q?jAnZJGrT4Rv1gl6Ccu31m7x9G643eqZJ/wppN75K9ov85VyydLYRHF+IrwcA?=
 =?us-ascii?Q?CKqAN3bUT0RO9VrN4KKkpY0jxaDx7WANdR8Oz5/xnjX7SkP7ELJsz9KxRZok?=
 =?us-ascii?Q?I06v82BHKY2mN8mxWxg0vIXM6lxOjrS07uThT1KQTmZKVBsI4YVrrzxsxcsy?=
 =?us-ascii?Q?B9Xdjecu5R5z22u+PF2pdYuCD+tZFlYPGyBunqmXVduITbueIXzT2GK06u7m?=
 =?us-ascii?Q?1gaN5WRszlpTnH39bgHpvXwTqoEp9BI/ezjDf3dRJARDE+uqiA1c6eCqqcUc?=
 =?us-ascii?Q?VDVnb3S+9/krmkA9IFCV/1Aj7H2sLf6KanrX4X4+fDMaY2X3Uy7CwGc5Ij6/?=
 =?us-ascii?Q?G67NpLiKddvAF/Dy4gUpSYIezTBtn25juvRIpJMFCmqy3ngrx1ojIxRAXGTo?=
 =?us-ascii?Q?sJ0gBV4SiZUdBNsO0fDuMnJug87cGnyNpqIIMIJ2HVLw93dIN6LkP+hWfgdu?=
 =?us-ascii?Q?E+TRky4/0qIGpn1vNfVohDwjh9Qjh088ayOEbx8kD3+CkKxv8BdVYWcoax3f?=
 =?us-ascii?Q?YD6QjdO+k+QGW1NbpcKKecy5plCOVx/jVnS0f2XSOFGoyUzuDV16roYNjEY9?=
 =?us-ascii?Q?sqd020YxPOlnj9ouFA9DaoPKt0BRAqoqxM/hyyKCQMYsv2tfmsrfiozROSUU?=
 =?us-ascii?Q?aPRTf9CrWHJH51qcDWRO/ZZKny1g/jeEXJlb+c+KMjo/cFGIsLBvGOYl7FK5?=
 =?us-ascii?Q?FYp84GVl/tImkp7aQRszk1CFozBKqdkFheLX0WnK1yDypCQO2XXFsWcZESaQ?=
 =?us-ascii?Q?jpB4AWXKo4KpViQ3T5tNE69RiWdPx+OMKhhEaalMR/FvtUKssJj3kIoJ5y2F?=
 =?us-ascii?Q?MRGRoJFtQcRO9vgGLN+BzeBPTMwFougikt5qCTSt5L0wjjIkosrfy4Dq7IW1?=
 =?us-ascii?Q?s+n3zSfabnL5uHxTYVn6RoWC6VabjVF99SckSg9V/AuTJ1SqiH58EWSSnIU8?=
 =?us-ascii?Q?GrJopPHrUtpO5exmd8N4wsQD3Zx5Xr7VTuk62goCoInvHHX1ybZy0HoBPAvc?=
 =?us-ascii?Q?bENs5g9PXW4fUoAqlF3Ym1konrMY42Rtp8OJdCRtOmqEb+c80l1xdhhgneAg?=
 =?us-ascii?Q?uV2x2XIMQzj+SUYozERIspIcZSTh2/tQJ4qgE7vk/fslcPJ5SG7iP2NfoYfv?=
 =?us-ascii?Q?MwuJy6wZn90ORNKUjLwZPitr21w681w96ryxQuQaCE7hOO22AihZ3WS6HY6V?=
 =?us-ascii?Q?3Y3qYr/dvft3D94KGONu+L0dC00S9V8Z1KVYxMIJcxJJb4hXIAYh/gNoFYUY?=
 =?us-ascii?Q?2+mSo4lf//61ZQswWRITxtXQld7UN0oIJvATAzysc0nYqBdW1xhUOHl3dKfS?=
 =?us-ascii?Q?DgV+po1HGcv9ctus3FhyOByNB+5bxS7rhExXMU+efdy09H6Ws2yQUyO0wF5B?=
 =?us-ascii?Q?GF8pmZFb414/GEJYZnUpaKi3xScpRJIBTeJs+fWZZbLetrkFACZs/vKUIYEc?=
 =?us-ascii?Q?Tw=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c61bb1c5-f8f8-40de-cd1c-08dacd6bcfbf
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 16:00:15.9025
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mhNWeuP4FQUkgZ+WhMPH9ZZUJWgdozT4lNcqV4xLxzmM8+loHJgW3EbWPin9aM5A2aZpstUsTZ4XW31Luzstpg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7989
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,T_SPF_PERMERROR autolearn=no
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Nov 23, 2022 at 04:51:16PM +0100, Alexander Lobakin wrote:
> > +	if (err) {
> > +		for (i = 0; i < priv->num_tx_rings; i++) {
> > +			tx_ring = priv->tx_ring[i];
> > +			tx_ring->prio = taprio->enable ? 0 : i;
> 
> Side note: is that `taprio ? 0 : i` correct? It's an error path
> IIUC, why not just unconditional 0?

Yes, it is intended. On error path the priorities are restored.
If taprio->enable was false, but disabling failed, the ring priorities
need to be set as if taprio->enable was true.