Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp7680803rwb; Wed, 23 Nov 2022 09:22:13 -0800 (PST) X-Google-Smtp-Source: AA0mqf6pPJvrOSbMeyzXxVB/1hHMOMM662jG86Cl+IuoPtDZhPZfNLEEUouBphnycM4OZJQkhvln X-Received: by 2002:a17:902:d510:b0:186:b137:4b42 with SMTP id b16-20020a170902d51000b00186b1374b42mr20282643plg.98.1669224132976; Wed, 23 Nov 2022 09:22:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669224132; cv=none; d=google.com; s=arc-20160816; b=J/V5+Sst4TDN26e/JBKkk2gg9pj1nqktFBd4qrvGP3QmuCMuzYqll9K/myEbioM4fI J7XWn8VxAkdpl81rDgWV0cy6ukqJ0zzrFBvQjD1X7GHdRtdWziOExBjbA3LjgAo0wa5n cAESIkZ8ib+wop4h7BcpPIm03nQdBeDs1ImaML/1spZ5/Hpvo+IVR1JTrL7a4qDqjK0s Osymym2VWr6oD1hYk99Jm/gnuYWtv9R+6guIhHXf4FNJqgtYIU41dIa4mB4c5XUkDVMy z2mqbfMZ+zbA8CmSauF/SOs19kEStoGIq3B1wc/eLCEQyzW1HWClFYc9Shjfk9F5D1n8 9VqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=6lCeDeiRogz5q0a+JgeAk8rDzzMR588x6A1V9vUNRaU=; b=HVRpwx2P4z1j7N/xa8yW1DdX09FglFynWsoR10dzTOZFaRQSedpjeR7TzdmSu/4IEA B8Qqei5g8DZWOPlFzoq1h7R64HmDraFeGznaK5kehiLlyzygMsGyxTmeqYf4ByLQuVQh su+9KPnkWdBmF3ladZ9+UN6+Cgi70ydvs3SqXpaZX7NTL2KAnkeCF0Oe20fSx6E1LLhP 1lLmnV+ggiNXTdPQ2bKDh9YesNOuVaQxx8kL0EcbrCJqHGeA9H9KzOoG6jHx4T4aApj6 UMGciiJKu4F/W65wAnPpgqj3xAEYN/XOgLLgvbqf/ecx4nxnp+oREQ8+nKHVN+JS/c0h V3aw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ml5eeCLV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dc8-20020a056a0035c800b005728c05ef9esi501529pfb.14.2022.11.23.09.22.01; Wed, 23 Nov 2022 09:22:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ml5eeCLV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238872AbiKWRGj (ORCPT + 88 others); Wed, 23 Nov 2022 12:06:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238755AbiKWRGe (ORCPT ); Wed, 23 Nov 2022 12:06:34 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7AAA8A9963; Wed, 23 Nov 2022 09:06:33 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1804361DF7; Wed, 23 Nov 2022 17:06:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A50CDC433D6; Wed, 23 Nov 2022 17:06:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669223192; bh=Bv+gg9QsVueJO7E+n5Q2iX6/w77b8aeX5SBwgMpol3M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ml5eeCLV3q9PB5lnsVbFjpEZNZfEthRtv6kmtwD/gl7fqVM+CnAhx1hkxr42fOJzC 6zGXYhy0ClkCfve+FJnXp98fdTdxa2gEOgayNaw+fk45fMoYP0/O2caP3yrlg4zLTL P8X/HB5GI8dn/cn872xr/itsAcLDUykhkDbzkChVyQLTgxMwkMRGmxv6k557emQG1O 2Pc7omffgZtUltUfee0ePvkQrKzdZfIOB8DzbXMR0cbkYcOXLgTQQRx1J7eMz0RlKl M5YbixpK9BwcPBt8J0w0BswMo3XwCZyGlx/fm06760eW/Dr0N9iJCx6XKnZ45DOFv5 Eu2kpvo2Zd/kA== From: Daniel Bristot de Oliveira To: Daniel Bristot de Oliveira , Steven Rostedt Cc: Masami Hiramatsu , Jonathan Corbet , Juri Lelli , Clark Williams , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH V2 1/6] tracing/osnoise: Fix duration type Date: Wed, 23 Nov 2022 18:06:19 +0100 Message-Id: X-Mailer: git-send-email 2.32.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The duration type is a 64 long value, not an int. This was causing some long noise to report wrong values. Change the duration to a 64 bits value. Fixes: bce29ac9ce0b ("trace: Add osnoise tracer") Acked-by: Masami Hiramatsu (Google) Cc: Daniel Bristot de Oliveira Cc: Steven Rostedt Cc: Masami Hiramatsu Cc: Jonathan Corbet Signed-off-by: Daniel Bristot de Oliveira --- kernel/trace/trace_osnoise.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/trace/trace_osnoise.c b/kernel/trace/trace_osnoise.c index 78d536d3ff3d..4300c5dc4e5d 100644 --- a/kernel/trace/trace_osnoise.c +++ b/kernel/trace/trace_osnoise.c @@ -917,7 +917,7 @@ void osnoise_trace_irq_entry(int id) void osnoise_trace_irq_exit(int id, const char *desc) { struct osnoise_variables *osn_var = this_cpu_osn_var(); - int duration; + s64 duration; if (!osn_var->sampling) return; @@ -1048,7 +1048,7 @@ static void trace_softirq_entry_callback(void *data, unsigned int vec_nr) static void trace_softirq_exit_callback(void *data, unsigned int vec_nr) { struct osnoise_variables *osn_var = this_cpu_osn_var(); - int duration; + s64 duration; if (!osn_var->sampling) return; @@ -1144,7 +1144,7 @@ thread_entry(struct osnoise_variables *osn_var, struct task_struct *t) static void thread_exit(struct osnoise_variables *osn_var, struct task_struct *t) { - int duration; + s64 duration; if (!osn_var->sampling) return; -- 2.32.0