Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp7686827rwb; Wed, 23 Nov 2022 09:26:43 -0800 (PST) X-Google-Smtp-Source: AA0mqf6eu6g5fsOqY7ontG6GiHquZZOk5iBOwdsAcq8qHq3WVzhhB3H7vw8NJLE+n7oXF/oEV+Qc X-Received: by 2002:a17:902:9343:b0:186:9890:97d1 with SMTP id g3-20020a170902934300b00186989097d1mr9873335plp.114.1669224402911; Wed, 23 Nov 2022 09:26:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669224402; cv=none; d=google.com; s=arc-20160816; b=W+qO8gEn1R8O3E8RrU/R59wW/tst5VFhmE5i1zPjulY+eSsLmCfWBdqcR16AYdkFmC Fxzo2edDGRbLZluZ5/hHNJvbSUl1qnyctP8sNcuA1RHg7mnzbzylEM0oH2brSNE5Z+f2 7zCOmzitzRagEM9hrZOIZJIuQAQ7phWe6fiCNecMhq7M4S/ehhal8jNcdwn2dV8z3ykg wZAumVnB+edadgT5CooXghbTahwjVIeC1klsMYqCqSGgG4EvYFH25iafqUDI1PjcIX+b T5UfWFiwX/cCVrkjWTtWxne/JnA+GVHNIql1Do0AHFM8GiGmMDEu9t1MDf6r+TqPmKVI qN3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=l6WAHGSkkMZz4xyhTBSeAj/uAOQoq3aveLnPI9NahNk=; b=RI0Mj4qLfh0hsmH5KTMr4GgnjvEIxvgvcRRBqfUfRcHc0FKArUyExhG/K0ARCxzYaZ fcf7dJmK6zRnQq4bl1OYPrUHY87czWkSBhRIX4hYTetFv4dWn+UmWKmUdBl9/b6X+pdb 2sKZrtL0QK+qPI+mZYBeMU8walGDGW9NnMBgP0G92gEkhrzxjIMCpDj8k7LRumbB2mzj urHjOcuq2dKb5mvzHcICzQFYYYGdRdnGX5zrQvbNC4SPYs/vypaqk7wVjJPYdf4fxvaq CozZcblSj5l+e8b9t8wqgg/g3QXAs2mvTGtz7KREW5Vcqz/kO127m+p4E42TKokvCmIm gtwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=qo8vJIEr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n1-20020a634d41000000b0046b2bef339csi17162619pgl.257.2022.11.23.09.26.31; Wed, 23 Nov 2022 09:26:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=qo8vJIEr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237630AbiKWRB5 (ORCPT + 88 others); Wed, 23 Nov 2022 12:01:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235738AbiKWRBx (ORCPT ); Wed, 23 Nov 2022 12:01:53 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E20E32B9B; Wed, 23 Nov 2022 09:01:52 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E04F561DFD; Wed, 23 Nov 2022 17:01:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 777BCC433D6; Wed, 23 Nov 2022 17:01:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1669222911; bh=o3haMfaeHZfYTyEePRwp9h5E4unKgpaM0OuqyhoXnp0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qo8vJIErhb/ipCwuy4gwV/i9YmIAaJMojUiZPS4IOOd8yQY7LyT3VrOZMJTKRDS9x i8L49I9CCW+G4gWPmwXnGTUcpWsWu7OwHPDHLjbFVstIHlX3U3iCwopRHJdZmvOcLy DUuQU3VjRGKHYyj8ctniAuEtEhb8ztF3vFHL+6eY= Date: Wed, 23 Nov 2022 18:01:47 +0100 From: Greg Kroah-Hartman To: Jason Gunthorpe Cc: Matthew Wilcox , Maximilian Luz , Andy Shevchenko , linux-kernel@vger.kernel.org, Jens Axboe , "Rafael J. Wysocki" , Len Brown , Stefan Richter , Wolfram Sang , Alexandre Belloni , Dmitry Torokhov , Sean Young , Mauro Carvalho Chehab , Rob Herring , Frank Rowand , Hans de Goede , Mark Gross , Vinod Koul , Bard Liao , Pierre-Louis Bossart , Sanyog Kale , Andreas Noever , Michael Jamet , Mika Westerberg , Yehezkel Bernat , Jiri Slaby , Heikki Krogerus , "Martin K. Petersen" , Chaitanya Kulkarni , Ming Lei , Jilin Yuan , Alan Stern , Sakari Ailus , Thomas Gleixner , Ira Weiny , Dan Williams , Won Chung , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-acpi@vger.kernel.org, linux-block@vger.kernel.org, linux-i2c@vger.kernel.org, linux-i3c@lists.infradead.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, linux1394-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH 3/5] driver core: make struct device_type.uevent() take a const * Message-ID: References: <20221123122523.1332370-1-gregkh@linuxfoundation.org> <20221123122523.1332370-3-gregkh@linuxfoundation.org> <711d5275-7e80-c00d-0cdc-0f3d52175361@gmail.com> <97be39ed-3cea-d55a-caa6-c2652baef399@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 23, 2022 at 12:25:32PM -0400, Jason Gunthorpe wrote: > On Wed, Nov 23, 2022 at 04:37:59PM +0100, Greg Kroah-Hartman wrote: > > static inline struct device *__kobj_to_dev(struct kobject *kobj) > > { > > return container_of(kobj, struct device, kobj); > > } > > > > static inline const struct device *__kobj_to_dev_const(const struct kobject *kobj) > > { > > return container_of(kobj, const struct device, kobj); > > } > > > > /* > > * container_of() will happily take a const * and spit back a non-const * as it > > * is just doing pointer math. But we want to be a bit more careful in the > > * driver code, so manually force any const * of a kobject to also be a const * > > * to a device. > > */ > > #define kobj_to_dev(kobj) \ > > _Generic((kobj), \ > > const struct kobject *: __kobj_to_dev_const, \ > > struct kobject *: __kobj_to_dev)(kobj) > > > > > > Want me to do the same thing here as well? > > It would be nice to have a shared macro code gen all of the above > instead of copy and pasting it. Then maybe other cases beyond struct > device could adopt const too.. I think I tried to create such a beast, but failed, so ended up open-coding it in a few places in the USB headers already. I can try it again, but the redirection gets tricky (defines creating defines...) thanks, greg k-h