Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221122213040.4128105-1-haowenchao@huawei.com>
 <4d21f806-6653-5457-918c-563a3032d128@suse.com> <00f11c61-a53f-c48a-017f-4c06055ea708@huawei.com>
 <717da158-5a7e-b478-61d3-3753b0b00e01@oracle.com>
In-Reply-To: <717da158-5a7e-b478-61d3-3753b0b00e01@oracle.com>
From:   Wenchao Hao <haowenchao22@gmail.com>
Date:   Thu, 24 Nov 2022 01:38:51 +0800
Message-ID: <CAOptpSMO5+Orp20S=WD-SezVOBEwJyKJSMjaCENN+4jXMX2X-A@mail.gmail.com>
Subject: Re: [PATCH] scsi:iscsi: Record session's startup mode in kernel
To:     Mike Christie <michael.christie@oracle.com>
Cc:     Wenchao Hao <haowenchao@huawei.com>, Lee Duncan <lduncan@suse.com>,
        Chris Leech <cleech@redhat.com>,
        "James E . J . Bottomley" <jejb@linux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org, liuzhiqiang26@huawei.com,
        linfeilong@huawei.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Nov 24, 2022 at 1:29 AM Mike Christie
<michael.christie@oracle.com> wrote:
>
> On 11/22/22 10:41 PM, Wenchao Hao wrote:
> > Sorry I did not highlight the key points. The root reason we need to record
> > node_startup mode in kernel is userspace's node_startup mode is unreliable in
> > some scenarios:
> >
> > 1. iscsi node and session is created in initrd, the configure files of these
> >    nodes would be lost after we switch to rootfs
> > 2. someone do iscsiadm -m discovery but did not specify the operation mode,
> >    the iscsi node's node_startup would be updated to which specified in iscsid.conf
> > 3. someone do iscsiadm -m node -o update to update nodes' configure
> >
> > What's more, it seems "iscsiadm/iscsid" only refuse to logout of an ONBOOT
> > session when logout is specificed by "--logoutall". We still can logout an
> > ONBOOT session with "iscsiadm -m node -u comamnd".
>
> logout_by_startup does go by the startup setting, but I think you missed the
> session_in_use related code. It checks the mounts and holders already. Just
> change it for whatever you need. I think your lvm use case should be covered
> by the holder check. If not, add it.

I did not enable the iscsid.safe_logout in iscsid.conf, so the session
still could be logged out.
If tested with iscsid.safe_logout set to "Yes", the issue is solved.

Thanks a lot