Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp7787934rwb; Wed, 23 Nov 2022 10:43:05 -0800 (PST) X-Google-Smtp-Source: AA0mqf7ytnpW+oM5PpHY8D3oUQSBBAkkCoRcscCPnyeQtkkwX9PKkzfCqhtyHjq6NSRYih/gwoAj X-Received: by 2002:a17:906:4351:b0:78d:513d:f447 with SMTP id z17-20020a170906435100b0078d513df447mr11125600ejm.708.1669228985413; Wed, 23 Nov 2022 10:43:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669228985; cv=none; d=google.com; s=arc-20160816; b=TQW4M59/sfIVARXeHTjB7gX4gF23y9bobkdeNtIpWQkmZeetSICvBzw+X5e+xd1Uiw mfNIjS/rZ7XmD9PVFvIRnqxAK5vQDZnLUsWqwTTLhF0YIbJFcD5E97u7ENCnOlsRC3QC grI54Npgg1/RwTvAorxEVqFpiqajr5J+WrrXBiZ0Am3JCM5z5xbIqNjldCWFfdLTEW/d vNRlASwSB5Blnn0wHoQ+EFGnJevriFOLOY1c8WpFAAagKE2b8Sfi7CI/BeOfuy7MmBbU KQlWlfMdETJbqFn/7Dtszd6Az20LZ3tnHRDfFt2bQxHqG/ee8qk1Xk2RxPJdbDDA1Fzg aL8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=DQVPLKYFSJ4QgW7SluwF8mIfyxsYEuGishngmx0s4yI=; b=uNR8RB41CAc3MRoxCkQvbuj84t1LyA/A8JNpRO8WAayfrrq34IfPLBUOiRhwWF5NWr 9cjSvTDn3JVy1m8ZhGBnPinZMS2ZVXU3Sgqq9e4aFKrTaVPpwqprLCqQNtV1TnPMvUmm b1IaUZUosL7BSj4IxO+b4cyI+MLzCIQjN21DiQT/LLWfgZ+Nw7umXvAnBbiB/XziwlhA rlx4smuN5CMxQqwwbsXdB/XZE7254yl5/L3aJZVDfqJ+iX/9oYBPXKiMpOW5SLPNsy3x J3djTYHhjK1Eoqd24dPVxedzAlEHCCVv7WEHwf7EvYZs5Ro+V67q9s6s7iU5vdUy1NHM K60Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=EBWluekW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l14-20020a1709065a8e00b0073d8659db5csi11597512ejq.966.2022.11.23.10.42.37; Wed, 23 Nov 2022 10:43:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=EBWluekW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239588AbiKWSaW (ORCPT + 89 others); Wed, 23 Nov 2022 13:30:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239221AbiKWS3w (ORCPT ); Wed, 23 Nov 2022 13:29:52 -0500 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B457B6A; Wed, 23 Nov 2022 10:29:51 -0800 (PST) Received: by mail-pj1-x1031.google.com with SMTP id w4-20020a17090ac98400b002186f5d7a4cso2912856pjt.0; Wed, 23 Nov 2022 10:29:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=DQVPLKYFSJ4QgW7SluwF8mIfyxsYEuGishngmx0s4yI=; b=EBWluekWbdhZB0XWgYo6kN7mgHPwsTZJrKzgmUs8vlIN+toDkOZB3gh8SghcH4Pdw9 aetVZ1tDqRGd1wbMXS1qQYE5bitUukYhkFNFOimSTAziveZAdtvbr5L9NemY/FbCbSz1 XNX+coHGs2w8DymzXAPofEJU3+sZ7WHwveRNlINCZXNlZyourTP1tXxgi3DJrifrLPhP 4CucWDTHDSMTcDjSvcOw07KUm4WSMcMQMhnhdzg+/WDShWJ0l6gh2Lsbua6JJNZnj0+d DWXHTdA13OqZkuSNA7/VfpvnLJ/CwTxdFJLGyj9oFQnz5u6RGexuKuyRixkee+IppZNv VNog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DQVPLKYFSJ4QgW7SluwF8mIfyxsYEuGishngmx0s4yI=; b=1qaccWJKkmC3HBW3T9G2HrAMj+QY7rxVVfPxDUN3CAZbl5IvO4WypfbzxiTJp0xqoe kuRKSpVjCwQJDpr3P8GYN/SeAzml4RGhdyaF6RYO/zwyVteyD7gM7KlJoAZzdwl/kkqz cX1Av01m0QR2frGHssLhCft7q9lSDCClLPan3IIedILkC5sT2tjsGuKn7c0as2z/kM6A zVGplOQO5wajPQfoYz6+MPG68CZfQjdK1U+JQF64LF4/F8ojfdz0tnQfGH4Hqgfd5ID6 G2nCSjzUYzBSTkMXsNhLFSN/CE7xiUD4++vfMcSQEd+zxUqeek0jjWocVlstLqWEF/qK kEJQ== X-Gm-Message-State: ANoB5plpVQqRH6pCGXsZmoCubTRsrrBV/0f2znC47B+zwAJQ6QF0trZ6 4q7ZyXDU6f0erq80xgXpPo9yNePiO8o= X-Received: by 2002:a17:902:bf06:b0:188:5688:828b with SMTP id bi6-20020a170902bf0600b001885688828bmr13311929plb.129.1669228190841; Wed, 23 Nov 2022 10:29:50 -0800 (PST) Received: from localhost (2603-800c-1a02-1bae-a7fa-157f-969a-4cde.res6.spectrum.com. [2603:800c:1a02:1bae:a7fa:157f:969a:4cde]) by smtp.gmail.com with ESMTPSA id j11-20020a170902da8b00b001894881842dsm1837953plx.151.2022.11.23.10.29.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Nov 2022 10:29:50 -0800 (PST) Sender: Tejun Heo Date: Wed, 23 Nov 2022 08:29:49 -1000 From: Tejun Heo To: Kemeng Shi Cc: josef@toxicpanda.com, axboe@kernel.dk, cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 11/11] blk-throttle: Use more siutable time_after check for update slice_start Message-ID: References: <20221123060401.20392-1-shikemeng@huawei.com> <20221123060401.20392-12-shikemeng@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221123060401.20392-12-shikemeng@huawei.com> X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 23, 2022 at 02:04:01PM +0800, Kemeng Shi wrote: > Use more siutable time_after check for update slice_start Why is it more suitable? -- tejun