Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Tejun Heo <htejun@gmail.com>
Date:   Wed, 23 Nov 2022 08:27:17 -1000
From:   Tejun Heo <tj@kernel.org>
To:     Kemeng Shi <shikemeng@huawei.com>
Cc:     josef@toxicpanda.com, axboe@kernel.dk, cgroups@vger.kernel.org,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/11] blk-throttle: remove incorrect comment for
 tg_last_low_overflow_time
Message-ID: <Y35mBVQgYgCvmZhz@slm.duckdns.org>
References: <20221123060401.20392-1-shikemeng@huawei.com>
 <20221123060401.20392-8-shikemeng@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221123060401.20392-8-shikemeng@huawei.com>
Precedence: bulk

On Wed, Nov 23, 2022 at 02:03:57PM +0800, Kemeng Shi wrote:
> Function tg_last_low_overflow_time is called with intermediate node as
> following:
> throtl_hierarchy_can_downgrade
>   throtl_tg_can_downgrade
>     tg_last_low_overflow_time
> 
> throtl_hierarchy_can_upgrade
>   throtl_tg_can_upgrade
>     tg_last_low_overflow_time
> 
> throtl_hierarchy_can_downgrade/throtl_hierarchy_can_upgrade will traverse
> from leaf node to sub-root node and pass traversed intermediate node
> to tg_last_low_overflow_time.
> 
> No such limit could be found from context and implementation of
> tg_last_low_overflow_time, so remove this limit in comment.
> 
> Signed-off-by: Kemeng Shi <shikemeng@huawei.com>

Acked-by: Tejun Heo <tj@kernel.org>

-- 
tejun