Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a89de82d-41e7-a40f-a5a3-83ad62bf383f@redhat.com>
Date:   Wed, 23 Nov 2022 14:05:59 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH] cgroup/cpuset: Optimize update_tasks_nodemask()
Content-Language: en-US
To:     Tejun Heo <tj@kernel.org>
Cc:     "haifeng.xu" <haifeng.xu@shopee.com>, lizefan.x@bytedance.com,
        hannes@cmpxchg.org, cgroups@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20221123082157.71326-1-haifeng.xu@shopee.com>
 <Y35Swdpq+rJe+Tu3@slm.duckdns.org>
 <5fccf438-fdbe-1bc8-6460-b3911cc51566@redhat.com>
 <Y35sbREgYE6aIdIp@slm.duckdns.org>
From:   Waiman Long <longman@redhat.com>
In-Reply-To: <Y35sbREgYE6aIdIp@slm.duckdns.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 11/23/22 13:54, Tejun Heo wrote:
> On Wed, Nov 23, 2022 at 01:48:46PM -0500, Waiman Long wrote:
>> I think it is an issue anyway if different threads of a process are in
>> different cpusets with different node mask. It is not a configuration that
>> should be used at all.
> Anything memory related is in the same boat and people still use them
> reaching whatever end results they reach. Given the whole thing is pretty
> ill-defined, I don't wanna change the behavior now.
I am just saying that this is not a good config. I don't have any 
intention to change the existing behavior at all.
>
>> This patch makes update_tasks_nodemask() somewhat similar to cpuset_attach()
>> where all tasks are iterated to update the node mask but only the task
>> leaders are required to update the mm. For a non-group leader task, maybe we
>> can check if the group leader is in the same cpuset. If so, we can skip the
>> mm update. Do we need similar change in cpuset_attach()?
> The leader isn't special tho. We just wanna avoid visiting the same mm more
> than once, right?

Right, the group leader is just a marker to make it easier to avoid 
duplicating the work for the same mm. If the group leader happens to be 
in another cpuset, it will suffer some performance consequence.

Cheers,
Longman