Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 23 Nov 2022 11:23:36 -0800
From:   Dan Williams <dan.j.williams@intel.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        <linux-kernel@vger.kernel.org>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jens Axboe <axboe@kernel.dk>,
        Alison Schofield <alison.schofield@intel.com>,
        "Vishal Verma" <vishal.l.verma@intel.com>,
        Ira Weiny <ira.weiny@intel.com>,
        "Ben Widawsky" <bwidawsk@kernel.org>,
        Dan Williams <dan.j.williams@intel.com>,
        Jeremy Kerr <jk@ozlabs.org>, Joel Stanley <joel@jms.id.au>,
        Alistar Popple <alistair@popple.id.au>,
        Eddie James <eajames@linux.ibm.com>,
        "Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        Jilin Yuan <yuanjilin@cdjrlc.com>,
        "Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
        Alan Stern <stern@rowland.harvard.edu>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        Won Chung <wonchung@google.com>, <linux-block@vger.kernel.org>,
        <linux-cxl@vger.kernel.org>, <linux-fsi@lists.ozlabs.org>,
        <linux-usb@vger.kernel.org>
Subject: RE: [PATCH 4/5] driver core: make struct device_type.devnode() take
 a const *
Message-ID: <637e733838b5f_12cdff29466@dwillia2-xfh.jf.intel.com.notmuch>
References: <20221123122523.1332370-1-gregkh@linuxfoundation.org>
 <20221123122523.1332370-4-gregkh@linuxfoundation.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221123122523.1332370-4-gregkh@linuxfoundation.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?prQzOnHJzwAe5tBwvvR1tLGDRr8KsFUTTA8YO6tAawe/UXsdBdyHsCR+L2ON?=
 =?us-ascii?Q?hmTOcfO24F6f0nzOddbK5k/uNkhe/0/fcoP8CHZg2NLDt3CzWGh5n2Yp8Plu?=
 =?us-ascii?Q?kJm9MrIZCDkhbde7NdnsCaWel8+fN7Nbybc7UQEaKgHBX65ZSXLPY2ZBdXJz?=
 =?us-ascii?Q?s4M1hLWVjgU2WZi5eFo0jndOiwhHrfq4tHBeY/lCm1k4olQizzr7RtZ5ZlZh?=
 =?us-ascii?Q?RmZvVhNIrK3cLWFtRoPy1xIGaKbstNzYNdqZLOE+fQyLnz5YOJ6kaPkwch4L?=
 =?us-ascii?Q?Q/7E8YHDYQBKs3AWAR9vqCQQXdakaQKIt1pu+rmWjmxsN9dTNoVjnc5u0Nq4?=
 =?us-ascii?Q?4nTS8Nb+w3wY+axKoepS+28scz1vgq5Hb5DJKJAdayX/w+hrmlx/abZoYY4l?=
 =?us-ascii?Q?bo45FVQyNJa9XcxtKsfoz4XUU8egIFGCB1DaVHHUep65TFhXmENW7Vyfk+6Q?=
 =?us-ascii?Q?20dIRVu++4L3KFQ5SRMyH18E9/Vybfz3+sxweVApB73r5kwLPMke+g+dLhVO?=
 =?us-ascii?Q?3AMmlwBRp5Bt2c4uv4lisqyvr0K+ajOV4sLahDpFgPOADo3Vf6UUOFz+TiaO?=
 =?us-ascii?Q?rg4Kawk5RQmGQMK3Knk6hvfbPvLGY84dOwZJSkc//oXSrdX0iimaLC6ycPU3?=
 =?us-ascii?Q?GCRMGMGE+csrd20sFMrHC2IZNfDimZ+KKZQgNcmLcMz6ZW2ULI+S66IVy3zj?=
 =?us-ascii?Q?zGVgLhKjjyz0l8PszXSq9PpC3BLRY18krxH1xWzqKTG3IsBrx3DjRVEUYTa1?=
 =?us-ascii?Q?6AUAKhgzP90IxTBK9qEfOg0YJozRzLfZE4bR39tqTc7xQ1WLB/VDOKTFJhMB?=
 =?us-ascii?Q?n2iEoZJJ31SsKoXU6vQgJJzFbbBFDRjJmiVu0KeHRnu2hLQW0OnYOniIBUdZ?=
 =?us-ascii?Q?3dicNpOFoPCL7GPR/OrDQXqWLZkFGqLg55fFfLJsc6HU7nYhPw7U2q8AEcAa?=
 =?us-ascii?Q?ELSSDdXd9rGpzq6ocmKGAzv6n25K2xmZOru1Iiw/hiLTjUGv3M27DJFiwdjJ?=
 =?us-ascii?Q?BvqzaB5/SK0wrqB00TKsrNUliD2PlJNsutBSpoLesOOkQl2nXq8Dc+YYzPc7?=
 =?us-ascii?Q?UwlE1vZoPUKTQzhi8U1FokHlXnebDOZTCpWqdqtH7McqK28OLW51ddLXvKBY?=
 =?us-ascii?Q?zfmawqq8+26qSUTJJJVUNxQoacCgo88hHQB/IvMmr5KQlBVLosaqGJlflg9F?=
 =?us-ascii?Q?tPrF7w/zi0+TpQphVHD2Z9USxDvte8GO0Eq/tnKbix6xdRNq/WiB+uFn8wS9?=
 =?us-ascii?Q?aDmYsAAYu5sVJFdC4N0WOTxX0EacXAOhJsBHX5vY7y14U6jrEPGrhy+XTMJ/?=
 =?us-ascii?Q?X616HK0TexGE3yyt7SnajT97dxKF7WI7I0FHIdp7CXcBDsXdcgi90WTVLjR6?=
 =?us-ascii?Q?g38cRslysS4SFt4BAQAOyXuipENHty7DhWROnKpww8abAGNSNQvDpNpKU1DB?=
 =?us-ascii?Q?5/OtPRdR9G6Rar7aTcp+vh+Dn2h1I+LZvgwU8Kmic5y7NcxmxxBIE5xIz/0J?=
 =?us-ascii?Q?4vekGDDC66muXYbDXzi+w40zTRjRi1KEva6nacaBrqON8byQYDOC3R68AIEK?=
 =?us-ascii?Q?Ip4X31rNjyCmyTjfa+k80ePhFuyiQFGKFGyGag17vCKx/Cs5toDo8ujbYWYX?=
 =?us-ascii?Q?bg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f4b21d04-acc5-419f-78e5-08dacd8839d8
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 19:23:41.0454
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /d4Rb3gRAt+EF7IIe5+HPWTaOYwgx58FF7BVf1E9HkM/8W+b+RYYY7iGGrzbEjxEfMaUQnOhqfpd7R+79qrnLEWe3JwasVxsMD9e/W4BIlI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6825
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Greg Kroah-Hartman wrote:
> The devnode() callback in struct device_type should not be modifying the
> device that is passed into it, so mark it as a const * and propagate the
> function signature changes out into all relevant subsystems that use
> this callback.
> 
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: Alison Schofield <alison.schofield@intel.com>
> Cc: Vishal Verma <vishal.l.verma@intel.com>
> Cc: Ira Weiny <ira.weiny@intel.com>
> Cc: Ben Widawsky <bwidawsk@kernel.org>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Jeremy Kerr <jk@ozlabs.org>
> Cc: Joel Stanley <joel@jms.id.au>
> Cc: Alistar Popple <alistair@popple.id.au>
> Cc: Eddie James <eajames@linux.ibm.com>
> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Jilin Yuan <yuanjilin@cdjrlc.com>
> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Cc: Alan Stern <stern@rowland.harvard.edu>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Jason Gunthorpe <jgg@ziepe.ca>
> Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
> Cc: Won Chung <wonchung@google.com>
> Cc: linux-block@vger.kernel.org
> Cc: linux-cxl@vger.kernel.org
> Cc: linux-fsi@lists.ozlabs.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-usb@vger.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
[..]
> diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c
> index 20ce488a7754..6ae8d0bdc61b 100644
> --- a/drivers/cxl/core/memdev.c
> +++ b/drivers/cxl/core/memdev.c
> @@ -27,7 +27,7 @@ static void cxl_memdev_release(struct device *dev)
>  	kfree(cxlmd);
>  }
>  
> -static char *cxl_memdev_devnode(struct device *dev, umode_t *mode, kuid_t *uid,
> +static char *cxl_memdev_devnode(const struct device *dev, umode_t *mode, kuid_t *uid,
>  				kgid_t *gid)
>  {
>  	return kasprintf(GFP_KERNEL, "cxl/%s", dev_name(dev));

For the CXL bit:

Acked-by: Dan Williams <dan.j.williams@intel.com>