Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp7893592rwb; Wed, 23 Nov 2022 12:13:23 -0800 (PST) X-Google-Smtp-Source: AA0mqf5KlcInylegPIi6V+8nYGB58wKEo4/syI+zTnZedYDIm7T745/mJiq0VheYikBYBHrLakFB X-Received: by 2002:a63:1824:0:b0:46e:baf4:ab7a with SMTP id y36-20020a631824000000b0046ebaf4ab7amr28853156pgl.37.1669234403477; Wed, 23 Nov 2022 12:13:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669234403; cv=none; d=google.com; s=arc-20160816; b=yBnEBiv8tHVWPJvAdNCWaWe/iofLOxwD92MFJ7rmHxNYteBEx9ODhqFhQ0O1s0Piur Pi0ujJT0OHRyFFNXaKn6liSjDFa5Ur3L7u6IBdJAH1rIc3pt/gHTohyeTnmvdKadcMtA wu0QfrYbs9cNIEaJsLdX7uaHoKHtsYbdUkujjDzhQrwgA0BXHchgZu5p85iwtrqHFqMU /IRJyyNDHKXJcyQ/A2Rg8Cm7ECZUYU8QvhwHttLGAUWnr0HjIZIwO3148sHv2kS1Cn9+ toNaZ/QHTNGxuBhkDNptLL+BQSk1WOkFQ8g9A8i1LzEk8p2DsRGtk8D2/zzMoZBUtVAo 4Maw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=SwMzuEDw937D1BNWUA0+s7FH/Sv/GWnLAgn8jMy5G/0=; b=jo17aEvc3OLK1iDHdDvv6/Lvj7v8qiVlSquVQCb8bKq2vS6grnDTJE7nyZBaSN1TJg Z+/qFzFLTJoAYbRqlA5vLp33sfFumwEApOUq9LFrN1Udv5b3w3eCDe9h9cfdjOmeIzso LQHrsDz4F1Wj1c5hnIh8TuhQSfUiD0Hxhubqm9e+b9WIuoaPW7s7rhjU6RRa4A42HF82 27kOEK9H5i6vUWwaE+hdIGfr5YYDg31dIsNAI7QyXJjri7lXeZxeoMM5i0g448+FFuYA t3vSwia4ZGu7daSl8s9DteT82UkD1WKwxKvUMDTvy+QPKgHyZi3AuRBXuoTSV5w9ymsr FZpg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b="g/nn420R"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u62-20020a638541000000b00476df56b35dsi512683pgd.699.2022.11.23.12.13.12; Wed, 23 Nov 2022 12:13:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b="g/nn420R"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237382AbiKWTTi (ORCPT + 88 others); Wed, 23 Nov 2022 14:19:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238966AbiKWTTg (ORCPT ); Wed, 23 Nov 2022 14:19:36 -0500 Received: from mail-ua1-x931.google.com (mail-ua1-x931.google.com [IPv6:2607:f8b0:4864:20::931]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5480CE3B for ; Wed, 23 Nov 2022 11:19:35 -0800 (PST) Received: by mail-ua1-x931.google.com with SMTP id a19so4170793uan.2 for ; Wed, 23 Nov 2022 11:19:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=SwMzuEDw937D1BNWUA0+s7FH/Sv/GWnLAgn8jMy5G/0=; b=g/nn420R1OojaK+ZrP5yWqCPRWhqBR3yJ1bGeZnSy5rk1jJk4NsK6VjXpTG+jsegam dBm2h9744Pvni4Tx3Vg54pqwd9DZjb1z22H0MRPKB+9jQeP56FN28EFvVyFJz2E5LBJ9 oImZsEE9BVhSfGNwgLNk2FshAC5d0BF1yGL9i7WxmEAZHKb39SwzeGlFMlYz+KbBSU/1 OBcH6y45lXdKxud/yud4DKrczBhWp7gVspfwxvN5+bANrEhxzl32kMonJcRnomPu/vRA fHY4Ktf8hzgF8/QRtPHetAsVza0ZL9CslbOCwPxxHRp9lsOejr9Lr8cvglm0ml7YP14v LTmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SwMzuEDw937D1BNWUA0+s7FH/Sv/GWnLAgn8jMy5G/0=; b=S8B1fPMfKoOp1MbfERH40q6FOjmsqqmpWrAkeYFy2BGbooCHC8o//fy4OcGhg/yzzx +/LYA3FVq3LIc9KLply3D9VJ1/PyTpkSd2ceGHFPG6mSEYkc3BKC8sMpGrfCdRdKVyLi jfcjfPweoM9ibTQAxg5HqrqKiII+zXdnxgDl+cQweRiTIYI3XxIWy2GKgYd7hkBAtpnL j+cYK3+Ge3AWDzBl6EmmnQVfe3o4BVe1GSMMglcc/YGd3rdml4q/8GV5WwC/Us/VoksH c0XwXNcT/nQmCMRtB6cA4BJIbCSadQ5PNVDZVRYRToj6CFimbbvhfjE8HALH8xCa1f0u 3ejQ== X-Gm-Message-State: ANoB5pkpzj0Y9eQ37WMjUHtfb+ZQN+nb2TcwNFJp+OA1mAxCz+K3OJEg 3gAuObBnT2mqKd/g3bdT20rn02aptsGxoQMxHEsc X-Received: by 2002:ab0:4986:0:b0:414:4bb5:3e54 with SMTP id e6-20020ab04986000000b004144bb53e54mr6742748uad.121.1669231174806; Wed, 23 Nov 2022 11:19:34 -0800 (PST) MIME-Version: 1.0 References: <56393e84-485b-42ba-5fce-d4a0d0017653@amd.com> In-Reply-To: <56393e84-485b-42ba-5fce-d4a0d0017653@amd.com> From: John Stultz Date: Wed, 23 Nov 2022 11:19:24 -0800 Message-ID: Subject: Re: [PATCH v4] dma-buf: fix racing conflict of dma_heap_add() To: =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: Dawei Li , sumit.semwal@linaro.org, benjamin.gaignard@collabora.com, labbott@redhat.com, Brian.Starkey@arm.com, afd@ti.com, sspatil@android.com, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-17.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 21, 2022 at 10:24 AM Christian K=C3=B6nig wrote: > > Hi Dawei, > > from the technical description, coding style etc.. it looks clean to me, > but I'm the completely wrong person to ask for a background check. > > I have a high level understanding of how dma-heaps work, but not a > single line of this code is from me. > > Feel free to add my Acked-by, but Laura, John and others do you have any > opinion? No objection from me. Thanks Dawei for submitting this improvement! Acked-by: John Stultz thanks -john