Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Keller, Jacob E" <jacob.e.keller@intel.com>
To:     Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] net: loopback: use NET_NAME_PREDICTABLE for
 name_assign_type
Thread-Topic: [PATCH] net: loopback: use NET_NAME_PREDICTABLE for
 name_assign_type
Thread-Index: AQHY/0aKnTM/S23KHU2uX1j8XfZvJ65M8anQ
Date:   Wed, 23 Nov 2022 20:16:32 +0000
Message-ID: <CO1PR11MB5089116CBF3DC327E6F4C4CBD60C9@CO1PR11MB5089.namprd11.prod.outlook.com>
References: <20221123141829.1825170-1-linux@rasmusvillemoes.dk>
In-Reply-To: <20221123141829.1825170-1-linux@rasmusvillemoes.dk>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BF3D9pcqGSK4rjvFRRQQ4VGcxpwUgI/NNgRYjYV0tQtHH/TCfOdb++dyHtge?=
 =?us-ascii?Q?MlR9z1kJyAJ1AFo5pcOHjDckA69rszsxHKA9kw5ltTPm84HDWPneT7EVzb9r?=
 =?us-ascii?Q?YmEjaQ0UbAgyxVfUMLDjjDkE0WvduH7tCdMJCo27Sqzeg4MRQBB8S3z0CdQ3?=
 =?us-ascii?Q?IeRN35x/lA5I+LdlViROKUGaQUCiFty0cFlUK3PheY2BPP7pKODSbbiTROx1?=
 =?us-ascii?Q?kSFe0gNPrdX4DxDKMJBLdbz0lTned+T9MqfSR46gI6r8FS3/wiAHWpmDuPcs?=
 =?us-ascii?Q?DUMhd0gvfd2QCWP14utJv8sr9Rerk6TTIXEEiTameSO53hLZYBK7vUOgWZ1e?=
 =?us-ascii?Q?KPTek8vDoEM5+28JGiUBTRh2kfb/dd7umRR36ZeYTweO4SECBhXq0ByWXbSs?=
 =?us-ascii?Q?EW2Ctwc91JKLwP8Nrbsi4COdObV50Yn/vsZ/hu5NT8ovRqzpV8g3JI/ZnN9R?=
 =?us-ascii?Q?ZSqOl3g/wqfLqCVvdpcIMFRuhSoNustlMdxvinI2pLgQX1AfKdP/N1PtWaOl?=
 =?us-ascii?Q?5WPh+vIpad9YmLOUZCidb7cKPJx4YtiXA09f6Tk1UybXmiAZgLK/3rl0qPGA?=
 =?us-ascii?Q?fXScaPw2Uy34le8ubVPSgcFfOS6gNqY/4drCpUubidAMBEtq3n9zqq509iod?=
 =?us-ascii?Q?bF2SAMwM1AmmOI3JoK3S5L3+KZNiNbuM2PPjv4KXz028TlNdeyg7hoDHpQAp?=
 =?us-ascii?Q?QZnTNONseQQSWNQCWZwBhkWSTwu71N6HLG+aUeoOa5P2h2OCdLZyt5ojLjut?=
 =?us-ascii?Q?DP2A1wlKlyHhqskwr7YKa0NChfzCH2f5fTRaxiuNWuXfI3Zm4z9K6gna4Cki?=
 =?us-ascii?Q?BM0VP3oJJTwoJxOcLGc8sQfFHxfewGaena0yksWNZvKc9a7/GGH+9cMs6i9+?=
 =?us-ascii?Q?FnGR/HhasqfZx8rbZ2t8ywIux+MwtKYNnuI6dvArk1XQ5O3fvtIIwDGtUMjq?=
 =?us-ascii?Q?pvYhmq629yr6Me/TIEbQbvET1RVa9PhPA+M2XLhZ6DAnj+2tfwO19sExgc5z?=
 =?us-ascii?Q?GOV856KgeppyruCt8f2BCKHaZD7l4jZhFHoZ8o4TbsEfy+3JVHYWs6XxuwEz?=
 =?us-ascii?Q?v3P7c6Otjb4hLPmi8+ITenSXYWA2QyUfielhhF+9Tb6yCU47iBmPymy0V5xp?=
 =?us-ascii?Q?c9TRaMjiVe3EIjEC9w2bBE5gClfJ2mNbK08oC5K07LbivKKPoZWGdTDhtzLD?=
 =?us-ascii?Q?7C/PoqI0JXC9XbHtUU2R+UwaHQFlI2iNKgKgUfT1yT8AR1cs7B5yQOHR8SkM?=
 =?us-ascii?Q?s6DqJNGhPlgaYPVtvop0Fe1aVFIQqBfZRhTLQEH8YO8qWoZmuyZDQQdeZXI8?=
 =?us-ascii?Q?+Jh2dbJZIaVbSv7yUGpa4pn1PBcymU36gFKdc6a1Rs6uzmv51gAszQeHNVN9?=
 =?us-ascii?Q?VxWpdeBVxg/ZB+SZd+tjQiD2ampeQob1j3L7bAD3+Vf+Ho1P0UGnTDWV9o1Z?=
 =?us-ascii?Q?w59hg9/y9Jc0AQo3+VjDFR3KD1/7zXvF0GpS9KVsdVZgQfa5nxCiESZt3uAR?=
 =?us-ascii?Q?y/j7HVBArd2pmP0PEvh06K4Og60HA4eXHLBqclzSF0BICohUe7OHsVXmrWuq?=
 =?us-ascii?Q?tnYBRcy5shnf1myk2ib7KxpuukJHX23YEivkxHdH?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e8be5e00-b3bc-4a15-a1b2-08dacd8f9ced
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Nov 2022 20:16:32.3026
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nyhZCsoujjbJA4DsFqKK2P33thvxiCUiJzNMYo21DD/gfx5ALDVAH2iISezJHmn5jRvVS4++b+DTIK6x7RtRTquDItBuBIUoRAuaFg2Gf2w=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7107
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> Sent: Wednesday, November 23, 2022 6:18 AM
> To: David S. Miller <davem@davemloft.net>; Eric Dumazet
> <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni
> <pabeni@redhat.com>
> Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>; netdev@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Subject: [PATCH] net: loopback: use NET_NAME_PREDICTABLE for
> name_assign_type
>=20
> When the name_assign_type attribute was introduced (commit
> 685343fc3ba6, "net: add name_assign_type netdev attribute"), the
> loopback device was explicitly mentioned as one which would make use
> of NET_NAME_PREDICTABLE:
>=20
>     The name_assign_type attribute gives hints where the interface name o=
f a
>     given net-device comes from. These values are currently defined:
> ...
>       NET_NAME_PREDICTABLE:
>         The ifname has been assigned by the kernel in a predictable way
>         that is guaranteed to avoid reuse and always be the same for a
>         given device. Examples include statically created devices like
>         the loopback device [...]
>=20

Heh, so the doc says loopback is an example of this but we weren't using it=
 for that :D

> Switch to that so that reading /sys/class/net/lo/name_assign_type
> produces something sensible instead of returning -EINVAL.
>=20

This seems reasonable to me.

> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
>=20
> This is mostly cosmetic, but ideally I'd like to get to a situation
> where I don't need to do
>=20
>   assign_type=3D$(cat /sys/class/net/$dev/name_assign_type 2> /dev/null |=
| echo
> 0)
>=20
> or otherwise special-case [ $dev =3D "lo" ].
>=20
> As always, there's a small chance that this could cause a regression,
> but it seems extremely unlikely that anybody relies on
> /sys/class/net/lo/name_assign_type being unreadable and thus
> effectively is known to be NET_NAME_UNKNOWN.
>=20

I don't think I would consider this a regression. Previously name_assign_ty=
pe was returning an error here, now it reports something useful. And we kno=
w the name is predictable because=20
it is the loopback device.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

>  drivers/net/loopback.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/loopback.c b/drivers/net/loopback.c
> index 14e8d04cb434..2e9742952c4e 100644
> --- a/drivers/net/loopback.c
> +++ b/drivers/net/loopback.c
> @@ -211,7 +211,7 @@ static __net_init int loopback_net_init(struct net *n=
et)
>  	int err;
>=20
>  	err =3D -ENOMEM;
> -	dev =3D alloc_netdev(0, "lo", NET_NAME_UNKNOWN, loopback_setup);
> +	dev =3D alloc_netdev(0, "lo", NET_NAME_PREDICTABLE, loopback_setup);
>  	if (!dev)
>  		goto out;
>=20
> --
> 2.37.2