Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221116064631.16224-1-tegongkang@gmail.com> <CAEf4BzbqKRTzTdhD1Vt-j8NXaqnyqXCRjNgMe9_h56rbt4a9YA@mail.gmail.com>
 <CA+uqrQD58fJj_h1D6kEQKYPF8mRizgf0R7KTfa5YWNTLcu9xqw@mail.gmail.com>
In-Reply-To: <CA+uqrQD58fJj_h1D6kEQKYPF8mRizgf0R7KTfa5YWNTLcu9xqw@mail.gmail.com>
From:   Andrii Nakryiko <andrii.nakryiko@gmail.com>
Date:   Wed, 23 Nov 2022 13:38:07 -0800
Message-ID: <CAEf4BzbpkhTGF8dz4kUO-y9=1BbL_=PPbEX-qVEzw5NWn_prRg@mail.gmail.com>
Subject: Re: [PATCH] samples, bpf: Add duration option D for sampleip
To:     Kang Minchul <tegongkang@gmail.com>
Cc:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>, bpf@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sat, Nov 19, 2022 at 8:06 AM Kang Minchul <tegongkang@gmail.com> wrote:
>
> Thanks for your reply.
>
> 2022=EB=85=84 11=EC=9B=94 18=EC=9D=BC (=EA=B8=88) =EC=98=A4=EC=A0=84 8:26=
, Andrii Nakryiko <andrii.nakryiko@gmail.com>=EB=8B=98=EC=9D=B4 =EC=9E=91=
=EC=84=B1:
> >
> > On Tue, Nov 15, 2022 at 10:46 PM Kang Minchul <tegongkang@gmail.com> wr=
ote:
> > >
> > > Although sampleip program can handle three options,
> > > (-F for frequency, duration, and -h for help)
> > > currently there is no independent option for duration.
> >
> > Because it's positional argument, which is very clearly documented by
> > usage(). What's wrong with that and why do you want to change this?
> Yes, but I'm not sure why only 'duration' should be a positional argument=
.
>
> I don't think it is 'wrong', but I think it's better to treat
> 'duration' just as same as 'frequency' because
>  frequency and duration are two independent things in this case.
> (duration is not dependent on frequency)
>
> So I thought making an option for duration like below
>
> $ sudo ./samples/bpf/sampleip -F <Frequecny> -D <Duration>
>
> is better than below.
>
> $ sudo ./samples/bpf/sampleip -F <Frequecny> <Duration>
>
> I am not insisting strongly on this, so if I have misunderstood something=
,
> I'll respect the existing way.
>

I think it's just a common convention (e.g., iostat has the similar
approach). Let's keep it as is.


> Regards,
>
> Kang Minchul
> > >
> > > This patch adds option -D for duration like below:
> > >
> > > $ sudo ./samples/bpf/sampleip -h
> > > USAGE: sampleip [-F freq] [-D duration]
> > >        -F freq       # sample frequency (Hertz), default 99
> > >        -D duration   # sampling duration (seconds), default 5
> > >
> > > $ sudo ./samples/bpf/sampleip -F 120
> > > Sampling at 120 Hertz for 5 seconds. Ctrl-C also ends.
> > > ADDR                KSYM                          COUNT
> > > ...
> > >
> > > $ sudo ./samples/bpf/sampleip -D 7
> > > Sampling at 99 Hertz for 7 seconds. Ctrl-C also ends.
> > > ADDR                KSYM                          COUNT
> > > ...
> > >
> > > $ sudo ./samples/bpf/sampleip -F 120 -D 7
> > > Sampling at 120 Hertz for 7 seconds. Ctrl-C also ends.
> > > ADDR                KSYM                          COUNT
> > > ...
> > >
> > > Signed-off-by: Kang Minchul <tegongkang@gmail.com>
> > > ---
> > >  samples/bpf/sampleip_user.c | 13 +++++++------
> > >  1 file changed, 7 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/samples/bpf/sampleip_user.c b/samples/bpf/sampleip_user.=
c
> > > index 921c505bb567..ce6aadd496e1 100644
> > > --- a/samples/bpf/sampleip_user.c
> > > +++ b/samples/bpf/sampleip_user.c
> > > @@ -28,9 +28,9 @@ static int nr_cpus;
> > >
> > >  static void usage(void)
> > >  {
> > > -       printf("USAGE: sampleip [-F freq] [duration]\n");
> > > -       printf("       -F freq    # sample frequency (Hertz), default=
 99\n");
> > > -       printf("       duration   # sampling duration (seconds), defa=
ult 5\n");
> > > +       printf("USAGE: sampleip [-F freq] [-D duration]\n");
> > > +       printf("       -F freq       # sample frequency (Hertz), defa=
ult 99\n");
> > > +       printf("       -D duration   # sampling duration (seconds), d=
efault 5\n");
> > >  }
> > >
> > >  static int sampling_start(int freq, struct bpf_program *prog,
> > > @@ -145,19 +145,20 @@ int main(int argc, char **argv)
> > >         char filename[256];
> > >
> > >         /* process arguments */
> > > -       while ((opt =3D getopt(argc, argv, "F:h")) !=3D -1) {
> > > +       while ((opt =3D getopt(argc, argv, "F:D:h")) !=3D -1) {
> > >                 switch (opt) {
> > >                 case 'F':
> > >                         freq =3D atoi(optarg);
> > >                         break;
> > > +               case 'D':
> > > +                       secs =3D atoi(optarg);
> > > +                       break;
> > >                 case 'h':
> > >                 default:
> > >                         usage();
> > >                         return 0;
> > >                 }
> > >         }
> > > -       if (argc - optind =3D=3D 1)
> > > -               secs =3D atoi(argv[optind]);
> > >         if (freq =3D=3D 0 || secs =3D=3D 0) {
> > >                 usage();
> > >                 return 1;
> > > --
> > > 2.34.1
> > >