Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp8016907rwb; Wed, 23 Nov 2022 14:12:30 -0800 (PST) X-Google-Smtp-Source: AA0mqf6ckN0nU7hLehE9UdTARs+nMRVMDQIbx6+/XAHFXLaUdequyXttA9mFfeYzMi0i7Em+dP1s X-Received: by 2002:a17:90a:d3ca:b0:218:95ae:a4b5 with SMTP id d10-20020a17090ad3ca00b0021895aea4b5mr23687159pjw.126.1669241550514; Wed, 23 Nov 2022 14:12:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669241550; cv=none; d=google.com; s=arc-20160816; b=HkGoqsV+6wGF7cHHX3O9LY5yMc3MYgOVKA3Vi3QPw/0joGER+JOLQL+voDW7B2W8yP FaeJNpL9E5lisxOiyKx3perKa0LRDUwC/gFS8WYlmC0c57W2N1PmVBzLjyd5jI09zaDT NNVsnzmiZ7iA2eAle7egkwWsDWKREO/3IE+EgzCGVoRm6ci91/whYJiezPVsi6GSzzhx J+sw+t14pZgG7DOLipo6BW05mKdQdD3OsvgJqEftt+JW6CRYA2RNfTlwpGiZgr7VMIAV Q7JxBfv17OhkVjzTjjxg0VMydCXhf0hftxH6oiDFLTMO7pVxaNPgBLEGTn3rQyPFKWDE 1huQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=VHgVq5sX90/a/BhOqlHy581ALJwbQnSRnRpBrgLVdZ4=; b=ucFA3CfO1GnqGvbGiFAZb6Ly4PiJqyMHte+lgpN8gEDWwjFK0eTxSgIfk74D+4IZmG SpQ9TXI+mcfydZTRWrXlZc6A9+M66wx2hxeykEXUWfU9hCSo2/usOFRH4zzr06m+yNvP L/dzCYXy3WJX6wbTa5eICfVFYDgVEBjtD+A+H/5dZSKT7ffQ2lhl+QEan03wn+rTSKJo wh3ZSOPW+UPrlkUjZlvKCLepwtKnmUije2MEKXHlezEps5UwoY4BHbwnEKLO62ZgvvM9 /NuB3vPcG3rTPTIH4D3hL3uzLjiVYO6/J92x+KEGqJGugIFiTmloIgH4qopROzqAjUNr ZMFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=fELMiNAA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b9-20020a63d809000000b00476fddee338si15424151pgh.436.2022.11.23.14.12.14; Wed, 23 Nov 2022 14:12:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=fELMiNAA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237809AbiKWVWK (ORCPT + 88 others); Wed, 23 Nov 2022 16:22:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237811AbiKWVWI (ORCPT ); Wed, 23 Nov 2022 16:22:08 -0500 Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DAA5F60695 for ; Wed, 23 Nov 2022 13:22:06 -0800 (PST) Received: by mail-qk1-x733.google.com with SMTP id p18so13372140qkg.2 for ; Wed, 23 Nov 2022 13:22:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VHgVq5sX90/a/BhOqlHy581ALJwbQnSRnRpBrgLVdZ4=; b=fELMiNAAnzjxMhrhiZt4CATnthWy6giZnkz2zXGp5/6n8EoC1LuU8oQfUfEcVQoLA/ QichA/k207xrB80yyoNaf6+Tc6xJWRMTitzk6yAa5opT9pLOQT8wvAuJEAXSJePCzD1w P1cHz58W5dAAqh7AjcFl5B+evStoCtfUo/QXjnjllQ2Q64hRJfOI0JNS7wJdfKKTg9Xw pIr4EV4lXRRTewtoWKmDfsV/KVTYBib80VzDNbshHWyjyAUJnzLjamQI1lZwjr3d5Oo3 LEr00TLTaUa5wfDOmxqWAXothKMITL8f1kDbUtzGHBJDRgCkI2aXdf/FUy+cJ5cKtYnu K3mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VHgVq5sX90/a/BhOqlHy581ALJwbQnSRnRpBrgLVdZ4=; b=67QJiHKVwrgd0uWxgLylxzRPPd+9mBlkjnjSfeRrQa3D3xHqnYLOt5USN9tcFShiV/ H1auOettVvQ5HxZYYK2mSCfR9upFy8Q7aQCtUQkHjD4yvz757xQnJ/94ghOWTxpa3Zm0 96sf/fBgowqKU5KsASdQ9HGepReJXfoAyzsP8NRRG+nlW599o5jHL0kN1meI15VBhAPL EpmlVreco4CHDTCFAUL5FGHYRvQ/BVDYRH6l81CubRWm3XDaMfoeY4Ankd0UAFE56mu8 swbiRLJj3xK/dKLRv5nXtPin3l05/la9Ro8luGn1x1MZKsZrKdfnjSkKqIKAiAph022a 0avA== X-Gm-Message-State: ANoB5pn2ZxiQKY5C6dJWuh4nZrUaX2IC3+tZI2k3rjP5NVPJjPOFvY6K EvnaI4QUtlqZvj4owqNDVxpOcQ== X-Received: by 2002:a05:620a:10b4:b0:6fb:f17e:c8f8 with SMTP id h20-20020a05620a10b400b006fbf17ec8f8mr16670583qkk.404.1669238526028; Wed, 23 Nov 2022 13:22:06 -0800 (PST) Received: from localhost ([2620:10d:c091:480::1:bc4]) by smtp.gmail.com with ESMTPSA id c12-20020ac8054c000000b003995f6513b9sm10148797qth.95.2022.11.23.13.22.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Nov 2022 13:22:05 -0800 (PST) Date: Wed, 23 Nov 2022 16:22:31 -0500 From: Johannes Weiner To: Yu Zhao Cc: Ivan Babrou , Linux MM , Linux Kernel Network Developers , linux-kernel , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Eric Dumazet , "David S. Miller" , Hideaki YOSHIFUJI , David Ahern , Jakub Kicinski , Paolo Abeni , cgroups@vger.kernel.org, kernel-team Subject: Re: Low TCP throughput due to vmpressure with swap enabled Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 22, 2022 at 05:44:44PM -0700, Yu Zhao wrote: > Hi Johannes, > > Do you think it makes sense to have the below for both the baseline and > MGLRU or it's some behavior change that the baseline doesn't want to > risk? It looks good to me. Besides the new FMODE_NOREUSE, it's also a nice cleanup on the rmap side! It would just be good to keep the comment from folio_referenced_one() and move it to the vma_has_locality() check in invalid_folio_referenced_vma(). Otherwise, Acked-by: Johannes Weiner