Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <71dfb90f-e58c-2f15-7283-14da1d76d5ed@intel.com>
Date:   Wed, 23 Nov 2022 14:27:51 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.5.0
Subject: Re: [PATCH v8 08/13] x86/resctrl: Add sysfs interface to read
 mbm_total_bytes_config
Content-Language: en-US
To:     <babu.moger@amd.com>, <corbet@lwn.net>, <tglx@linutronix.de>,
        <mingo@redhat.com>, <bp@alien8.de>
CC:     <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
        <akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
        <rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
        <songmuchun@bytedance.com>, <peterz@infradead.org>,
        <jpoimboe@kernel.org>, <pbonzini@redhat.com>,
        <chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
        <jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
        <sandipan.das@amd.com>, <tony.luck@intel.com>,
        <james.morse@arm.com>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bagasdotme@gmail.com>,
        <eranian@google.com>
References: <166759188265.3281208.11769277079826754455.stgit@bmoger-ubuntu>
 <166759205510.3281208.11437041392524040365.stgit@bmoger-ubuntu>
 <46d00211-e6e2-a0d9-22ca-ee0d3ca15468@intel.com>
 <7c1fd8c3-771e-fd4c-368a-83b30572980d@amd.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <7c1fd8c3-771e-fd4c-368a-83b30572980d@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OHdub2RJcGgyTzUxbFhkL3puRXlzL3VNRTZUZEZtK0cxaU5IS1hlYXhTLzN3?=
 =?utf-8?B?c2xRbEJoaHViZTI2NmpCNllOZFpKWXdQNGk5YUUwRmFSSzJZSElFNEtFemxF?=
 =?utf-8?B?OGZEaTdROFA2YWZRWmVSeGVYWHgvclc3RWJ3ZExqcG5kamhqdUZFa0JTZlBx?=
 =?utf-8?B?MGQ2NExWQXNIcm01Y0JzMDZDQjJCWEFodVZqOTFBOHI5SWNTMCtIOFA5ZWc2?=
 =?utf-8?B?UXA2ZU84NytmNktVUVltMWc4ZGFQNUdHYzN6QW5ZOUc4aFJ2MUllQ09BVmc1?=
 =?utf-8?B?c3J2WG5jNVJiMDlmSWtKSTE2c2lKdHgvVk1KWjJwQ2RieWFTTzRmK1IzZThn?=
 =?utf-8?B?ckVvOEFTay9FM0doeTBKVlFScGJRMDdNQVRQKy9yZG4zR0xNTUtKbW5OTVdG?=
 =?utf-8?B?cnZwNXFwY0pPRnlZVm5raHRBalpWdHhsZzBRL01LLzA1djBFMnlWYU5GTVJQ?=
 =?utf-8?B?N3lHZktHQmtLamltRnNYZmppZHdyZDlnSm9uam1YbWJlYjg3QzF3QVg1V2pP?=
 =?utf-8?B?NVhjbk9iaTJXVldHaUdCS1VJbU9QK2xZMnQ3WFUwbWdZMnYwcEVPR3kzN2xQ?=
 =?utf-8?B?TUM5cENSMzlRcEsrSnNZV1VPVTZ2R09hZWpTbHZKWDgySGxOWjk2dTJEUm43?=
 =?utf-8?B?eDJNU2lrc3l0YlV0T2lPd1N0TGVrZCtYRWY1WkppUExNekNmSFBpcWVWVElx?=
 =?utf-8?B?a0t4UndNeFBuRUxCY0kzZXlXS1haTnpCZWdyZzFReXk5OHFHbGR2Y1grYktV?=
 =?utf-8?B?R01RaHRyRVhHTnVac2RKQUttVWRnQUc5UEp6VVk3YnhTVkpyc2lmQUxpSFNN?=
 =?utf-8?B?V0hxSlFUUEdXNVIyTEVXWDNtZ3RuVVR5S0RSV3gxWmx4dHpHVkkzcGRPakFR?=
 =?utf-8?B?TU1tbXlpTGU5dGZWRTRBWjh4R0pKajk0Ykdyc0Qxb1FlSlhlL3l3N0ZpdWFO?=
 =?utf-8?B?RW82QmszWXdHTWVsUUtwbWlKZDM1Wi9lVDEwUjFmcG5PNmptMTNCQTdHZkhs?=
 =?utf-8?B?TXd4NEFFa0JtQVlrYW9IYkVmZmFkVjFKbnhreG1rUHlkbTdaWUQrc1Q0WU5K?=
 =?utf-8?B?V3lrbW1KZ2hrenNOVjg0MUNhOVhOYjh4VEJCMjlia1cwM2tHODk4R1Zmb0dz?=
 =?utf-8?B?bEw2ZXFvVTYxTU9ZS1p2VE10dGRPMm5IdjR4L0hEZ1pLTVRHMUNoVTVRTHBE?=
 =?utf-8?B?bVUxMlU2V1VDbTk2TmJ1eVBDMk55RURsdDllSlN3V2gwSWxlNUtmVklWalFD?=
 =?utf-8?B?d1JyNyt4b1BqYlFyOU1GT25yQkdVdk1FY2JaUU9HSG1reGN0VFkwcU9DeTMz?=
 =?utf-8?B?UjVnN2ppNzJSaDRucE9xdC9VME9hTDd1WkpSWDNESTBoOHJ6SDJxK1Y4a0VY?=
 =?utf-8?B?VTR2emNrb3BUK29VcDhoQjBzZ01kWVMxZGNQTE8zT25XQ0drZ0lRTTcvUFEr?=
 =?utf-8?B?UjFEZDJuTnNrRmVzK1JQR2IwWU9BVWlkamc2dEIrUmp1RUdiZVlKcHV0LzZ2?=
 =?utf-8?B?Z0ZYMTZOekdJbUVwUUowRVpMT01PWitBeHQzeG1JekFuZmh1a2lubUpWV2Nl?=
 =?utf-8?B?UkFvbDBjaVBHUE1LYk9xcng1d0M2c1BuLzJrbk9GY3VXRCtXWmpkeXhzazF2?=
 =?utf-8?B?SXhlSnZreThhdjJTVzg0YlRXTUJWcnc2TENSYy9VeXRTWjRUd1pDNFhiZjFx?=
 =?utf-8?B?RTYxVDZhNW9sazZ3SHBRb1VaeXZSQk91S29Ld1Z5eEt1Wk5vNWhmbVRRcXVH?=
 =?utf-8?B?Ym1iRS9pVlhTcERZWXlJdTdlY3hzZUY5SDdZNDNyNnJZMXRnZVBaVFRDcnB2?=
 =?utf-8?B?SmhiOGZ2MlA0aDBFTkIvaFMrOEtBSlRHVS9FRW5xWGNtL0VnR1U5Tk90OU1D?=
 =?utf-8?B?TDA3UTczV244cXJjM1gvTzNseVEyNml3YzJZZGZRRDlieHh0SXlnRWF0UVlr?=
 =?utf-8?B?YVd3QVBUL0twY0lJTm5TZzJ5TkFPSVdWTlh3Z0Y3TzlsVS9QT0tzWlRaSzIz?=
 =?utf-8?B?QnNkYUowR1JCd3BqUURIZFVrd2xRWERBNUxLYTRqT2ZaWEk2SFpSZklJU2tw?=
 =?utf-8?B?UHN1QTd3UmozWEJ2ODRtSVBBb3lta3h3bVAzdXArZDdKY2JOOXp2TEZucEx1?=
 =?utf-8?B?WFY1Rk1jaE0xVW1QV2VHRUhQdTZVMjFnYU5HRHBoQm5iMHJJMC9xc2RWWWVO?=
 =?utf-8?B?QWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a447ad6a-d8c0-41f7-93b5-08dacda1f734
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 22:27:54.9693
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Hcwl3k4ZOx4VTebQ/Rvar5HHShnj//11McBTl2VLaFZIqrCW2PTQSOCZutRU2F2kG/fgs3GihohFviFtug6egy9hjqZK/uneciNTKXX/ZOk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4768
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Babu,

On 11/23/2022 10:35 AM, Moger, Babu wrote:
> On 11/22/22 18:19, Reinette Chatre wrote:
>> On 11/4/2022 1:00 PM, Babu Moger wrote:

...

>>> @@ -1521,6 +1593,12 @@ static struct rftype res_common_files[] = {
>>>  		.seq_show	= max_threshold_occ_show,
>>>  		.fflags		= RF_MON_INFO | RFTYPE_RES_CACHE,
>>>  	},
>>> +	{
>>> +		.name		= "mbm_total_bytes_config",
>>> +		.mode		= 0444,
>>> +		.kf_ops		= &rdtgroup_kf_single_ops,
>>> +		.seq_show	= mbm_total_bytes_config_show,
>>> +	},
>>>  	{
>>>  		.name		= "cpus",
>>>  		.mode		= 0644,
>>> @@ -1627,6 +1705,15 @@ void __init thread_throttle_mode_init(void)
>>>  	rft->fflags = RF_CTRL_INFO | RFTYPE_RES_MB;
>>>  }
>>>  
>>> +void mbm_config_rftype_init(void)
>> Does this need __init?
> 
> Not. Required. Will remove it.
> 

Your response is not clear to me. I am not asking for any removal. My
question is whether the function needs the __init attribute. That is,
should this be:

void __init mbm_config_rftype_init(void)

Reinette