Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 24 Nov 2022 00:36:26 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Colin Foster <colin.foster@in-advantage.com>
Cc:     Alexander Lobakin <alobakin@mailbox.org>,
        Alexander Lobakin <alobakin@pm.me>,
        linux-kbuild@vger.kernel.org,
        Masahiro Yamada <masahiroy@kernel.org>,
        Nicolas Schier <nicolas@fjasle.eu>,
        Jens Axboe <axboe@kernel.dk>,
        Boris Brezillon <bbrezillon@kernel.org>,
        Borislav Petkov <bp@alien8.de>,
        Tony Luck <tony.luck@intel.com>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Derek Chickles <dchickles@marvell.com>,
        Ioana Ciornei <ioana.ciornei@nxp.com>,
        Salil Mehta <salil.mehta@huawei.com>,
        Sunil Goutham <sgoutham@marvell.com>,
        Daniel Scally <djrscally@gmail.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Mark Brown <broonie@kernel.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        NXP Linux Team <linux-imx@nxp.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 14/18] dsa: ocelot: fix mixed module-builtin object
Message-ID: <20221123223626.xpztd3jlnfv7isq4@skbuf>
References: <20221119225650.1044591-1-alobakin@pm.me>
 <20221119225650.1044591-15-alobakin@pm.me>
 <20221121175504.qwuoyditr4xl6oew@skbuf>
 <Y3u/qwvLED4nE/jR@colin-ia-desktop>
 <20221123214746.62207-1-alobakin@mailbox.org>
 <Y36cGl7wLM3aGeI2@colin-ia-desktop>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y36cGl7wLM3aGeI2@colin-ia-desktop>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bHztFamZv9S1DTLdd50j4798Fx++x8CIkvJtNJ0Mk5T0G6p44P0VqAjuc9/R?=
 =?us-ascii?Q?HrD1LTtNtPt2H550Sg16XPOpl4iEhlmTlWLh/0J2zZjm6n5mmFdjxd27QLuU?=
 =?us-ascii?Q?ESm/OTvvkG9TLAEOzrwcH7mfjXsG4MhV1tqM1XNwFixzoZCnjmbklSnU2mwj?=
 =?us-ascii?Q?98etUTy4bILY68ra3fHL77vQiGcmrHkeIrT0bce6bxNNbbNxF8kx4qMVnvwF?=
 =?us-ascii?Q?mvvr/nXG2wzawVTfgkpxUWbEIOttM0U3b0adzr4FahPg+iYyEujk/TDu280H?=
 =?us-ascii?Q?0Y2iIRh4ogcoDVh4S+scZ5QJzZ00nt8zzY7P5i8kbcfre/rUAtkvWJ66JCno?=
 =?us-ascii?Q?OlC6EPRNX4slqgASNSnkUJhAuFNVOHjIpYsRSadqky85aV5Yk0AlXrKYavNv?=
 =?us-ascii?Q?7gx0pARMczB3YapyiK7F0mZy8gq22hctP0NutKEfH5IQr9IP0a5wxwqYnhO7?=
 =?us-ascii?Q?y7mxeCbIkvitcP/VF941VKsvjBOfYEZNcQiFN/MCFe6V0RYQH/PgRnD31knZ?=
 =?us-ascii?Q?9ZhkVCKziUvcBxp/HfJDwGFaFab3q7aDpzx+PIUe3Q3mKmk6GKEcJuvhZnUX?=
 =?us-ascii?Q?S6Yz0kQ5aOt3wPdMbWXgUSxZEzYU0GqUC9JYBjOn1SbLbsNPs5et5x8U+r5c?=
 =?us-ascii?Q?z343C2d8MnEgb7xoTv1k4HFz0RdM0stRLJ0aHWuJ3zEwOj4pjOuMOJ7CdwZl?=
 =?us-ascii?Q?y9mXgab16J6T7R94GZKRZzcUBz7vrTmNoowZr/4L+NjmLbe21zBsIJSH31As?=
 =?us-ascii?Q?jVDB5nyf5cRbhLMhD+jvNUUDesYbLwWOruwksls06CLY4lh/VW+2d8ahLu1e?=
 =?us-ascii?Q?6j9AXF9iG4+iA/o7fQ3D6fvCE4KmEQ0IBKu/f0Um+pYdXrGx1IogIAr7FD6r?=
 =?us-ascii?Q?gzmbGStvXkbAdcaYZEwNSJ6Nig+YIugIh9QE4PWdvlPUN+P+CJBRj2K8/mVH?=
 =?us-ascii?Q?M5iQFecChshXod9/I+WiH9T2OKMEv33Kjpv0K07q0BWrpPEcgvREp/H9unTR?=
 =?us-ascii?Q?+dGLjqGvsMJ6u0OeCygyWILKLMhb9Od6EQ/Wn+LP1vNEh3FXm4F07RPjVY4N?=
 =?us-ascii?Q?hhi6wOXjupeeGmLnxrArCJYKVgu+S8eIgUX7JKJHdQpiA+JU3hX6wzMr+IVS?=
 =?us-ascii?Q?ZjsW4lIyWlc1eOBgOmJ7BaedlKNqLHDwKg4+pImskFIZTK6CRFKaqXv9sxyz?=
 =?us-ascii?Q?IV4ElvfBcucFxq0cPO4eBaWYSxqNghoU6nvPgWbTylR+BJfC6ok+cVWjdBjm?=
 =?us-ascii?Q?1YqaMuBay2wOfHNkwaIuq1XefUfnszXYOZzSKXCc9z/LUwb0Cf9Fv3nxchL+?=
 =?us-ascii?Q?UYjMYUB67pshdk0+ZCZb0PjuaLcTlt+Nc+EQmhPBYGOa1UiqPUp6LPV/1GXj?=
 =?us-ascii?Q?cRqHvONa/nuxXd5gQgetrwNEQZycC0gp3ppoxU+ZGLRvIaz1RLnl2EIzcz/k?=
 =?us-ascii?Q?hHuJI4FHeLTtaR/R2SG/+a5h+M3oqolSbnNTL2c2BNTmZxTTFL2U52TKCYEA?=
 =?us-ascii?Q?hUMQ6n69y+01R48FN1qEzFU02vkkQEGu3VMFA9fegUod0oGRK3byBAzGcfMb?=
 =?us-ascii?Q?b9L++92F0tawxzTmumSlWq0cS+qy8CTp/WPE+dMVAN6h0j+JPkBidEvOqIsj?=
 =?us-ascii?Q?iw=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 880cff13-c1d5-4f98-2f0c-08dacda32ad2
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 22:36:30.9377
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8Kt3b73nlQdW0O54/DhlAiwIuOLQJczTVGdgXxPc71VqXr7xoy8ABW6i4hlHjTnOkW/7tO7fo1vcdMBS5D+l7Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7281
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Nov 23, 2022 at 02:18:02PM -0800, Colin Foster wrote:
> > The thing confused me is that one chip is named Felix and the other
> > one is Seville, but the shared code is named felix as well. So at
> > first I thought maybe Felix is a family of chips and Seville is a
> > chip from that family, dunno :D
> 
> Not important, but in case anyone is curious:
> 
> Ocelot is a family of switches. Linux support exists for the internal
> MIPS on some of those devices. My understanding is the switching
> hardware is licensed out to other chips that can be controlled
> externally (e.g. PCIe). Felix was the first chip to do so with full
> Linux support. When Seville came along, it utilized a lot of common
> code from Felix. Thus, Felix is a "chip" as well as a "library" -
> specifically the DSA implementation of Ocelot. At least in my mind.
> 
> (Note: I haven't verified this timeline back to the early days of
> Felix... I'm mostly speculating)

I'm not sure marketing would agree that Ocelot, Felix, Seville are part
of the same "family". They're all Vitesse switch designs which share the
same core architecture, even if some are sold by other companies.

The Ocelot switchdev driver came first to Linux. The Felix switch was
very similar, except it was DSA and not switchdev. So when it got added,
Ocelot became the name of a library for sharing code between a switchdev
front-end and a DSA front-end, as well as the name of a driver proper.

The Seville hardware is actually much older than both Ocelot and Felix.
It comes from the same family as Serval. It's integrated into old
Freescale PowerPC SoCs. It only got Linux support late in its life,
when it became super easy to do it, basically after Felix paved the way.
When that happened, Felix also got split up into a library (for the DSA
aspects of interfacing with the ocelot library) and a driver proper.

Colin is now working on a switch which marketing really would say that
it's part of the Ocelot family. Except it's DSA, so it has to use the
Felix library.

Anyway, TL;DR: name of common code is given by the first supported
hardware, it's quite a common pattern really.

What's more interesting to me is the strange humour of somebody at
Vitesse (now Microchip) who gave the feline code names for these
switches (Ocelot, Serval, Jaguar). Felix is none other than Felix the Cat.