Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 23 Nov 2022 23:41:46 +0100
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Vivek Yadav <vivek.2311@samsung.com>
Cc:     rcsekar@samsung.com, krzysztof.kozlowski+dt@linaro.org,
        wg@grandegger.com, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, pankaj.dubey@samsung.com,
        ravi.patel@samsung.com, alim.akhtar@samsung.com,
        linux-fsd@tesla.com, robh+dt@kernel.org, linux-can@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
        aswani.reddy@samsung.com, sriranjani.p@samsung.com
Subject: Re: [PATCH v3 1/2] can: m_can: Move mram init to mcan device setup
Message-ID: <20221123224146.iic52cuhhnwqk2te@pengutronix.de>
References: <20221122105455.39294-1-vivek.2311@samsung.com>
 <CGME20221122105022epcas5p3f5db1c5790b605bac8d319fe06ad915b@epcas5p3.samsung.com>
 <20221122105455.39294-2-vivek.2311@samsung.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="cil7nudg4royyvqc"
Content-Disposition: inline
In-Reply-To: <20221122105455.39294-2-vivek.2311@samsung.com>
Precedence: bulk


--cil7nudg4royyvqc
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 22.11.2022 16:24:54, Vivek Yadav wrote:
> When we try to access the mcan message ram addresses, hclk is
> gated by any other drivers or disabled, because of that probe gets
> failed.
>=20
> Move the mram init functionality to mcan device setup called by
> mcan class register from mcan probe function, by that time clocks
> are enabled.

Why not call the RAM init directly from m_can_chip_config()?

Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--cil7nudg4royyvqc
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmN+oagACgkQrX5LkNig
011CiQf/e32bdb0BoAliyr1ZRwrW/c5KZqmDEeb4gpGTrA+uk73UwZje2Z7ONoUG
i/N5b0FpZTka1LfBi+XANlo77wmwTrvRut5OdXSw++JobVghAqqJOOLGZLJ5k4xz
glFz35NhXTNlY6VMs5l8Mg0X/lBNcTQ0WkjUUZylqF63c8szMbZcIxG2avMB00dS
BPIsmfMwSjwQqle7i2VXnjH8cW7A2jrDytYx0Azai4a6NrZ8ZxK47aAiyuMfvUsA
t2kJZHqp1IfSnhZ99QHvAPMOsYVO26bqvN0EDdd0ZVo9kij/moh2aqOh3XwCoqQF
OA1iycEnvVQh1ytL69snZMIEm1GkEw==
=geD9
-----END PGP SIGNATURE-----

--cil7nudg4royyvqc--