Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221121082058.64578-1-zhengjun.xing@linux.intel.com>
 <CAP-5=fUQUe0UvLhaSBnm-dAPHc3_k8vZWNxhZajg8mg6R8og0g@mail.gmail.com>
 <Y34iAVLGAGhVH/ta@kernel.org> <Y34irx0jffj8NXRY@kernel.org>
In-Reply-To: <Y34irx0jffj8NXRY@kernel.org>
From:   Ian Rogers <irogers@google.com>
Date:   Wed, 23 Nov 2022 15:33:06 -0800
Message-ID: <CAP-5=fVKXRcswFAMkTTBHTnvnEErhr0HExJ-HFKLHgZO71cbTw@mail.gmail.com>
Subject: Re: [PATCH v2 1/5] perf vendor events intel: Add core event list for Alderlake-N
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     zhengjun.xing@linux.intel.com, peterz@infradead.org,
        mingo@redhat.com, alexander.shishkin@intel.com, jolsa@kernel.org,
        namhyung@kernel.org, linux-kernel@vger.kernel.org,
        linux-perf-users@vger.kernel.org, ak@linux.intel.com,
        kan.liang@linux.intel.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Nov 23, 2022 at 5:40 AM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> Em Wed, Nov 23, 2022 at 10:37:05AM -0300, Arnaldo Carvalho de Melo escrev=
eu:
> > Em Mon, Nov 21, 2022 at 01:17:12PM -0800, Ian Rogers escreveu:
> > > On Mon, Nov 21, 2022 at 12:19 AM <zhengjun.xing@linux.intel.com> wrot=
e:
> > > >
> > > > From: Zhengjun Xing <zhengjun.xing@linux.intel.com>
> > > >
> > > > Alderlake-N only has E-core, it has been moved to non-hybrid code p=
ath on
> > > > the kernel side. Add core event list for Alderlake-N, it is based o=
n the
> > > > ADL gracemont v1.16 JSON file.
> > > >
> > > > https://github.com/intel/perfmon/tree/main/ADL/events/
> > > >
> > > > Signed-off-by: Zhengjun Xing <zhengjun.xing@linux.intel.com>
> > > > Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
> > >
> > > Acked-by: Ian Rogers <irogers@google.com>
> >
> > Is this just for 1/5? Or can I stick it to the whole series?
>
> But, after applying 1/5 I get:
>
>   CC      /tmp/build/perf/util/data-convert-bt.o
>   CC      /tmp/build/perf/util/data-convert-json.o
> /tmp/build/perf/pmu-events/pmu-events.c:55354:39: error: =E2=80=98pme_ald=
erlaken=E2=80=99 defined but not used [-Werror=3Dunused-const-variable=3D]
> 55354 | static const struct compact_pmu_event pme_alderlaken[] =3D {
>       |                                       ^~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> make[3]: *** [/var/home/acme/git/perf/tools/build/Makefile.build:97: /tmp=
/build/perf/pmu-events/pmu-events.o] Error 1
> make[2]: *** [Makefile.perf:711: /tmp/build/perf/pmu-events/pmu-events-in=
.o] Error 2
> make[2]: *** Waiting for unfinished jobs....
>   CC      /tmp/build/perf/util/lzma.o
>   CC      /tmp/build/perf/util/zlib.o
>   CC      /tmp/build/perf/util/jitdump.o
>   CC      /tmp/build/perf/util/bpf-event.o
>   LD      /tmp/build/perf/util/perf-in.o
>   LD      /tmp/build/perf/perf-in.o
> make[1]: *** [Makefile.perf:240: sub-make] Error 2
> make: *** [Makefile:113: install-bin] Error 2
> make: Leaving directory '/var/home/acme/git/perf/tools/perf'
>
>  Performance counter stats for 'make -k BUILD_BPF_SKEL=3D1 CORESIGHT=3D1 =
O=3D/tmp/build/perf -C tools/perf install-bin':
>
>     26,049,918,108      cycles:u
>     47,580,273,158      instructions:u                   #    1.83  insn =
per cycle
>
>        4.655423698 seconds time elapsed
>
>        6.211852000 seconds user
>        5.060661000 seconds sys
>
>
> =E2=AC=A2[acme@toolbox perf]$
>
> Please fix it and send a v2.
>
> - Arnaldo

Thanks Arnaldo, my acked-by was for the whole series (missing cover
letter in v2). The mapfile.csv change was reordered in v2, I asked for
this. I think that change needs squashing into this one to avoid the
unused case.

Thanks,
Ian