Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Sriranjani P" <sriranjani.p@samsung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
        <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <lee@kernel.org>, <devicetree@vger.kernel.org>,
        <alim.akhtar@samsung.com>, <pankaj.dubey@samsung.com>,
        <ravi.patel@samsung.com>
Cc:     <linux-kernel@vger.kernel.org>
In-Reply-To: <03a26971-e54b-a8e7-c02f-ae5a8feba71a@linaro.org>
Subject: RE: [PATCH 2/2] arm64: dts: fsd: add sysreg device node
Date:   Wed, 23 Nov 2022 19:10:21 +0530
Message-ID: <001601d8ff41$231deaf0$6959c0d0$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQGtZdCQDJwhTh87CLfF3yzsQrDlqwDaao/AAgr8Mq4BlHJjcwI2urOOA12SKrWuU0JOYA==
Content-Language: en-in
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <20221121091118.48628-1-sriranjani.p@samsung.com>
        <CGME20221121090647epcas5p439dc84f0c4f435a703a1f8396a11202f@epcas5p4.samsung.com>
        <20221121091118.48628-3-sriranjani.p@samsung.com>
        <a98ac5d7-0c0e-110e-5405-83a09c77ceac@linaro.org>
        <000001d8ff32$c8b78e30$5a26aa90$@samsung.com>
        <03a26971-e54b-a8e7-c02f-ae5a8feba71a@linaro.org>
Precedence: bulk


> -----Original Message-----
> From: Krzysztof Kozlowski =5Bmailto:krzysztof.kozlowski=40linaro.org=5D
> Sent: 23 November 2022 18:43
> To: Sriranjani P <sriranjani.p=40samsung.com>; robh+dt=40kernel.org;
> krzysztof.kozlowski+dt=40linaro.org; lee=40kernel.org;
> devicetree=40vger.kernel.org; alim.akhtar=40samsung.com;
> pankaj.dubey=40samsung.com; ravi.patel=40samsung.com
> Cc: linux-kernel=40vger.kernel.org
> Subject: Re: =5BPATCH 2/2=5D arm64: dts: fsd: add sysreg device node
>=20
> On 23/11/2022 12:57, Sriranjani P wrote:
> >
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski =5Bmailto:krzysztof.kozlowski=40linaro.org=
=5D
> >> Sent: 21 November 2022 17:58
> >> To: Sriranjani P <sriranjani.p=40samsung.com>; robh+dt=40kernel.org;
> >> krzysztof.kozlowski+dt=40linaro.org; lee=40kernel.org;
> >> devicetree=40vger.kernel.org; alim.akhtar=40samsung.com;
> >> pankaj.dubey=40samsung.com; ravi.patel=40samsung.com
> >> Cc: linux-kernel=40vger.kernel.org
> >> Subject: Re: =5BPATCH 2/2=5D arm64: dts: fsd: add sysreg device node
> >>
> >> On 21/11/2022 10:11, Sriranjani P wrote:
> >>> Add SYSREG controller device node, which is available in PERIC,
> >>> FSYS0 and
> >>> FSYS1 block of FSD SoC.
> >>>
> >>> Signed-off-by: Alim Akhtar <alim.akhtar=40samsung.com>
> >>> Signed-off-by: Pankaj Dubey <pankaj.dubey=40samsung.com>
> >>> Signed-off-by: Sriranjani P <sriranjani.p=40samsung.com>
> >>> ---
> >>>  arch/arm64/boot/dts/tesla/fsd.dtsi =7C 15 +++++++++++++++
> >>>  1 file changed, 15 insertions(+)
> >>>
> >>> diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi
> >>> b/arch/arm64/boot/dts/tesla/fsd.dtsi
> >>> index f35bc5a288c2..db78816ba0bf 100644
> >>> --- a/arch/arm64/boot/dts/tesla/fsd.dtsi
> >>> +++ b/arch/arm64/boot/dts/tesla/fsd.dtsi
> >>> =40=40 -518,6 +518,21 =40=40
> >>>  				=22dout_cmu_fsys1_shared0div4=22;
> >>>  		=7D;
> >>>
> >>> +		sysreg_peric: syscon=4014030000 =7B
> >>
> >> Node name system-controller
> > =5BSriranjani P=5D Will fix it in the next version. We added =E2=80=9Cs=
yscon=E2=80=9D=20since=20I=0D=0A>=20referred=20other=20dtsi=20files=20in=20=
mainline=20for=20example=20exynosautov9.dtsi=20used=0D=0A>=20syscon=20as=20=
node=20name.=20If=20this=20is=20the=20name=20we=20should=20add=20then=20I=
=E2=80=99ll=20post=20few=0D=0A>=20more=20patches=20fixing=20this=20node=20n=
ame=20in=20other=20Exynos=20dtsi=20files.=0D=0A>=20=0D=0A>=20Use=20proper=
=20wrapping=20for=20mailing=20lists.=20It's=20difficult=20to=20read=20your=
=20emails.=0D=0A=0D=0ASorry=20for=20the=20confusion.=20I=20have=20fixed=20m=
y=20email=20client=20now.=0D=0A=0D=0A>=20=0D=0A>=20>>=20and=20either=20put=
=20it=20next=20to=20existing=20one=20or=20next=20to=20functional=20block=0D=
=0A>=20>>=20(peric=0D=0A>=20>>=20clocks?)=20ordered=20by=20unit=20address.=
=0D=0A>=20>=20=5BSriranjani=20P=5D=20We=20thought=20of=20it=20but=20as=20I=
=20saw=20current=20fsd.dtsi=20file=20and=20other=0D=0A>=20exynos=20file=20l=
ike=20exynosautov9.dtsi,=20in=20that=20nodes=20are=20not=20properly=20arran=
ged=20as=0D=0A>=20per=20unit=20address.=0D=0A>=20=0D=0A>=20I=20know,=20that=
's=20why=20I=20proposed=20to=20order=20by=20unit=20address=20within=20other=
=20syscons=0D=0A>=20or=20other=20functional=20blocks=20(e.g.=20peric-relate=
d).=0D=0A=0D=0AGot=20it.=20I'll=20move=20the=20sysreg=20nodes=20near=20to=
=20their=20functional=20blocks=20and=20order=20them=20by=20unit=20address.=
=0D=0A=0D=0A>=20=0D=0A>=20>=0D=0A>=20>=20So=20I=20can=20think=20of=20follow=
ing=20two=20approaches:=0D=0A>=20>=201:=20For=20the=20time=20being=20I=20wi=
ll=20put=20this=20sysreg=20node=20in=20between=0D=0A>=20>=20clock_peric=20n=
ode=20and=20clock_fysys0=20node=20and=20clock_fsys1=20node=20as=20per=0D=0A=
>=20>=20increasing=20unit=20address.=20I=20will=20clean=20up=20other=20exyn=
os=20and=20FSD=20DTSI=0D=0A>=20>=20files=20and=20post=20a=20new=20patch=0D=
=0A>=20=0D=0A>=20Not=20sure=20what=20cleaning=20you=20have=20in=20mind.=0D=
=0A>=20=0D=0A>=20>=202:=20First=20I=20will=20clean=20up=20exynos=20and=20FS=
D=20DTSI=20files=20and=20then=20post=20this=20sysreg=0D=0A>=20patch=20keepi=
ng=20it=20at=20appropriate=20place.=0D=0A>=20=0D=0A>=20What=20cleaning?=0D=
=0A=0D=0ABy=20cleaning=20I=20meant=20fixing=20these=20dtsi=20files=20to=20h=
ave=20the=20device=20nodes=20in=20the=20order=20of=20ascending=20unit=20add=
ress.=0D=0A=0D=0A>=20=0D=0A>=20Best=20regards,=0D=0A>=20Krzysztof=0D=0A=0D=
=0AThank=20you.=0D=0A=0D=0A=0D=0A