Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Nick Terrell <terrelln@meta.com>
To:     Sheng Yong <shengyong@oppo.com>
CC:     "jaegeuk@kernel.org" <jaegeuk@kernel.org>,
        "chao@kernel.org" <chao@kernel.org>,
        "linux-f2fs-devel@lists.sourceforge.net" 
        <linux-f2fs-devel@lists.sourceforge.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] f2fs: set zstd compress level correctly
Thread-Topic: [PATCH] f2fs: set zstd compress level correctly
Thread-Index: AQHY+pbedvpO7jwZYkCuOnlXi55qZq5NSZQA
Date:   Thu, 24 Nov 2022 00:55:01 +0000
Message-ID: <8BB6F23D-6BC3-4B5A-BA94-9B8A4C58BC92@fb.com>
References: <20221117151054.2232946-1-shengyong@oppo.com>
In-Reply-To: <20221117151054.2232946-1-shengyong@oppo.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Alqs+bMc4IvPDWqYCXyc91FIYiEbMrenlX511dzj5MirPwPQR5goX/pSJq/3?=
 =?us-ascii?Q?N7iE7RwjwI3DSHDCqOJETf7DDNL6Umh4cAxvHwmB/um6MFnYgKFikVsUgEGw?=
 =?us-ascii?Q?w5vGEQfm9pgIUb/zvoiCgB84Mlita5YcY4Ek8pFI/zKCJNtU1xADboTL2YYh?=
 =?us-ascii?Q?zME/LvYJv/iMMtlCvkCxAm1vHxE88Of4wdk0TRa3MfWW0mAL4J8kI0kkrm0z?=
 =?us-ascii?Q?BUYO1JJMHzeqcKwZSw5ruNUFdtB8kt+HMJcvdFVSaRbYH/1UdAIE38XnAI/o?=
 =?us-ascii?Q?0xysvnTbckK4L8I08iB3FHksbjOohJP6fgBcwPf4kda+ssFHpBdr2w8NjTYM?=
 =?us-ascii?Q?QoxX3D2eo+6JzoLdfU0L3sewEzTJoTiOw36bA7Rf6uTIQ41n1ySZCUjyhEjJ?=
 =?us-ascii?Q?LByEK/VYx0P5dX+8xQaQzsoO+fVwYnc6O+rB0tddl7A4YfIGl9pHKMp7JzDt?=
 =?us-ascii?Q?mnrCGpjAdMnzcfwXVASlndGLjp+FHNz7QCrt4CUCvyxHKVE24PeTY1ivaOvw?=
 =?us-ascii?Q?P800qvdpcFkGO1FescQbukdPtj6bf38W7EHZh1UsJbnX5nt6ZRUA0gTWjat1?=
 =?us-ascii?Q?lnxlBgZs7CAvnR8soYNm0+qUEVijj3fo517uHccy4ymkLEL3/WyU2Frru0AQ?=
 =?us-ascii?Q?k/GPje5xYGtNl4NZbdOP063D7UcJyJ/rhaJraDGPJwcM2yiLpRuLgrdkiYrk?=
 =?us-ascii?Q?miTR+aNMbTqrHMJWIar/fsJNHsWZoESUWbF3E+/3zmPtNgrHsXTFhir4wpqv?=
 =?us-ascii?Q?xlwtXiTL58HddQ9xGeLjqSBkC0UOCknQciq8nnlfWFN8gFZO4gNfrV1aDJKc?=
 =?us-ascii?Q?cqD4yTgiEh4Ff0cnBZEjnoROj2LLW5Lw2Zt9xcFD3IZcnjJBjxUbE6iA63uE?=
 =?us-ascii?Q?WSAr4JDA+2/UqV1ETdRZke+EouUKV0wRzH8W0RCBhW5YsXJBoSndyK7xfeT4?=
 =?us-ascii?Q?3yMFCzEQPop0t2XYGLoBglWxRVFfaiIuopJQNkrsLS5lQqRl7jeuNZTkvY0+?=
 =?us-ascii?Q?qQSqaoEs9MhJQ+V/0pF4xSB6sgB5qABJ0M+yobujJ6gGssBrWSqR+Z9nZui1?=
 =?us-ascii?Q?OkHO0Zxgkmmqa4hH3maju4wmSFA/AjTEUI60CTUaas2nLvSZJEkRnqSPe0mz?=
 =?us-ascii?Q?3b9qFNb8+IHf4cY4LTa7379ovbECHKBTS9sQ8f/Lw44BqEWrn2UtKSv3h69G?=
 =?us-ascii?Q?n+xn+dvzjc3zES1rB6zZ8kjTATjSp6wITvrjZLjFZ0Vjl/+uAD/nLmY6w4EY?=
 =?us-ascii?Q?i1NCSW9ujoiu9qSdohqk2AB+Fee/Cp953SwJsNwXWMpMJb2uSouPXI3ZCAR8?=
 =?us-ascii?Q?eINRHfGcfIDUzVxwO5xxmJB7sX6MA01OARPtzQkc/kA7oijxeQtojZUNHyXw?=
 =?us-ascii?Q?d4Zfv1fbl6Uv0C+2ImNJbI21Qwp4s7vo9y9RkkAv6NqpIck7PVrzDYwqcuW/?=
 =?us-ascii?Q?i+nSyDnJ1KYYFXJp5w3759LLwqaMiMut8/IuPowV1tTLpKq/IPaSDIHAwO1j?=
 =?us-ascii?Q?wUJJINY8VdGqURXXORW1ittAhLH/SmaYwssVEgw6ZEY8QVc2qPgGHaEhn1ES?=
 =?us-ascii?Q?ykpiMxNX0qGGKvIsgusOwDENu6K2uEQaJEPUnISRd2lB3b0u2xLhD7is3AAm?=
 =?us-ascii?Q?6TeQVD3RPM3i6u9kDI16eRE=3D?=
Content-ID: <302FEDF0361C9D44AE1E9681B8C22631@namprd15.prod.outlook.com>
MIME-Version: 1.0
X-OriginatorOrg: meta.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY5PR15MB3667.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e7fcb696-033c-4728-201d-08dacdb68451
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Nov 2022 00:55:01.3060
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: joIbD7e30RtxdHHGiTbEA9Lf3TpBhqORNvimOz0esaofDs/mmRZ24ApME5fff2doQfVHiVyQ32lK20x1sZwaDQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR15MB1109
X-Proofpoint-ORIG-GUID: IwuOjDq0g5zjlVNNreEqOCWcZbF9X_R2
X-Proofpoint-GUID: IwuOjDq0g5zjlVNNreEqOCWcZbF9X_R2
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-23_13,2022-11-23_01,2022-06-22_01
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Nov 17, 2022, at 7:10 AM, Sheng Yong <shengyong@oppo.com> wrote:
>=20
> >=20
> Fixes: cf30f6a5f0c6 ("lib: zstd: Add kernel-specific API")
> Signed-off-by: Sheng Yong <shengyong@oppo.com>
> ---
> fs/f2fs/compress.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c
> index d315c2de136f2..74d3f2d2271f3 100644
> --- a/fs/f2fs/compress.c
> +++ b/fs/f2fs/compress.c
> @@ -346,7 +346,7 @@ static int zstd_init_compress_ctx(struct compress_ctx=
 *cc)
> 	if (!level)
> 		level =3D F2FS_ZSTD_DEFAULT_CLEVEL;
>=20
> -	params =3D zstd_get_params(F2FS_ZSTD_DEFAULT_CLEVEL, cc->rlen);
> +	params =3D zstd_get_params(level, cc->rlen);
> 	workspace_size =3D zstd_cstream_workspace_bound(&params.cParams);
>=20
> 	workspace =3D f2fs_kvmalloc(F2FS_I_SB(cc->inode),
> --=20
> 2.25.1
>=20

Thanks for the patch, and sorry for introducing the bug!
Looks like I missed this while rebasing that patch series.

Reviewed-by: Nick Terrell <terrelln@fb.com>