Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <nobuhiro1.iwamatsu@toshiba.co.jp>
To:     <xiujianfeng@huawei.com>, <mturquette@baylibre.com>,
        <sboyd@kernel.org>
CC:     <linux-clk@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] clk: visconti: Fix memory leak in visconti_register_pll()
Thread-Topic: [PATCH] clk: visconti: Fix memory leak in
 visconti_register_pll()
Thread-Index: AQHY/obtzQiD5+mlMUS8/8mSIDapEK5NSRrA
Date:   Thu, 24 Nov 2022 01:22:28 +0000
Message-ID: <TYWPR01MB9420832555EFC60126BE0909920F9@TYWPR01MB9420.jpnprd01.prod.outlook.com>
References: <20221122152353.204132-1-xiujianfeng@huawei.com>
In-Reply-To: <20221122152353.204132-1-xiujianfeng@huawei.com>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?eDlTd0x0ZVhlN0k1NVBvck9sNy9qaHZ4dmYyV1pTTHVESnhTU092bWht?=
 =?iso-2022-jp?B?OXhTSlRqRlR4WVBFTFJidmNsc09HS1BvWDBUanNTM1NQUVdhQnI5YVdS?=
 =?iso-2022-jp?B?K3dzbmtWZnZNQnlQdkJaZ3IvbVU4UHo0bDFkTU85OG1mcG5OSzZGTWtJ?=
 =?iso-2022-jp?B?VjYyL1J6SWhKMDdEcEVvNUIydWZPQVFubTV5YXhHdlVBSTB2WGtGazNr?=
 =?iso-2022-jp?B?WjZyMkdYaU5VdGRvV3RjcVpZNnJWZmNYUlIyT3VuaWVWZDFXMEo0R2M4?=
 =?iso-2022-jp?B?Y1IyWHRhZVd4NTc5L2g5dzg5TXFtQlkyUG1aTHh3SHRYU0NCajlPOU9T?=
 =?iso-2022-jp?B?em5QWEhHNlBnd01aWGc0dW5OeFN1ajZzODNMNzdPUlhHWUU3SjZrZFl3?=
 =?iso-2022-jp?B?YnFVOVNucStJYjR2aTFJREVSY043UFlXOGlTczdHYTB4cXl3RmFSdVNq?=
 =?iso-2022-jp?B?alI0RjMvSFZIck9YV0VmdlR0UmlMSERtVjFlRE42WE5KaExwOC9WNUpi?=
 =?iso-2022-jp?B?NEdMa1ZLbDQrNGpza1JWTFJUaUdvZi9vcDJ4N3Y3cHlLYnJoeGY5dnJ6?=
 =?iso-2022-jp?B?aWNhVmpzZXBMbTRuenp4aXhIc2dSRnF4UmJubk92QUs1ajVBcHFwejF6?=
 =?iso-2022-jp?B?N2d1Y1hxdFJLdE9WSG1qK2ExRi9yL2d5Zk55aGM2akozeDVWeGx5VXlJ?=
 =?iso-2022-jp?B?SmtTWmJMcTJOUEVCT0Z2ek80OW1MdzRJaDRrc3lNcndNcXdXbW9kS20z?=
 =?iso-2022-jp?B?VHA3VnhDdjU2cm80ZWJCb3lwMUU1VnhnaWhzWWJ1aFp1UkZpUXpyaXRw?=
 =?iso-2022-jp?B?R2N2aHVuRlRLTE4xY1g5eENkeEF0Slk2MUlrQ0xNUzc4TEV3OXN2Skly?=
 =?iso-2022-jp?B?WU5wWHV6L25kUG5xa00yWWw2Y1Z0dnpNbmQrZ3VCVFJlN1VMRnBtdm8y?=
 =?iso-2022-jp?B?dlFhcG5OYUdIMXBBT0hiZHZJaWlKRGFpV0VtblcvZ3NHMXlCRmhXWHBl?=
 =?iso-2022-jp?B?TXJLY3Fyak93TWVidzFyMml6cjNTQWVDUXQ3dFRLQ0hYOFR4ZGVCcDRt?=
 =?iso-2022-jp?B?eWxDY1hGN1YwU3JsZ2p2cDZZTS8xZkxKUkFiVk1mSEZLbWJmRUxlVzdo?=
 =?iso-2022-jp?B?OWYrUDRnSEt4MTI4dy9MUFo3anNQSnpFc3FqQ1lBVUhjNGs3Y1pmQUtY?=
 =?iso-2022-jp?B?T1R3WXo0Y3lvWE5mQXFPT002T2dxcnJJYlJ3d1JRK1ZYbWQxSTlIeDRj?=
 =?iso-2022-jp?B?VEgrMDhhZ3g0TmcyYUFncFhObG5xL1N1MGlUL2lQWWRqallPQzVHSmdM?=
 =?iso-2022-jp?B?RWtFbXY5b09mM0ZWblhiU1NCTy9NaDhOQjlZQkQ3K1V6ZGdsQmdEb0RT?=
 =?iso-2022-jp?B?NnlFNXBITXRwLzhyVTVxLzdwK25GZUx5TWFpckw4ekhOY0ptUTdNRTcy?=
 =?iso-2022-jp?B?cnpNMjMzMFJUVGlHRHpIeW9hcW9CVFF1ZXhybVUxUmdLQ0RsandEZGZq?=
 =?iso-2022-jp?B?UWUzemcvSDRVdS9wL0EvTWEzd0hIN2pVeEd0TitJZ1BVOWFIZ2w5RkRh?=
 =?iso-2022-jp?B?RUx4REQyRWs1ejE1Unp0aE5JREs0aVJrSnJDRVVVblc5ekR0WEhtWTc2?=
 =?iso-2022-jp?B?R1RvOTFpYmxzMDZ2UTdGeGIvWnlPNVJHSWFqWndYRmQzbTlVQ3ZWNnRE?=
 =?iso-2022-jp?B?dXhiZXpMdGZ4UExKYktxdlgrR0pXY3M3T3BiV3ZvUVdSS0xpclZvdUNL?=
 =?iso-2022-jp?B?SDFZdkNHL2VNZ01IOTgxdDhBaHo4b1FYdFVLbE1xcDR3Tmo5bnRRTTVv?=
 =?iso-2022-jp?B?cmpjV0xTczlBYlNHeXZVbUVhUGpsNDFsR2VzOWpic0J4dk1kNnhUdmNy?=
 =?iso-2022-jp?B?QTdpbGU5ZFgvN1lNS2pPajlHM3RGSEtCcGgvRENyNElKdkRLbUZpRFFI?=
 =?iso-2022-jp?B?Q2pVUlNnWUo4ZmhYVkJyaUl0MXMxaHpMeDBzWDVaZTZIOEFEZGJyZHAz?=
 =?iso-2022-jp?B?RU16NzhmYkdzeXJNT3RXeFdtMUFYc3RGM0M2ZHJGdjFHOXRYRUt4TUtK?=
 =?iso-2022-jp?B?ZjdKRENWU01GYzZmREd2ZEJrdkR6TG51aU9pTlByUDBFNC9wVTFJSEFt?=
 =?iso-2022-jp?B?NGZ2UnNhaUV4U2JHaWZwWmZaQ01RQWtvY0JmR2krd3JVRy8vTlJKOWhn?=
 =?iso-2022-jp?B?cENiSUVPMnVWZkR4T0pQeWllM1BxaGNWcFRWWVFUTnA4eTVmendvTUVL?=
 =?iso-2022-jp?B?Q21uK2liY3NaN2R4dWpCcnArVXZIaGhDTDVwRGV4LzNEb3BUZ2RWTWZD?=
 =?iso-2022-jp?B?d0xQUm1aOEhhT2tkeHU1NmJPVHp5RHhETEE9PQ==?=
Content-Type: text/plain; charset="iso-2022-jp"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TYWPR01MB9420.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dfa5e23a-2679-41bc-305a-08dacdba5a21
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Nov 2022 01:22:28.5925
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: f109924e-fb71-4ba0-b2cc-65dcdf6fbe4f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: B43yzPfzGv5CfuKX8TD2lijLz9Xb5HARD0Wy6T4y+7/FQLr7EJPMhjx3chVy91ck/KRAT4HIUbenP7CG+0H7Rqn0zt/Hb5d4xs342I0AuwnRCaKX5SzWhMBRyGsa64b4
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY1PR01MB10802
X-OriginatorOrg: toshiba.co.jp
MSSCP.TransferMailToMossAgent: 103
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,
        SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Xiu,

Thanks for your patch!

> -----Original Message-----
> From: Xiu Jianfeng <xiujianfeng@huawei.com>
> Sent: Wednesday, November 23, 2022 12:24 AM
> To: mturquette@baylibre.com; sboyd@kernel.org; iwamatsu nobuhiro(岩松 信
> 洋 □ＳＷＣ◯ＡＣＴ) <nobuhiro1.iwamatsu@toshiba.co.jp>
> Cc: linux-clk@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> linux-kernel@vger.kernel.org
> Subject: [PATCH] clk: visconti: Fix memory leak in visconti_register_pll()
> 
> @pll->rate_table has allocated memory by kmemdup(), if clk_hw_register()
> fails, it should be freed, otherwise it will cause memory leak issue, this patch
> fixes it.
> 
> Fixes: b4cbe606dc36 ("clk: visconti: Add support common clock driver and
> reset driver")
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>

Acked-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>

Best regards,
  Nobuhiro
> ---
>  drivers/clk/visconti/pll.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/visconti/pll.c b/drivers/clk/visconti/pll.c index
> a484cb945d67..1f3234f22667 100644
> --- a/drivers/clk/visconti/pll.c
> +++ b/drivers/clk/visconti/pll.c
> @@ -277,6 +277,7 @@ static struct clk_hw *visconti_register_pll(struct
> visconti_pll_provider *ctx,
>  	ret = clk_hw_register(NULL, &pll->hw);
>  	if (ret) {
>  		pr_err("failed to register pll clock %s : %d\n", name, ret);
> +		kfree(pll->rate_table);
>  		kfree(pll);
>  		pll_hw_clk = ERR_PTR(ret);
>  	}
> --
> 2.17.1