Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 24 Nov 2022 09:21:09 +0800
From:   Feng Tang <feng.tang@intel.com>
To:     Vlastimil Babka <vbabka@suse.cz>
CC:     Andrew Morton <akpm@linux-foundation.org>,
        Christoph Lameter <cl@linux.com>,
        Pekka Enberg <penberg@kernel.org>,
        David Rientjes <rientjes@google.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        Roman Gushchin <roman.gushchin@linux.dev>,
        Hyeonggon Yoo <42.hyeyoo@gmail.com>,
        "Andrey Konovalov" <andreyknvl@gmail.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        Andrey Ryabinin <ryabinin.a.a@gmail.com>,
        Alexander Potapenko <glider@google.com>,
        Vincenzo Frascino <vincenzo.frascino@arm.com>,
        <linux-mm@kvack.org>, <kasan-dev@googlegroups.com>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 -next 1/2] mm/slb: add is_kmalloc_cache() helper
 function
Message-ID: <Y37HBTKnLVT03H5y@feng-clx>
References: <20221123123159.2325763-1-feng.tang@intel.com>
 <bdafa84a-e5db-471b-fdb2-34ecbf09c225@suse.cz>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <bdafa84a-e5db-471b-fdb2-34ecbf09c225@suse.cz>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?AAn1vxFSFRa3WsJvfg+che4alWk1kenxdCai3WRqzqLqzY7VrQs6pHKWix/L?=
 =?us-ascii?Q?53KtP2dQ//bR78XkVea/GRRzmBhWK5e4zbTF7cPQHMBGuAfzeEWsvcxqTRxn?=
 =?us-ascii?Q?3dEw4fAd1gvWwYoLfjsfWMFLOy341yZQp2QGkt7uc3fnPaUAJJIZSOa5++eR?=
 =?us-ascii?Q?TnX6MjBxc2AyDFa7uSmbMebLmHZyNfz3dVIBeSIXxxK7dmifiMSwETNW34n2?=
 =?us-ascii?Q?h/AGDpCHIIJ2jpeEQy9LSnjpo5h8GwEzqyFvKA4Bne0JPn+B7cvaA/xB6dlk?=
 =?us-ascii?Q?ndCoPppkIFrjgF9wg+jk3Kk3G0tJotsKwINzY2Wc9zf0fYgi2qHoeio1qjwh?=
 =?us-ascii?Q?oEjZo5f4DYyHE/VCZROCQPKv2o8cgUpSnM5qa0H71GEfes9qnMkqDrP3zZ9D?=
 =?us-ascii?Q?wqwOSLh1QXgAtmf0/ZYnXdJ6WuQLhYxiK2NDHYIDbxSSxCQa8TAzGdF46nYK?=
 =?us-ascii?Q?nZ5OAfC1+bNSG5Y3nfCCEb09Jdv8q0G2+vVNdjeeXGpQgjMIsiquvGirWUFg?=
 =?us-ascii?Q?d+Btfcm1LGtrC7mmsAAojL2HkwRmpQQrYFwT0Slmjv7HSm43oRIfvIIUPNkv?=
 =?us-ascii?Q?noVDdd2p+MHth/SYDZwsYah5LZciRyttFRKa82QCLhfITFF6bsPidethlvWg?=
 =?us-ascii?Q?DEva66PU109TlDBip0qj3n8a9td62sIpQ/AukIG2iFkC6plUP9p0II6TkNNl?=
 =?us-ascii?Q?Uu/EKAacJGxwkoM3R35NcD5j0sgXK/aWBhf9FRNeTD8EuZ5kWrM216FUqb+K?=
 =?us-ascii?Q?mkyaDBYj73Z+SfFA49OK9zEK785Rh5exCdiQhfv2fDo6WdgEbIXpnAzZOSeO?=
 =?us-ascii?Q?c3RJPt4BY47wSFosFbAyhIFtaIfsIIP9U52TRj+59XbqvonMAzD3FJB0kW4d?=
 =?us-ascii?Q?2yxHNHcyGSkzc0vi+HZXYlosjpgzTpko3lc87UmqEfHkJvAqA6H9VOYsrsdH?=
 =?us-ascii?Q?p9k08boENHFAaM/8gzP207feuHwkWzJ1A5lmilDU3MToktYueuD/GipzrGBG?=
 =?us-ascii?Q?xJA80Ou0WEHse9ZLRajlRaHP5vaJ+I5tPMbCowwSeJqMrTgdrY1VSM2NMhYO?=
 =?us-ascii?Q?2iL+u6LecNHHkh6+BRrDml4qUU33dYh/Lb4CYPr/QzbLLVasQfU5Lgvy18L7?=
 =?us-ascii?Q?qCRp6cIKkx/DpaognOnxdq1XuwupZ99Z5phnDdfWifAmg4sASSxmEQuohPxS?=
 =?us-ascii?Q?yXimlIYpN8qKQazuvQ7mWd5/b49U6OaDc0ihBJkHHjyO2+NcVOo2VNt2omxZ?=
 =?us-ascii?Q?L/AD9p59d4kyNjsf333lTU90OLNS0B7cDAv8HgmfCkplJ5H2uKycSfJRXB9U?=
 =?us-ascii?Q?pMg6KZBk7NxVGRhWdD9cV/q4mayLRULUqcOMpngMbL7hM7OM/3GCNi8iNTk9?=
 =?us-ascii?Q?DurzvCgvUNinhslEp7xI1g7QvEMIlDAnxrbisMoczp7GgJRpQtthgIa/q3vi?=
 =?us-ascii?Q?E1L+ZG0scJopxRpEeft/FFr8fjUdP7rTOMmctMTdn3N16ZhitILYyoiDm9kC?=
 =?us-ascii?Q?vMQYbxdhb+Pnb14PmhJDv84eXmoSwiVNMDOg11JKxx/36izq3/YRb0EIVf+n?=
 =?us-ascii?Q?j1WADWPbLvOGwrwnqvxxnOOIlJWaF2o2qYFBTj/e?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 49b3761c-0b7d-4f03-0214-08dacdba9b4e
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2022 01:24:18.0788
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 05KDTf8ivWfZh2zvAyXc6zM2Z6D69pkaGN4JKGt8ujc7sWKZEu9yvTvKyt0oIrzwjoyaaC5YKCjdFU/dQN6F9g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5306
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Nov 23, 2022 at 06:03:26PM +0100, Vlastimil Babka wrote:
> Subject should say mm/slab

My bad, thanks for catching this.

> On 11/23/22 13:31, Feng Tang wrote:
> > commit 6edf2576a6cc ("mm/slub: enable debugging memory wasting of
> > kmalloc") introduces 'SLAB_KMALLOC' bit specifying whether a
> > kmem_cache is a kmalloc cache for slab/slub (slob doesn't have
> > dedicated kmalloc caches).
> > 
> > Add a helper inline function for other components like kasan to
> > simplify code.
> > 
> > Signed-off-by: Feng Tang <feng.tang@intel.com>
> 
> Acked-by: Vlastimil Babka <vbabka@suse.cz>

Thanks!

> Patch 2 seems to depend on patches in Andrew's tree so it's simpler if he
> takes both of these too.

Yes, patch 2/2 change many places of kasan code.

Hi Andrew,

Could you consider taking these 2 patches to your tree? If you think
it's too close to the merge windown, I can respin after 6.2. thanks!

- Feng

> Thanks,
> Vlastimil
> 
> > ---
> > changlog:
> >   
> >   since v1:
> >   * don't use macro for the helper (Andrew Morton)
> >   * place the inline function in mm/slb.h to solve data structure
> >     definition issue (Vlastimil Babka)
> > 
> >  mm/slab.h | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git a/mm/slab.h b/mm/slab.h
> > index e3b3231af742..0d72fd62751a 100644
> > --- a/mm/slab.h
> > +++ b/mm/slab.h
> > @@ -325,6 +325,14 @@ static inline slab_flags_t kmem_cache_flags(unsigned int object_size,
> >  }
> >  #endif
> >  
> > +static inline bool is_kmalloc_cache(struct kmem_cache *s)
> > +{
> > +#ifndef CONFIG_SLOB
> > +	return (s->flags & SLAB_KMALLOC);
> > +#else
> > +	return false;
> > +#endif
> > +}
> >  
> >  /* Legal flag mask for kmem_cache_create(), for various configurations */
> >  #define SLAB_CORE_FLAGS (SLAB_HWCACHE_ALIGN | SLAB_CACHE_DMA | \
>