Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221122085724.3245078-1-milkfafa@gmail.com> <20221122085724.3245078-4-milkfafa@gmail.com>
 <7561a0c3-c63b-a3f2-efeb-4bb0f4ad03e4@kernel.org>
In-Reply-To: <7561a0c3-c63b-a3f2-efeb-4bb0f4ad03e4@kernel.org>
From:   Kun-Fa Lin <milkfafa@gmail.com>
Date:   Thu, 24 Nov 2022 11:53:44 +0800
Message-ID: <CADnNmFqswx3VEFBAxUPbznyct2L880H6i6LghF_tAzZ=wS5T8A@mail.gmail.com>
Subject: Re: [PATCH v7 3/7] dt-bindings: arm: nuvoton: Add bindings for NPCM GFXI
To:     Krzysztof Kozlowski <krzk@kernel.org>
Cc:     mchehab@kernel.org, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        openbmc@lists.ozlabs.org, avifishman70@gmail.com,
        tmaimon77@gmail.com, tali.perry1@gmail.com, kwliu@nuvoton.com,
        kflin@nuvoton.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Krzysztof,

> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC.  It might happen, that command when run on an older
> kernel, gives you outdated entries.  Therefore please be sure you base
> your patches on recent Linux kernel.

Thanks for your kind reminder. I'll check for this again.

> > +description:
> > +  The Graphics Core Information (GFXI) are a block of registers in Nuvoton SoCs
> > +  that analyzes Graphics core behavior and provides inforomation in registers.
>
> typo: information
>
> > +
> > +properties:
> > +  compatible:
> > +    items:
> > +      - enum:
> > +          - nuvoton,npcm750-gfxi
> > +          - nuvoton,npcm845-gfxi
> > +      - const: syscon
> > +      - const: simple-mfd
>
> That's not simple-mfd, you do not have any devices.

These problems will be addressed in the next patch, thanks for the review.

Regards,
Marvin