Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 24 Nov 2022 08:08:10 +0100
From:   Nicolas Schier <nicolas@fjasle.eu>
To:     Masahiro Yamada <masahiroy@kernel.org>
Cc:     linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>
Subject: Re: [PATCH v2 5/5] kbuild: check Make version
Message-ID: <Y38YWrlPTpB7LoIY@bergen.fjasle.eu>
References: <20221123151828.509565-1-masahiroy@kernel.org>
 <20221123151828.509565-5-masahiroy@kernel.org>
 <Y36OZVnAZBqxcrBw@bergen.fjasle.eu>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="OSEL46hI/6K+vX1j"
Content-Disposition: inline
In-Reply-To: <Y36OZVnAZBqxcrBw@bergen.fjasle.eu>
Jabber-ID: nicolas@fjasle.eu
Precedence: bulk


--OSEL46hI/6K+vX1j
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed 23 Nov 2022 22:19:33 GMT, Nicolas Schier wrote:
> On Thu 24 Nov 2022 00:18:28 GMT, Masahiro Yamada wrote:
> > This is implemented based on test-le. It will work until GNU Make 10
> > is released.
>=20
> ... and as long as nobody uses make versions w/ minor version numbers,=20
> cp. patch 3/5.
>=20

I had a wrong understanding of the ASCII sort and forgot to re-check my=20
own assumptions.

Thanks for that whole patch set!

Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>


>=20
> >=20
> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> > ---
> >=20
> > (no changes since v1)
> >=20
> >  Makefile | 3 +++
> >  1 file changed, 3 insertions(+)
> >=20
> > diff --git a/Makefile b/Makefile
> > index 60ce9dcafc72..797fafbc1b45 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -368,6 +368,9 @@ else # !mixed-build
> > =20
> >  include $(srctree)/scripts/Kbuild.include
> > =20
> > +# Check for the minimal Make version
> > +$(if $(call test-lt, $(MAKE_VERSION), 3.82), $(error Make $(MAKE_VERSI=
ON) is too old))
> > +
> >  # Read KERNELRELEASE from include/config/kernel.release (if it exists)
> >  KERNELRELEASE =3D $(call read-file, include/config/kernel.release)
> >  KERNELVERSION =3D $(VERSION)$(if $(PATCHLEVEL),.$(PATCHLEVEL)$(if $(SU=
BLEVEL),.$(SUBLEVEL)))$(EXTRAVERSION)
> > --=20
> > 2.34.1
>=20
> --=20
> epost|xmpp: nicolas@fjasle.eu          irc://oftc.net/nsc
> =E2=86=B3 gpg: 18ed 52db e34f 860e e9fb  c82b 7d97 0932 55a0 ce7f
>      -- frykten for herren er opphav til kunnskap --


--=20
epost|xmpp: nicolas@fjasle.eu          irc://oftc.net/nsc
=E2=86=B3 gpg: 18ed 52db e34f 860e e9fb  c82b 7d97 0932 55a0 ce7f
     -- frykten for herren er opphav til kunnskap --

--OSEL46hI/6K+vX1j
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEh0E3p4c3JKeBvsLGB1IKcBYmEmkFAmN/GFUACgkQB1IKcBYm
EmlIyw/+Idg8UnMhykjqhkYbuAoQX6yYOWfIZ9HyPHVkn4RuFJgiZnzjsDGOsfY9
H1dthbFSDhuyet1/cnns7NwPiSJx4nhHIHKe0hxUkQgjjmoFoUUUGbx/q7cS6nNX
V1FN9rD/M5xfCxJKkresr8NNifvyy1POZFt0b8hE0wWx1cWEtN9p/0r0+C5hSHwU
uNDQiv6IbL0GtUgBRogfx5w3kXSk0ja86SNcumcKJHCnAf3SlAAORvynpzfsZ0Ea
NQjLlUx0ZczIL+O4koBo5tyo2QV4v9ChOhsjVH4QaPz6oXpHUG35+qiKH6GQEgCK
Nfgjv9UzcsNarbOHAn/DGCk/u5p2k8zmJbr0KeMlZ4dab9l7k+ySzT31DccvL55W
4Qxa7yJcpgMgJ3Il/p4eldCo+6rWRL5uDs4NELYjPS4bCi49dzXuqu2qE2fZoDwK
sCrRv45IRjRzIlN85mjxvlFXB4FSOGgB5V035McTcJh+mbyQCUh8jLeJ4uvM3sUD
zk6fgb5N6xU4iVsfEbMavfRzHlsyuv294XLGOz9Gg+usu1ZpWO5xVEoMZlk1aY1o
+PDUjtvuKVhYWp7wal1WegyBOX7nwsfwrqY83boEjd5RwhMV7xe5LBjpvMnyF2IC
Plktpd1qfQ6ex3Keh0xrkQUKLMn+DSu9BnlsXTMZ5TYrq4w4USI=
=+eIc
-----END PGP SIGNATURE-----

--OSEL46hI/6K+vX1j--