Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0d47da05-9818-e6ed-c778-b1ad90688125@linux.alibaba.com>
Date:   Thu, 24 Nov 2022 15:59:43 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.13.1
Subject: Re: [PATCH v2 2/2] fscrypt: Add SM4 XTS/CTS symmetric algorithm
 support
Content-Language: en-US
To:     Eric Biggers <ebiggers@kernel.org>
Cc:     "Theodore Y. Ts o" <tytso@mit.edu>,
        Jaegeuk Kim <jaegeuk@kernel.org>,
        Jonathan Corbet <corbet@lwn.net>, Jens Axboe <axboe@kernel.dk>,
        Ard Biesheuvel <ardb@kernel.org>,
        linux-fscrypt@vger.kernel.org, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
References: <20221122070632.21910-1-tianjia.zhang@linux.alibaba.com>
 <20221122070632.21910-3-tianjia.zhang@linux.alibaba.com>
 <Y30hjJq1Vwl4k1dJ@sol.localdomain>
From:   Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
In-Reply-To: <Y30hjJq1Vwl4k1dJ@sol.localdomain>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Eric,

On 11/23/22 3:22 AM, Eric Biggers wrote:
> On Tue, Nov 22, 2022 at 03:06:32PM +0800, Tianjia Zhang wrote:
>> SM4 is a symmetric algorithm widely used in China, this patch enables
>> to use SM4-XTS mode to encrypt file content, and use SM4-CBC-CTS to
>> encrypt filename.
>>
>> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
> 
> There is still no explanation here about why you believe this algorithm is
> useful to support in fscrypt.
> 
> - Eric

Sorry, I will send a new version of patch to add these information.

Best regards,
Tianjia