Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 24 Nov 2022 10:41:42 +0200
From:   Andy Shevchenko <andriy.shevchenko@intel.com>
To:     Tony Lindgren <tony@atomide.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Ilpo =?iso-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        Jiri Slaby <jirislaby@kernel.org>,
        Johan Hovold <johan@kernel.org>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-serial@vger.kernel.org, linux-omap@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] serial: core: Add port port device to flush TX on
 runtime resume
Message-ID: <Y38uRqAFjKpAPy8J@smile.fi.intel.com>
References: <20221123082825.32820-1-tony@atomide.com>
 <20221123082825.32820-2-tony@atomide.com>
 <Y35oT9/3OKRciWCP@smile.fi.intel.com>
 <Y38UQXbzw54Jo93s@atomide.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y38UQXbzw54Jo93s@atomide.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Thu, Nov 24, 2022 at 08:50:41AM +0200, Tony Lindgren wrote:
> * Andy Shevchenko <andriy.shevchenko@intel.com> [221123 18:37]:
> > On Wed, Nov 23, 2022 at 10:28:25AM +0200, Tony Lindgren wrote:
> > > +EXPORT_SYMBOL(serial_port_get);
> > 
> > Can we move these to namespace from day 1?
> 
> Assuming you mean EXPORT_SYMBOL_NS(), sure.
> 
> But we might be better off doing the following:
> 
> - Move already exported uart_add_one_port() and uart_remove_one_port()
>   from serial_core to serial_port as wrapper functions for serial_core
> 
> - Export new functions in serial_core for serial_core_register_port()
>   and serial_core_unregister_port() for serial_port to call
> 
> This would ensure both serial_core and serial_port modules are
> always loaded when a hardware specific serial port driver is
> loaded.
> 
> This should also leave out the need for serial_port_get() and
> serial_port_put().

Yes, this is good idea!

-- 
With Best Regards,
Andy Shevchenko