Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fe4f04d4-04aa-895d-960f-8d27581f431e@starfivetech.com>
Date:   Thu, 24 Nov 2022 17:50:13 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH v2 1/8] dt-bindings: riscv: Add StarFive JH7110 SoC and
 VisionFive2 board
Content-Language: en-US
To:     Emil Renner Berthing <emil.renner.berthing@canonical.com>
CC:     "linux-riscv@lists.infradead.org" <linux-riscv@lists.infradead.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        Conor Dooley <conor@kernel.org>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Ben Dooks <ben.dooks@sifive.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Marc Zyngier <maz@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        "Linus Walleij" <linus.walleij@linaro.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20221118011714.70877-1-hal.feng@starfivetech.com>
 <20221118011714.70877-2-hal.feng@starfivetech.com>
 <202211190418.2AJ4IQjc072382@SH1-CSMTP-DB111.sundns.com>
 <ca3e341a-3dc3-39d6-7e26-89ba65aa9473@starfivetech.com>
 <CAJM55Z-zgR=LKqtg4ioj9Ez1CT7wchrNWWPVT5XAMPF736OcRA@mail.gmail.com>
From:   Hal Feng <hal.feng@starfivetech.com>
In-Reply-To: <CAJM55Z-zgR=LKqtg4ioj9Ez1CT7wchrNWWPVT5XAMPF736OcRA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 24 Nov 2022 10:20:32 +0100, Emil Renner Berthing wrote:
> On Thu, 24 Nov 2022 at 06:56, Hal Feng <hal.feng@starfivetech.com> wrote:
> >
> > On Sat, 19 Nov 2022 01:28:48 +0800, Emil Renner Berthing wrote:
> > > On Fri, 18 Nov 2022 at 02:17, Hal Feng <hal.feng@starfivetech.com> wrote:
> > > >
> > > > From: Emil Renner Berthing <kernel@esmil.dk>
> > > >
> > > > Add device tree bindings for the StarFive JH7110 RISC-V SoC [1]
> > > > and the VisionFive2 board [2] equipped with it.
> > > >
> > > > [1]: https://doc-en.rvspace.org/Doc_Center/jh7110.html
> > > > [2]: https://doc-en.rvspace.org/Doc_Center/visionfive_2.html
> > > >
> > > > Signed-off-by: Emil Renner Berthing <kernel@esmil.dk>
> > > > Signed-off-by: Hal Feng <hal.feng@starfivetech.com>
> > > > ---
> > > >  Documentation/devicetree/bindings/riscv/starfive.yaml | 4 ++++
> > > >  1 file changed, 4 insertions(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/riscv/starfive.yaml b/Documentation/devicetree/bindings/riscv/starfive.yaml
> > > > index 5b36243fd674..64008c57e31f 100644
> > > > --- a/Documentation/devicetree/bindings/riscv/starfive.yaml
> > > > +++ b/Documentation/devicetree/bindings/riscv/starfive.yaml
> > > > @@ -22,6 +22,10 @@ properties:
> > > >            - const: beagle,beaglev-starlight-jh7100-r0
> > > >            - const: starfive,jh7100
> > > >
> > > > +      - items:
> > > > +          - const: starfive,visionfive-v2
> > >
> > > I think StarFive has switched to just calling it VisionFive 2 and not
> > > V2. Please check up on this before committing to the compatible
> > > string.
> > >
> > > Also there are going to be different revisions of the VisionFive 2
> > > board, so maybe consider adding eg. starfive,visionfive-2-v1.1 and
> > > starfive,visionfive-2-v1,2b early.
> >
> > I checked that the official name of this board is "VisionFive 2". The
> > board has version A and version B, which are different in gmac and phy
> > chip. The version A board has one 1000M and one 100M Ethernet ports
> > while the version B board has two 1000M Ethernet ports. In dts, they
> > have different configuration parameters for gmac. So I would like to
> > distinguish them by two compatibles as below in the next version.
> >
> >       - items:
> >           - enum:
> >               - starfive,visionfive-2-va
> >               - starfive,visionfive-2-vb
> >           - const: starfive,jh7110
> 
> Cool. Though the silkscreen on my board says "VisionFive 2 V1.2B" so I
> think it would be less confusing if you used that as the model, and
> "starfive,visionfive-2-v1.2b" as the compatible string for the board.

As far as I know, VisionFive 2 V1.3B is coming and all version B boards
use the same configuration. It's unnecessary to add the detailed number
of PCB version.

> 
> 
> > Best regards,
> > Hal
> >
> > >
> > > > +          - const: starfive,jh7110
> > > > +
> > > >  additionalProperties: true
> >