Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2751584a-782e-2bdd-b72d-4a726e6ede8d@linaro.org>
Date:   Thu, 24 Nov 2022 10:19:53 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH 2/2] arm64: dts: fsd: add sysreg device node
Content-Language: en-US
To:     Sriranjani P <sriranjani.p@samsung.com>, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, lee@kernel.org,
        devicetree@vger.kernel.org, alim.akhtar@samsung.com,
        pankaj.dubey@samsung.com, ravi.patel@samsung.com
Cc:     linux-kernel@vger.kernel.org
References: <20221121091118.48628-1-sriranjani.p@samsung.com>
 <CGME20221121090647epcas5p439dc84f0c4f435a703a1f8396a11202f@epcas5p4.samsung.com>
 <20221121091118.48628-3-sriranjani.p@samsung.com>
 <a98ac5d7-0c0e-110e-5405-83a09c77ceac@linaro.org>
 <000001d8ff32$c8b78e30$5a26aa90$@samsung.com>
 <03a26971-e54b-a8e7-c02f-ae5a8feba71a@linaro.org>
 <001601d8ff41$231deaf0$6959c0d0$@samsung.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <001601d8ff41$231deaf0$6959c0d0$@samsung.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 23/11/2022 14:40, Sriranjani P wrote:
>>
>>>
>>> So I can think of following two approaches:
>>> 1: For the time being I will put this sysreg node in between
>>> clock_peric node and clock_fysys0 node and clock_fsys1 node as per
>>> increasing unit address. I will clean up other exynos and FSD DTSI
>>> files and post a new patch
>>
>> Not sure what cleaning you have in mind.
>>
>>> 2: First I will clean up exynos and FSD DTSI files and then post this sysreg
>> patch keeping it at appropriate place.
>>
>> What cleaning?
> 
> By cleaning I meant fixing these dtsi files to have the device nodes in the order of ascending unit address.

Such cleanup is fine.

Best regards,
Krzysztof