Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 24 Nov 2022 17:25:44 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc:     tgraf@suug.ch, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH v2] lib/test_rhashtable: Remove set but unused variable
 'insert_retries'
Message-ID: <Y384mIpMqUbwlR+i@gondor.apana.org.au>
References: <20221123093702.32219-1-jiapeng.chong@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221123093702.32219-1-jiapeng.chong@linux.alibaba.com>
Precedence: bulk

On Wed, Nov 23, 2022 at 05:37:02PM +0800, Jiapeng Chong wrote:
> Variable 'insert_retries' is not effectively used in the function, so
> delete it.
> 
> lib/test_rhashtable.c:437:18: warning: variable 'insert_retries' set but not used.
> 
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3242
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> Changes in v2:
>   -The condition for modifying err is less than 0.
> 
>  lib/test_rhashtable.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)

Acked-by: Herbert Xu <herbert@gondor.apana.org.au>

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt