Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <765e1e78-c540-0753-7a19-7d335bcc998b@suse.com>
Date:   Thu, 24 Nov 2022 10:21:33 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH v2] x86: Avoid relocation information in final vmlinux
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
Cc:     tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com,
        x86@kernel.org, hpa@zytor.com, nicolas@fjasle.eu,
        masahiroy@kernel.org, kirill.shutemov@linux.intel.com,
        tony.luck@intel.com, michael.roth@amd.com, nathan@kernel.org,
        ndesaulniers@google.com, linux-kernel@vger.kernel.org
References: <20220927084632.14531-1-petr.pavlu@suse.com>
 <Y34SXeU6JEk+UGfV@zn.tnic> <1af5ee66-5ab1-45b2-f229-182f89dc6b94@suse.com>
 <Y35CNdPVwq11NCYN@zn.tnic>
From:   Petr Pavlu <petr.pavlu@suse.com>
In-Reply-To: <Y35CNdPVwq11NCYN@zn.tnic>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ekJ1REYxNVBxWEpGNHgyUGlXYytpbFBDSVJ2UWR6UlpXUjBLN2JGc3NLU0pw?=
 =?utf-8?B?RXVRV2pQeGF2MTNMSnQzbUFsRzFDK1NoVXcxMEl5VmFPVUZXOHJNOFMrV1Z0?=
 =?utf-8?B?UmNzZHR5UGdwQVdKZUIzMUxYbUcwbkYzUkx3MkFpZXR1a1F3WjcydXZxbHo5?=
 =?utf-8?B?WmpPNGZKYlI5Z2NuZ2lDNVdvSDlHNzVWNlI4MTBXMjRJSEJvSkVnRU5QK09s?=
 =?utf-8?B?aW5CMTRHb0RRTjBhc3VFRVd0SnFBRkdVSXM2aFVFdG1JQmRYdzNMMU9SRGVp?=
 =?utf-8?B?SnV4MjNQK0dJOVBTRFJtT0dVbmVEUUJqMWE1aHZ6U0c0OHVuQlcvck43TU05?=
 =?utf-8?B?VGdETHpKVHVLTXpWTklYeVZndlV2WVp1Sk9SaXhuem5UbGJpMjF2Qmk0ZFpr?=
 =?utf-8?B?VWZ5dGZjNDh2dUh3QXFGTG42R251WCtvNElSTStWN0VjVi8wNW5tcktvSzhu?=
 =?utf-8?B?ZWhBWUlmbENETmlwVTlJVTZ2cGlLNXlIMUh2a3JlT3J0NldTVVdJczUrSVFO?=
 =?utf-8?B?R21wUWRDeWtNZlZHSUtibWg5YjYzM2czMzBqdW5nY3BtbFFOQ0gvOTZxQU9m?=
 =?utf-8?B?OFFjVisyTTk4WVBobkRqMDQzdER5R2tYcDFVMHNIRzJqZ09oQmsxQXdiTmQz?=
 =?utf-8?B?Z2JvSVlQUnYzWXBFbjJFYVlrM2lpcXlReXFHUVVmUlBtU1JFVFRITW1uU28r?=
 =?utf-8?B?ZmVpNFE2Y0xScEswLzFSbXhqY2hVUmcwS2QwRFJPWUJiQnNRMmRub1ZySVVX?=
 =?utf-8?B?SzR0bkYzNGtGRkdDOURVN2cyVzBMV3BqcEZqKzRDdG5FNEZGZjZXb0g0UzYx?=
 =?utf-8?B?N1VPSzBVZnpYYXhVU0ErUWZjV29Od01JT1BGbkh5a0RZTDNoajhjdFc1L2hY?=
 =?utf-8?B?Z3kwd0FsdTA5NmRqeXBtVlhWa2xyZjJyK2xjdDVFaUJGcmpmZGtId2QrVEQ4?=
 =?utf-8?B?WVdTL0RuZGpDbmt0MjBveWNUU1R1c3FzWStNVHEyME9ValFWb2IwV1oxaXBW?=
 =?utf-8?B?aTVlRUwrSzluK29mVkxDUjdEaDZnNGNCdVpBZGpMdDVHOU0zblB2OHVOa3Bs?=
 =?utf-8?B?NjBlanUrUGRWWkRwdmFZZDNrZkVZYlRUK3cxWDBxbkNKbzc0Z0JtekE4TmNT?=
 =?utf-8?B?REllUWJPTjNTWWlpeWhHRlplemFjQk5HdGY2eHFaR2ptdGRNUnltQXVhSE5Y?=
 =?utf-8?B?T2xRdlp3bS9jVjRuWEJROCthbHNlUUo0eTlpMUJ5Z0ZIN3JWY1UwWEg1WWRj?=
 =?utf-8?B?QlJvRjkwU0F4OWwrWEJXcE9Ya0FBUEE5M3U0MFhPendXcStzalZFMTdYVVZs?=
 =?utf-8?B?ckhHelZ0YmJkRUl6R0l1UVd6bER3dS92V0E4M2pIN1h1UFZOZGhQMGZBS2h0?=
 =?utf-8?B?V2ZFR1NBcVJpUXY0SGQrb1YzNHlkMHlPWVhxMU5ITEFpeWxmem8xVFZVNkhI?=
 =?utf-8?B?T3dHb0YvRjVvOU1DbmlXK3V0MUh5Rkx3eGU1VnE3OWRoNFZlV2FadVY0Q041?=
 =?utf-8?B?RThwU0F2dnRkMWNXSFBsUEozMWc3RDhKWmtYQlVXZUFnZW1aLzdRZWQ3d1F5?=
 =?utf-8?B?OVdzN2wvS2RUdmgvcE4va0cwNGN4OE1ibC9abEU2UUVEcVduVDkxelJhekY4?=
 =?utf-8?B?b1ExRUord1IranF2RFBXa2hoOU5peVNtcEhsY3FOeHpCbjkza2RVTWJqbDZm?=
 =?utf-8?B?bXIzKzRqQWQwbGxBQXJwUEh3dGFONzVyMnh0dU0wZzBFK0RNUkxqVGoxaWZ4?=
 =?utf-8?B?bzlscWk5U1F0cEQ1YmJDeC9TSzZMWWpBUWFpSU1qNFJLU0FqeHlDN1RuWEZD?=
 =?utf-8?B?ZUVVdXlONGdZLy9QandsUXNlMWJaVTBITklpc25aMU1mMXVaNUttSmIzVTlv?=
 =?utf-8?B?cUhHWFdiaGlnT0xnYjJrQ0FIU1dqT0IvZHhSaEhrSDd0Ti9BaWpkMzQwdVpE?=
 =?utf-8?B?UnhtRnZZdVlNd29GalhxcXRHcUkrckFJSlJwSXhkcWFZMkw2ejZ5YXdocVdu?=
 =?utf-8?B?WFBHQTVTbHdYQkpUZnVkdmtkWTJWQVBscW5mRzlkSk1yclIrNjB6SFF2b3Y4?=
 =?utf-8?B?ay85Q0I4TUg4MGcva2xhRWFYT2t5QlNXeE1YVHd3VC9ZS0RoU0xBcStYaDJQ?=
 =?utf-8?Q?q9NQ4rzQn+Rq0NaCoI+br6hMr?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fe5e03dc-f5c0-4adf-600a-08dacdfd48dc
X-MS-Exchange-CrossTenant-AuthSource: AM0PR0402MB3395.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2022 09:21:36.1668
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /zSF9+ccomzLXc/6BbvU0Qgoxl/8mJju3PEWnWSvwr15lvdLUTe7NX7axhanXa8yflKPoF5Gr2vwSE/73dXRaQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8538
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/23/22 16:54, Borislav Petkov wrote:
> On Wed, Nov 23, 2022 at 04:43:20PM +0100, Petr Pavlu wrote:
>> The only post-link analysis tool in this case should be arch/x86/tools/relocs.
>> It produces a vmlinux.relocs file which is appended to vmlinux.bin. This is
>> all internal to the Linux build. I'm not aware of any external tooling, such
>> as kernel debuggers, that would require this relocation information in
>> vmlinux.
> 
> It would be good to know why --emit-relocs was added in the first place
> - that might give us a hint. Lemme talk to Micha.

My understanding is that option --emit-relocs is needed to provide relocation
data for KASLR support. Produced relocation sections in vmlinux get processed
by arch/x86/tools/relocs which creates vmlinux.relocs with only relocation
data. This file is appended to vmlinux.bin. Upon boot, function
extract_kernel() decompresses the kernel at the target address and relocates
it using the vmlinux.relocs data.

>> The size command used in your example includes only allocatable code, data and
>> bss sections. It does not show size of any relocation sections.
> 
> This:
> 
> 361M vmlinux.before
> 361M vmlinux.after
> 
> is simple ls output.
> 
> Maybe I need something else enabled in my .config which would show this
> significant difference *and* *explain* it.

Option CONFIG_RANDOMIZE_BASE=y needs to be enabled. Switching it on should
automatically select also CONFIG_X86_NEED_RELOCS=y which is what actually
enables use of --emit-relocs in arch/x86/Makefile.

Petr