Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 24 Nov 2022 11:10:15 +0000
From:   Sudeep Holla <sudeep.holla@arm.com>
To:     Wang Honghui <honghui.wang@ucas.com.cn>
Cc:     Cristian Maruss <cristian.marussi@arm.com>,
        Jassi Brar <jassisinghbrar@gmail.com>,
        Sudeep Holla <sudeep.holla@arm.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] arm_scpi: modify to support acpi
Message-ID: <20221124111015.vrfuroty4fbemqv7@bogus>
References: <F813BC8072CDDB25+Y38Yq2QKFefSupZV@TP-P15V.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <F813BC8072CDDB25+Y38Yq2QKFefSupZV@TP-P15V.lan>
Precedence: bulk

Hi Wang,

On Thu, Nov 24, 2022 at 03:09:31PM +0800, Wang Honghui wrote:
> arm_scpi: modify to support acpi
>

1. The commit message is pretty useless. I don't get the complete picture
   of why you need this change or what you are trying to do in this change.

2. I am unable to see the series as a whole, just have 2 versions of 3/3
   in my inbox.

3. This is not the correct way to use SCPI or mailbox in ACPI. You need
   to use PCC and PCC OpRegion to achieve what you want. The whole SCPI
   protocol details gets abstracted in the firmware(ACPI ASL)

Hope this helps. So in short, NACK for this approach for ACPI.

-- 
Regards,
Sudeep