Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 24 Nov 2022 11:14:50 +0000
From:   Sudeep Holla <sudeep.holla@arm.com>
To:     Wang Honghui <honghui.wang@ucas.com.cn>
Cc:     Cristian Marussi <cristian.marussi@arm.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 3/3] arm_scpi: Rev last modify to support acpi
Message-ID: <20221124111450.mqfpmatba6f7pap6@bogus>
References: <566DA2F800E4BACA+Y39Ak8xtNJaBqB90@TP-P15V.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <566DA2F800E4BACA+Y39Ak8xtNJaBqB90@TP-P15V.lan>
Precedence: bulk

On Thu, Nov 24, 2022 at 05:59:47PM +0800, Wang Honghui wrote:
> Rev last modify to support acpi
> 
> Signed-off-by: Wang Honghui <honghui.wang@ucas.com.cn>
> ---
>  drivers/firmware/arm_scpi.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/firmware/arm_scpi.c b/drivers/firmware/arm_scpi.c
> index e2e90dcc38bd..aca0a9780c12 100644
> --- a/drivers/firmware/arm_scpi.c
> +++ b/drivers/firmware/arm_scpi.c
> @@ -908,7 +908,9 @@ static const struct of_device_id shmem_of_match[] __maybe_unused = {
>  	{ }
>  };
>  
> +#ifdef CONFIG_PHYTIUM_MBOX
>  extern struct mbox_chan *phytium_mbox_request_channel(struct mbox_client *cl);
> +#endif

I have already NACK the approach you have taken for SCPI + ACPI. Just forgot
to mention SCPI is old and deprecated protocol and SCMI replaced it. You
much be using that if possible.

Anyways, this kind of #ifdeffery is not allowed in any generic code even if
I agreed with the approach. So please don't change the code in such a way.

-- 
Regards,
Sudeep