Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp8746728rwb; Thu, 24 Nov 2022 03:53:45 -0800 (PST) X-Google-Smtp-Source: AA0mqf6yPDT4/pYqAiA1RB+NKw5C9oSpux8Hk3HcYwBjbHjytRr3GYh11O7hfgyPSmdNvddubpMO X-Received: by 2002:a17:90b:3d0b:b0:218:b258:f5b0 with SMTP id pt11-20020a17090b3d0b00b00218b258f5b0mr20051782pjb.119.1669290825275; Thu, 24 Nov 2022 03:53:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669290825; cv=none; d=google.com; s=arc-20160816; b=MMXCpfJzhds2TbasOwWxzqx71w6QtafcW3KEfwBEBvsijekJ3mgW/tss33X40CVrZS +XzhuSU9hcMKlpo3EiBhS9iT7X0GgJlr4GxMa1IXSGjbdXEOJKCwDhF695R3MxW8C/iC zEwXrz03G/FiCNpMk9/nC28BhzrCf0j+g+LDQFOaFsP2kpXBiBuQPBFvSI/6RNJqhOge YcQ9g6tAwrPJ8fnbnFcIH+DkyxOK6sOTFYB/MpUwy7ynygW8Myr1OS8j6jqoHTTVkTP5 bdEvxoz521wvt+qszBMqriwlq0LNdjTeKIvkFQa3vQ96rmzHjOjh4XKOftom+Bwx1Wac X7Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=L81WnKkU3bNHf3UGtFJqhEEJVQcbT58ej7UwgktlVyY=; b=qElXad9WQMPeFxTBbDrxrgyLAAr51kSsyXjzQHxnvIgQ7tEVZ1PEnhZyM9IPQkuzh7 8nGY11+wHrbPGCff94YjgUdXgLpXkj4in5zYkkvSrXr9ingX1pcRzshL0mtnyFHlOurl c2q57D+YF97V2965t6HOSFGzhCRfyPpXSE+tLpz/goE2usG3LMVLXxnMVhRFp3iB9YbX IiouIMt1Pr5aWApF+V5luaqMoLgrW5+3lG7BLK2u/Hs/yu4Qbp2IC2bnI6U9fVglVZVP bWrPCQ6rc4RAsFVcYgpnLgWay7rPy/tx+59E9mAUu4ATRfUjlX8O/95iRbZ0noQOQOkr ktUg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=MOQZ2rsL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r1-20020a632b01000000b0046b014d12d8si1058457pgr.492.2022.11.24.03.53.33; Thu, 24 Nov 2022 03:53:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=MOQZ2rsL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229994AbiKXLOb (ORCPT + 86 others); Thu, 24 Nov 2022 06:14:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230003AbiKXLO0 (ORCPT ); Thu, 24 Nov 2022 06:14:26 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66CC41448DB for ; Thu, 24 Nov 2022 03:14:24 -0800 (PST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 25CA921AA9; Thu, 24 Nov 2022 11:14:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1669288463; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L81WnKkU3bNHf3UGtFJqhEEJVQcbT58ej7UwgktlVyY=; b=MOQZ2rsL9atGwvoT9sXYfTB+ApEBrx/IqNMLLUQ1Htsi5baOSkPHNQHxmYYX41hRQRIRDx wBc0+7D77B/S2IiGOUndz+9zJMgx7TiTQT47WUGgqaRRhLelH64kQsvx6wojwKe+DDX+rX 4ESeyVK3ZXLW1XslxKmV2Qi819EGZqs= Received: from suse.cz (unknown [10.100.208.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 028B32C141; Thu, 24 Nov 2022 11:14:22 +0000 (UTC) Date: Thu, 24 Nov 2022 12:14:22 +0100 From: Petr Mladek To: John Ogness Cc: Sergey Senozhatsky , Steven Rostedt , Thomas Gleixner , linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH printk v2 2/7] console: Use BIT() macros for @flags values Message-ID: References: <20221123231400.614679-1-john.ogness@linutronix.de> <20221123231400.614679-3-john.ogness@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221123231400.614679-3-john.ogness@linutronix.de> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 2022-11-24 00:19:55, John Ogness wrote: > From: Thomas Gleixner > > Rather than manually calculating powers of 2, use the BIT() macros. > Also take this opportunatity to cleanup and restructure the value > comments into proper kerneldoc comments. > > Signed-off-by: Thomas Gleixner > Signed-off-by: John Ogness This is really useful. Reviewed-by: Petr Mladek Best Regards, Petr