Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7761d66c-a8a7-c11a-9c09-a47f57bd1311@kontron.de>
Date:   Thu, 24 Nov 2022 12:07:33 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH] drm/bridge: ti-sn65dsi83: Fix delay after reset deassert
 to match spec
Content-Language: en-US
To:     Alexander Stein <alexander.stein@ew.tq-group.com>,
        Andrzej Hajda <andrzej.hajda@intel.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        David Airlie <airlied@gmail.com>,
        dri-devel@lists.freedesktop.org,
        Linus Walleij <linus.walleij@linaro.org>,
        linux-kernel@vger.kernel.org, Marek Vasut <marex@denx.de>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Robert Foss <robert.foss@linaro.org>,
        Frieder Schrempf <frieder@fris.de>
Cc:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        =?UTF-8?B?Sm9zw6kgRXhww7NzaXRv?= <jose.exposito89@gmail.com>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Sam Ravnborg <sam@ravnborg.org>,
        =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= <ville.syrjala@linux.intel.com>
References: <20221122081219.20143-1-frieder@fris.de>
 <9079928.rMLUfLXkoz@steina-w>
From:   Frieder Schrempf <frieder.schrempf@kontron.de>
In-Reply-To: <9079928.rMLUfLXkoz@steina-w>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TlBueWhudUNYa1l0cmtIbkVGcm5VM1grTHdWUWMrM1U3MURML3FhYlkyeXIy?=
 =?utf-8?B?Z1RzeGJNZHpqaUJXdDd2VnUwL0ZCeDU4aHBVMVd1djdkNjB3Tkl4dHg1L081?=
 =?utf-8?B?ZitNWG0zdE1FaDdTUmpPUFFKcE9ZR2ROQlU4aDBGeDY5V2J2SW9sRnRZbGU4?=
 =?utf-8?B?Y2Rna1ZJQ2Q4MXpCZWpNU3ZIZndSTS9NWnhjU1pJTGI2SittVllnTkIyajhz?=
 =?utf-8?B?ZG01YkdIVmowTjBucURzMis2dlhUbGlOUm9MdmZrMmo5ZlM5MEk1YXU0amZB?=
 =?utf-8?B?M3RWNVhQT2tsQTM4dHIrK1Viais1TXVrSis3ZFFaUE0raGV3K2dRSWZXcXVP?=
 =?utf-8?B?K0VFNDErcGJDekFlSnh3Wk9NVXdycmR4MTQzMXdBeVhwZlJyeVNoWmErM2lX?=
 =?utf-8?B?VjhadG9DK0ZpRHAvczljeGFja2hpZVplVlNscTM0Y1FEa2JSNTBUQ05NZHVZ?=
 =?utf-8?B?YmtJeHBIV1BuOUFkeklIdElKQVNabGhYdkc3UStVK0pJVEp3aTlXQUxFOWRk?=
 =?utf-8?B?OU1aVlhycGpoTTlZT2VZb04vQlNsSUwxUTh4eVhzdVdaUEY4VFZZS3BBM0o4?=
 =?utf-8?B?eHozRGsxY01PelRGV1NsbXlUQlRCblNXSDlkZE14YVVKY0JVbWRSZ1R2UCtQ?=
 =?utf-8?B?MzVoQjFpTjJNaWd3R21ISjdLVE9aOE5CdGZ4NnBGalJ1VDQ1MU5BRDJXZDZ5?=
 =?utf-8?B?TXc0TWlleTFrUDNUSU5UZHVoa0FsMGZxd3VTSndCZHBJd0hIaTJtN2FHbVpn?=
 =?utf-8?B?dDJMVEF3RmJNU3VlNXdqSGdsdzRhMDBkdnVlRThPTjhQU091SUZZT3FNeTFV?=
 =?utf-8?B?V00rd01HTFVoc0JXb0VDcUJ3dnBQZ05OL2t5TzF5M2dpbGhLMXlPWnlySFFN?=
 =?utf-8?B?emF6NDI3dy9idjZUU1p6aHd1YjRUaFVzdGh6TTJpWS9DejZ6TDhvbWlvWjJj?=
 =?utf-8?B?Z3Z4N2l4KytaVzZtdXBBNzFxWXF4Mk1WZzFLTDZSVVgybkJwaDNEN3g0R044?=
 =?utf-8?B?M1gra0NydFU4a21IWi93bFZTT3FPWVk4cU14b3llWEpMVnErUEwvRVZRVHl3?=
 =?utf-8?B?aGwxNHh0NHp5MWRWRTE0QThQZkdqazFmU1hnNG9yVU9VLzZJakN4d0x6UTlM?=
 =?utf-8?B?aHVheVpYd0dRL1VrR1NIZWNNYjZIckpiYWxnK0pTYWFVMHlQSzNlREVINUNw?=
 =?utf-8?B?UU5QcElQR1J3Q1d3R2ZBdzF1WDEvS2I2dU9OS3A2TWdrUnVQdDkvSFdGbGtH?=
 =?utf-8?B?YmVka3BCbWdYVGFSS0lsdXVOUHFVdkJTTjJmc3B1S203cXV1TWVqZ1g5OWVO?=
 =?utf-8?B?Q1BDV1NYOHNIbW93U28xVXNhU0Y4UXpQZlF4VEMzT281RTMyODc5TDBQUHVJ?=
 =?utf-8?B?UlFWSldtaXhKbVB6TVR5Qm9LamNyZnZBcXJDcnREanFGUmE1S3BNSjJSNjRZ?=
 =?utf-8?B?aGcxd3ZPQnFSSy9vaEdzZDNKME5uK25nYy9Wc2svUjRiNXUzRloxK3RZb053?=
 =?utf-8?B?VVgyNi9Vd1lVd0VXK1FqUFk0Z2Q5SjFVZ08rSzNXYkp5R3N6TGd0cEMzY29m?=
 =?utf-8?B?U3FYYmtlYWk0ZWd5LzdUR2orenpFa1ZIT1I0b05xRG9BcDhSdDcyWDBmVEVj?=
 =?utf-8?B?YS9Zb0Z1bmRpVk5GYzJ2WmdPaStSbXFDRlhWeDh6Y212TnJ6aU9Mc0kwbzN1?=
 =?utf-8?B?eW82Rmx4aTRKMTJJaWVSUjcrSVFLdWtVa3RRQmFYcDVWWGVrRm51WnZqRUVM?=
 =?utf-8?B?TjREOTlDKytlS1Z5OXpvdWhoaUE4bjNzSUdlVVRCN1RWSDh4M00wMlFsZ1E5?=
 =?utf-8?B?cmdvTDhRZ3ptdjVoWk9iL0hIdTZtd291YjNZMW1BUDVjSjhaRGZDUXllUnhQ?=
 =?utf-8?B?ODhIVG53N1RQNit3aGRuQnBpa1poNU9QZmFSMytBUDZEU0Q1aUtYbjFxbzZj?=
 =?utf-8?B?NGtDdDdtOEQwYzBzQVVPaTJ0MFRTM21DanJic1B2VDFuZDRObmxVZVl0eXhZ?=
 =?utf-8?B?UDVIRG40V3lKTmF0Z202eXFEVFA3MHFQSlVKaHcyMHh5U2NvRVBhSHR4YW1x?=
 =?utf-8?B?NVd5U1RSN0tkb1NweUtIbFhqZlhZT0FvZ3ErbHp0MEVSNys1aEYzQmdaSmJH?=
 =?utf-8?B?VGxuRTBiNzVucnB6aDFFcHFKQVFTMFlsby9XdXcxR1BRS01pVmhadzYyRGhV?=
 =?utf-8?Q?+lnwdj0Ag7RgUrRG1l9hHnLdAgnbGeA6JxVU/Dtd+Vf2?=
X-OriginatorOrg: kontron.de
X-MS-Exchange-CrossTenant-Network-Message-Id: ba3ca9bc-9b96-4d99-6df6-08dace0c17c4
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2022 11:07:36.1118
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: P7RgX/UHvTaUWmPx/CiwiCMi00MzrXoqj+n0XzVeJQ38xqVUBHDDjTPmcKs6W64urlryyWPWnSnAaAGT+Fmcrcl9uoaCMW0TvijOXO9f91Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR10MB5394
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 24.11.22 12:00, Alexander Stein wrote:
> Am Dienstag, 22. November 2022, 09:12:18 CET schrieb Frieder Schrempf:
>> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>>
>> The datasheet specifies a delay of 10 milliseconds, but the current
>> driver only waits for 1 ms. Fix this to make sure the initialization
>> sequence meets the spec.
>>
>> Fixes: ceb515ba29ba ("drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and
>> SN65DSI84 driver") Signed-off-by: Frieder Schrempf
>> <frieder.schrempf@kontron.de>
>> ---
>>  drivers/gpu/drm/bridge/ti-sn65dsi83.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c
>> b/drivers/gpu/drm/bridge/ti-sn65dsi83.c index 7ba9467fff12..047c14ddbbf1
>> 100644
>> --- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c
>> +++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
>> @@ -346,7 +346,7 @@ static void sn65dsi83_atomic_enable(struct drm_bridge
>> *bridge,
>>
>>  	/* Deassert reset */
>>  	gpiod_set_value_cansleep(ctx->enable_gpio, 1);
>> -	usleep_range(1000, 1100);
>> +	usleep_range(10000, 11000);
>>
>>  	/* Get the LVDS format from the bridge state. */
>>  	bridge_state = drm_atomic_get_new_bridge_state(state, bridge);
> 
> How about using fsleep?
> 
> Either way:
> Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com>

Thanks for the review! I didn't know about fsleep. Anyway this would
probably be a separate change as the driver currently uses usleep
everywhere else. But I will keep it in mind for the future.