Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 24 Nov 2022 12:31:24 +0100
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Masahiro Yamada <masahiroy@kernel.org>
Cc:     Alexander Lobakin <alobakin@pm.me>, linux-kbuild@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 12/18] mtd: tests: fix object shared between several
 modules
Message-ID: <20221124123124.2e46ed23@xps-13>
In-Reply-To: <20221123175900.4e05a0f2@xps-13>
References: <20221119225650.1044591-1-alobakin@pm.me>
        <20221119225650.1044591-13-alobakin@pm.me>
        <CAK7LNASni5uNFOtR-6VykBHX1Wgg-rOt=q0Lk+H2Vbn7pCsBDQ@mail.gmail.com>
        <20221123175900.4e05a0f2@xps-13>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hello,

Reducing the Cc list.

miquel.raynal@bootlin.com wrote on Wed, 23 Nov 2022 17:59:00 +0100:

> Hi,
>=20
> masahiroy@kernel.org wrote on Wed, 23 Nov 2022 22:11:49 +0900:
>=20
> > On Sun, Nov 20, 2022 at 8:08 AM Alexander Lobakin <alobakin@pm.me> wrot=
e: =20
> > >
> > > mtd_test.o is linked to 8(!) different test modules:
> > >   =20
> > > > scripts/Makefile.build:252: ./drivers/mtd/tests/Makefile: mtd_test.o
> > > > is added to multiple modules: mtd_nandbiterrs mtd_oobtest mtd_paget=
est
> > > > mtd_readtest mtd_speedtest mtd_stresstest mtd_subpagetest mtd_tortu=
retest   =20
> > >
> > > Although all of them share one Kconfig option
> > > (CONFIG_MTD_TESTS), it's better to not link one object file into
> > > several modules (and/or vmlinux).
> > > Under certain circumstances, such can lead to the situation fixed by
> > > commit 637a642f5ca5 ("zstd: Fixing mixed module-builtin objects").
> > > In this particular case, there's also no need to duplicate the very
> > > same object code 8 times.
> > >
> > > Convert mtd_test.o to a standalone module which will export its
> > > functions to the rest.
> > >
> > > Fixes: a995c792280d ("mtd: tests: rename sources in order to link a h=
elper object")
> > > Suggested-by: Masahiro Yamada <masahiroy@kernel.org>   =20
> >=20
> > IMHO, Reported-by might be a better fit.
> >=20
> >=20
> > I think they can become static inline functions in mtd_test.h
> > (at least, mtdtest_relax() is a static inline there), but I am not sure.
> >=20
> > Please send this to the MTD list, and consult the maintainer(s). =20
>=20
> TBH I don't really mind. These are test modules that you insert to
> harden and profile the stack, so whatever makes the robots happy is
> fine. Anyway, they are being slowly replaced by userspace tools so we
> might eventually get rid of them.

Once you feel ready, if you want this to be merged through the mtd
tree, you can resend with the linux-mtd ML in Cc, otherwise if falls out
of the scope of the tools and it's a pain to collect.

Thanks,
Miqu=C3=A8l