Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp8760939rwb; Thu, 24 Nov 2022 04:04:34 -0800 (PST) X-Google-Smtp-Source: AA0mqf7XfsPYJ3nMnqLRicA0gv1xaxOT5kwDIBZJ5n4wCoK411bnCJl2SoXnavyQFlUTZcMg5X5m X-Received: by 2002:aa7:c751:0:b0:469:3eb0:51c2 with SMTP id c17-20020aa7c751000000b004693eb051c2mr23307377eds.141.1669291473893; Thu, 24 Nov 2022 04:04:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669291473; cv=none; d=google.com; s=arc-20160816; b=NQeVpPDKoXcsZDmwSr+DEYFMGNXPT1s1E6F9mY53WTItCxlafDPWo5Vw3HCVskyTlP CGKaK8QQApQcVyP4c/0kBEQZE4K9FWCxoYvxEnRVqnWCwdjIY9ZvH6gvOfJO/069nfv3 9w5DIOwqKaI2FNyhx+dayvp9n4BeTNY1TEoy+CE8RXI5kuTztkqptukqkhN0bcc7m7ZN ADTay3uQh3Siz3oEFMVs1SitM+ypK5OnTW456LVzkD5BO/iWSn4wtO8JTB8RTGQHSzOH IB7ihLG18RFrm7pcokSG+eJOJgrTW+3ZdvRu2C7mi42GuAp0TqO1xHU72X2FzTtW2MA/ f6Sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=8SgUK8+C+P84jnn4mPFsvd+MDz8e0Zg/WY7xfiup5DA=; b=QXWGBrwDIbrRxpaOEcapvzRKeAAvFVxwiewdbtd4edIDQwhw3A1nXmniFFT6mXDssz QMId00F5elO4LeRKfKFdyhkHJ3qaZDar3kaxhSbDXvWOvoOMbBsLaHNNjfUlgVFXpgwH SPT4K5y5uYTCKUDkcrTv1G9Kihw1hf0lfhBc0L0vI/HtCg2bms1oeZd22ELLjrHyn2nx +0w/dI1w/0r7JrT7EK4Jy+W41Fku+KiaabruONQgEULsDK2n9GMb9aQ5Pn8bHae7K0N4 iIrlhQnnZUNlJQCJSj8lrlHJ06dcxYYsaW18IzRd5ETYFixeyw0hWv+szQrraByGLirO VAKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@timesys-com.20210112.gappssmtp.com header.s=20210112 header.b=4M0mnp20; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id wu9-20020a170906eec900b00791910ecd0fsi809604ejb.540.2022.11.24.04.04.07; Thu, 24 Nov 2022 04:04:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@timesys-com.20210112.gappssmtp.com header.s=20210112 header.b=4M0mnp20; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230011AbiKXLrU (ORCPT + 88 others); Thu, 24 Nov 2022 06:47:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229500AbiKXLrR (ORCPT ); Thu, 24 Nov 2022 06:47:17 -0500 Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DEADAEBF3 for ; Thu, 24 Nov 2022 03:47:16 -0800 (PST) Received: by mail-qt1-x82f.google.com with SMTP id l2so880116qtq.11 for ; Thu, 24 Nov 2022 03:47:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=timesys-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8SgUK8+C+P84jnn4mPFsvd+MDz8e0Zg/WY7xfiup5DA=; b=4M0mnp20F24FRahiYaJ82l4gm6RfSBmCpRU6BnbrYq+suNgie3rrWTOP9t3Hz06wdq 8JuZpvNwf+mEp+N11n21A9wexXOf2Q/zqQEKRl6IBbAXBVrbvhIY0xybi6kuMGVgrOGG WesrgNT6wsqt/yHaUTH1D5zRMHxpfduYcvELm49lfsOOqHq8MW/bCjz9PYJrvbmrRm2g jjC41Qgo42fGVoxS/FIUSxG/QlLuT9nqcPip8ewKXTB7FhgyG3/BN4dlEB3sc2LHDU2f DzgtNY5TSyFsX9hpgDOxYJFpkc7IOQteQJDtshzH8Bo0fqxig3IwFwSLFvKb6BwGsMyk /PkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8SgUK8+C+P84jnn4mPFsvd+MDz8e0Zg/WY7xfiup5DA=; b=wYRPe6VYcbwtcXMrj2EKMp+qoCfCBFknPiXczPTX80kLtrX8dERzthoDWfUXk4tPe5 VgTP9I6xerciYoNzuj511jIpb9mE54HS+rCfOd/hejU7ntmoMbS9XOlg1mHzjROdseZg fycvsB1vDKdRH/lBLS0L7iYe1hyN5CjOgc+gErQlg/kr4C/KEYiH3gReA4nv8GhUbN3v mGqRPYRQhgLPECU9bHSD13yIiwPIrQcdKQhr+eCKrMTXQ3mHn+yyqquO6b4Aj0HD4PgA tWlSxntx6LOHYSpUeg0u+qcojMsFvihG1UEroNFrq49qiwzMvX0f5Wa5oKy5hGF16ir9 qJQA== X-Gm-Message-State: ANoB5pmB3vATevFxrKc//Ql+sKouS5ZCRMZXKZx9Dt+owxiGvLmI0O4x 6UZYgHle+OF2q72ZGAvht4e4aRw/+EReTx2K X-Received: by 2002:ac8:4e37:0:b0:3a4:f140:f707 with SMTP id d23-20020ac84e37000000b003a4f140f707mr16043854qtw.317.1669290435194; Thu, 24 Nov 2022 03:47:15 -0800 (PST) Received: from nathan-ideapad.. (d-75-76-18-234.oh.cpe.breezeline.net. [75.76.18.234]) by smtp.gmail.com with ESMTPSA id bq10-20020a05622a1c0a00b003a582090530sm454146qtb.83.2022.11.24.03.47.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Nov 2022 03:47:14 -0800 (PST) From: Nathan Barrett-Morrison To: michael@walle.cc Cc: greg.malysa@timesys.com, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com, nathan.morrison@timesys.com, pratyush@kernel.org, richard@nod.at, tudor.ambarus@microchip.com, vigneshr@ti.com Subject: RE: [PATCH 0/2] These are the required patches I found while adding Date: Thu, 24 Nov 2022 06:47:13 -0500 Message-Id: <20221124114713.132514-1-nathan.morrison@timesys.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Michael, Ah yes, I just realized we're effectively using the device in 1S-1S-8S extended SPI mode, so the 0xC7 setting is probably not required. We were never able to get DTR mode working on the IS25LX256. I can fix this patch up so it's more explicit about what's going on here. The 8S-8S-8S support in core.c is still going to be used for another OSPI device I'm porting over from an older kernel. Would you like me to separate these patches, fix up the ISSI once, and resubmit? Sincerely, Nathan