Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Alim Akhtar" <alim.akhtar@samsung.com>
To:     "'Aakarsh Jain'" <aakarsh.jain@samsung.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <devicetree@vger.kernel.org>
Cc:     <m.szyprowski@samsung.com>, <andrzej.hajda@intel.com>,
        <mchehab@kernel.org>, <hverkuil-cisco@xs4all.nl>,
        <ezequiel@vanguardiasur.com.ar>, <jernej.skrabec@gmail.com>,
        <benjamin.gaignard@collabora.com>,
        <krzysztof.kozlowski+dt@linaro.org>,
        <stanimir.varbanov@linaro.org>, <dillon.minfei@gmail.com>,
        <david.plowman@raspberrypi.com>, <mark.rutland@arm.com>,
        <robh+dt@kernel.org>, <krzk+dt@kernel.org>, <andi@etezian.org>,
        <aswani.reddy@samsung.com>, <pankaj.dubey@samsung.com>,
        <smitha.t@samsung.com>
In-Reply-To: <20221114115024.69591-3-aakarsh.jain@samsung.com>
Subject: RE: [Patch v5 2/3] media: s5p-mfc: Add variant data for MFC v7
 hardware for Exynos 3250 SoC
Date:   Thu, 24 Nov 2022 17:13:02 +0530
Message-ID: <001401d8fff9$eb9c53a0$c2d4fae0$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Language: en-us
Thread-Index: AQEWRgxeWB9GQv2mDJaVZC8m4WNgiwKNLU9SAqiIKIGvqbmjcA==
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <20221114115024.69591-1-aakarsh.jain@samsung.com>
        <CGME20221114114409epcas5p32057f807dd538f874f8fd4a940c9de00@epcas5p3.samsung.com>
        <20221114115024.69591-3-aakarsh.jain@samsung.com>
Precedence: bulk


>-----Original Message-----
>From: Aakarsh Jain =5Bmailto:aakarsh.jain=40samsung.com=5D
>Sent: Monday, November 14, 2022 5:20 PM
>To: linux-arm-kernel=40lists.infradead.org; linux-media=40vger.kernel.org;=
 linux-
>kernel=40vger.kernel.org; devicetree=40vger.kernel.org
>Cc: m.szyprowski=40samsung.com; andrzej.hajda=40intel.com;
>mchehab=40kernel.org; hverkuil-cisco=40xs4all.nl;
>ezequiel=40vanguardiasur.com.ar; jernej.skrabec=40gmail.com;
>benjamin.gaignard=40collabora.com; krzysztof.kozlowski+dt=40linaro.org;
>stanimir.varbanov=40linaro.org; dillon.minfei=40gmail.com;
>david.plowman=40raspberrypi.com; mark.rutland=40arm.com;
>robh+dt=40kernel.org; krzk+dt=40kernel.org; andi=40etezian.org;
>alim.akhtar=40samsung.com; aswani.reddy=40samsung.com;
>pankaj.dubey=40samsung.com; smitha.t=40samsung.com;
>aakarsh.jain=40samsung.com
>Subject: =5BPatch v5 2/3=5D media: s5p-mfc: Add variant data for MFC v7 ha=
rdware
>for Exynos 3250 SoC
>
>Commit 5441e9dafdfc6dc40 (=22=5Bmedia=5D s5p-mfc: Core support for MFC v7=
=22)
>which adds mfc v7 support for Exynos3250 and use the same compatible strin=
g
>as used by Exynos5240 but both the IPs are a bit different in terms of IP =
clock.
>Add variant driver data based on the new compatible string
>=22samsung,exynos3250-mfc=22 for Exynos3250 SoC.
>
>Suggested-by: Alim Akhtar <alim.akhtar=40samsung.com>
>Fixes: 5441e9dafdfc (=22=5Bmedia=5D s5p-mfc: Core support for MFC v7=22)
>Signed-off-by: Aakarsh Jain <aakarsh.jain=40samsung.com>
>---
Thanks=21

Reviewed-by: Alim Akhtar <alim.akhtar=40samsung.com>

> .../media/platform/samsung/s5p-mfc/s5p_mfc.c    =7C 17 +++++++++++++++--
> 1 file changed, 15 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c
>b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c
>index fca5c6405eec..007c7dbee037 100644
>--- a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c
>+++ b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c
>=40=40 -1576,8 +1576,18 =40=40 static struct s5p_mfc_variant mfc_drvdata_v=
7 =3D =7B
> 	.port_num	=3D MFC_NUM_PORTS_V7,
> 	.buf_size	=3D &buf_size_v7,
> 	.fw_name=5B0=5D     =3D =22s5p-mfc-v7.fw=22,
>-	.clk_names	=3D =7B=22mfc=22, =22sclk_mfc=22=7D,
>-	.num_clocks	=3D 2,
>+	.clk_names	=3D =7B=22mfc=22=7D,
>+	.num_clocks	=3D 1,
>+=7D;
>+
>+static struct s5p_mfc_variant mfc_drvdata_v7_3250 =3D =7B
>+	.version        =3D MFC_VERSION_V7,
>+	.version_bit    =3D MFC_V7_BIT,
>+	.port_num       =3D MFC_NUM_PORTS_V7,
>+	.buf_size       =3D &buf_size_v7,
>+	.fw_name=5B0=5D     =3D =22s5p-mfc-v7.fw=22,
>+	.clk_names      =3D =7B=22mfc=22, =22sclk_mfc=22=7D,
>+	.num_clocks     =3D 2,
> =7D;
>
> static struct s5p_mfc_buf_size_v6 mfc_buf_size_v8 =3D =7B =40=40 -1647,6 =
+1657,9
>=40=40 static const struct of_device_id exynos_mfc_match=5B=5D =3D =7B
> 	=7D, =7B
> 		.compatible =3D =22samsung,mfc-v7=22,
> 		.data =3D &mfc_drvdata_v7,
>+	=7D, =7B
>+		.compatible =3D =22samsung,exynos3250-mfc=22,
>+		.data =3D &mfc_drvdata_v7_3250,
> 	=7D, =7B
> 		.compatible =3D =22samsung,mfc-v8=22,
> 		.data =3D &mfc_drvdata_v8,
>--
>2.17.1