Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp8765050rwb; Thu, 24 Nov 2022 04:07:08 -0800 (PST) X-Google-Smtp-Source: AA0mqf4R2xcg2JbMC76jgGuXT6rY59eOfbYBPQQqmW8M/qS1K0TyHM/vHaVoHeKqF2v59e8AP66O X-Received: by 2002:a17:907:8d03:b0:7ae:1d34:4da5 with SMTP id tc3-20020a1709078d0300b007ae1d344da5mr23652008ejc.340.1669291628715; Thu, 24 Nov 2022 04:07:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669291628; cv=none; d=google.com; s=arc-20160816; b=l8j3j3Qx1+KG/Jxg8YaGQQEZtoqWutNOfIYtlKk8KLaKTsf5c5zP0z971li64KPqWS tB8NY1H/nLK8E+Ao94lz9rQKtO8Wlsm+hRYIBNJXVvkQ2LDXmgauHInxV4yqtxzbCRUf Bu4a8Ot+Y4ap2lVRMCDelzO39u/npHv8gJ0lRMGpLQLC6zmB7ONe8SmH6vZxTC8G/bC2 S0MHsTit0CZ/YMXO9HopQtQm3WWKiWJXe/QbEpqlHQGOyyrMg+5+oGHd8v3F6B+syFRR mv717gxrkvnHdScoCGUZudESKfeD1IjQ2pGmQegJTLXPC8Lpc1xjXyq28JtDitM8MR/u Pi8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=Vr8bKLhT8q0qJhXyoRNU+MZCNNRnvBRG3Flc0FO22Po=; b=0W2aBMSFmXOowHLCdqV5m5VTusonCg69AN+EyhgbsY8fWSqySzouwe4f8NvxQlF3NW 2+8tqWaW6nUNdrUCXQnGFqqM4Vb0rFxL9iKlmEhJuadWjfuGQVFYcjotIUEQ8O+YSveR djvOjwne7iaqslDYzIHg1JW5WCJIA6ZO/+TsEkPZsk1GFkyfg8DjM01msV/5yzZwFelc b52vqB0YVxomwmJk56GDD6v8nQfBnwQ5kU2GUvH6VNOK80JLAt9YogEr+//NYcisdYiN nMakGGd3Fyt6lg25+2KFwZ/4TndaJGp77bG+TbTCQW5PRbKPi7hUXdb4yVT5wXr27dsH 3PLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=lIYedw9P; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dp21-20020a170906c15500b0077ea290986fsi778097ejc.584.2022.11.24.04.06.47; Thu, 24 Nov 2022 04:07:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=lIYedw9P; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230195AbiKXLgP (ORCPT + 86 others); Thu, 24 Nov 2022 06:36:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230177AbiKXLgM (ORCPT ); Thu, 24 Nov 2022 06:36:12 -0500 Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [217.70.178.231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C31DF976DF for ; Thu, 24 Nov 2022 03:36:09 -0800 (PST) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 7400C100002; Thu, 24 Nov 2022 11:36:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1669289768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Vr8bKLhT8q0qJhXyoRNU+MZCNNRnvBRG3Flc0FO22Po=; b=lIYedw9PzsJwyvr2iLyIsekayL8TQ9T7L8ilsyaYrh1OsGq8eO54sQ1lBO+Jp1ZMt/T7jV gLH9o4goJJUBju+rZX1LeewHujdewqrR47jXQgE0HDn4NW4gxmMn50RkVp/ma3I+Vw0VjF 4iV1w8xkpmoD3RrCjI9X2HvCxQWoTljEP8y/NiV3m6oQkvIggCc9SnN7GF1ssm5O6jUQ6u nbjO8/6C7LLf9enTjYFIDeyPW4O0QhnRnNm/xTH3UEssY0+oglMkXU/DuNgPegZM2tESVV cXAIDFJOuGuwfOQMlZvEa5VfPSVUjdTDLFLleeA8ygsI8AOOzUogEN/yDhF0yw== From: Miquel Raynal To: Zheng Yongjun , miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: fix memory leak in pxa2xx_flash_probe() Date: Thu, 24 Nov 2022 12:36:06 +0100 Message-Id: <20221124113606.266257-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221119073307.22929-1-zhengyongjun3@huawei.com> References: MIME-Version: 1.0 X-linux-mtd-patch-notification: thanks X-linux-mtd-patch-commit: b'2399401feee27c639addc5b7e6ba519d3ca341bf' Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2022-11-19 at 07:33:07 UTC, Zheng Yongjun wrote: > If '!info->map.virt' or '!info->mtd' success, 'info' should be > freed before return. Otherwise there is a memory leak. > > Fixes: e644f7d62894 ("[MTD] MAPS: Merge Lubbock and Mainstone drivers into common PXA2xx driver") > Signed-off-by: Zheng Yongjun Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks. Miquel