Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp8950880rwb; Thu, 24 Nov 2022 06:19:05 -0800 (PST) X-Google-Smtp-Source: AA0mqf6cnQaTsavJG3f9vNM3bqGDidy6E/ke/xelONhdzpgYg+L/q5RQ6YA5pbMgRNmfQCqcXKsR X-Received: by 2002:a05:6a00:198d:b0:569:92fa:cbbc with SMTP id d13-20020a056a00198d00b0056992facbbcmr14166239pfl.77.1669299545665; Thu, 24 Nov 2022 06:19:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669299545; cv=none; d=google.com; s=arc-20160816; b=eydCO7wmCvgJClVwhN4psQsR7TNiQ7hBSeTBNDtOAZlHVT3i0j1Zpuczjn5NzZfyiw dXjX5BbL+i/+wTsouZ2pAL33dGZx6EvqktWngECeD11vv5pSb9eV7nUfgAkLVLZIacwE BmG5b4njWD2sUQV0p2CcPl0jJDYIUQMdgzdrmrDhH81Nxv3YeT8+mUv0nHKOVmNXuyOW ojB5HGbvlrLVUnt6tOaW/nnAAkjsfx5VtZ4FMhtHtJmikhrHlkN/T5d96iUIYp2MPC8a DtMQKO6Xvli+ODa7OmGcwbNE+0SnbY8Q92YNRBLwaw/agWZc0AUFHWkjxnJOzTnC6dRd d81A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=VkflUhit7OoN55ql8xALxypH6TKph++jYyEKyALoOoY=; b=UG6mQoPwL9hnQSixVSBxb6oKe4rjNN+O8b1I2KArR9b0/nIDKN8dqXrTkmM6D+I+ZF t3wDtEji1q/0Ymdcn6fhc5doaY8HZHZk3v7ck8Ho01EtALDYE3VLZln2zw9qWSKsS956 kF+GrQske6JRF74z/5I4oLRQdNi05jU8QJKc1qCWFuJ36QA07AecISqUUwCC32Y+CyNJ dfIsA8QSDRzdJtKVfaYmC6kkUa7l2wcx577tS3VqhP+3ZZbIB7pECZAOV3LBCK0AW1RU mvsqb34b4RcvOQ3XMbMhNJQyKOgv6U03QpI7BBVnryoJ8MJzN2+zCVfb8uaxwYroXCf6 DKXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=J20zac+m; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g14-20020a056a001a0e00b00565c337c562si1247198pfv.100.2022.11.24.06.18.53; Thu, 24 Nov 2022 06:19:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=J20zac+m; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230101AbiKXOAz (ORCPT + 86 others); Thu, 24 Nov 2022 09:00:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230324AbiKXOAb (ORCPT ); Thu, 24 Nov 2022 09:00:31 -0500 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78EB3132F6C for ; Thu, 24 Nov 2022 05:58:31 -0800 (PST) Received: by mail-pj1-x1034.google.com with SMTP id v3-20020a17090ac90300b00218441ac0f6so5882102pjt.0 for ; Thu, 24 Nov 2022 05:58:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VkflUhit7OoN55ql8xALxypH6TKph++jYyEKyALoOoY=; b=J20zac+mHU3mT4CWCx1AjwUMnLnD1d9/PwdlU+LMJFMTVyuzUuqI1bBakJWId7mdIs AF6cMXHqA0n8mio9knEYOBEii6DRbZZ77dfA/LVwzQL8jGISVtsdI3WtpVL4ONiUaNJL 650k0DzrbPv9U1C/0xoSszESmPSQFPpxGKoVsMyL04SyWDhQ3eRQcxVy9xwgmn6IHxV8 S9wbFf2IQmmnX3Uqy3CDTd+tVZYhBe2BvL4cBVIFm35jQYovkmQBvW2VEO7Wn9bFCw2J pm3fwpwWXX9yUirCLqiVe4EGkT25OaUTUStTPk62opbMwry97FdzeHK4fx12VaYj2pzi AzIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VkflUhit7OoN55ql8xALxypH6TKph++jYyEKyALoOoY=; b=4/cXiPtDflBRCqGHstX/BPAJzK0MLpNzqu0M4EcTQZjRJEdd+sra1XFBzkUrtEhwWC c1Q9qnJWnMZJvmgb8+LnTohgx9e43MJyrumBiA6mX2CTIxboZb38MXEpvuQcv+GG7zwk BYBAkwblDgtVeqe+129sKdSCkVci5815MENxtWwmGMLfVJT6f9U5YkT/s0kCFXalc+j9 LsCbCClLorZF2POAjz0OgLzzGFVt/Enjm38HcR1Mka8sXxjOityCexBfTDAsdGOXNcZD 66xpet4DjBUe/zyZtHf4Tcj6FrBziZPMdAOPm7R8pYkB7FfITg63hR8Ybd1WWSVJ9UBt p0jg== X-Gm-Message-State: ANoB5pm4lRr21jyf+e3go0E2OWdccbeaTwjiP6fpShg6KJdtfzK6Jly/ Q4yJeXQyn56Hgng9aMQIwF9W3A== X-Received: by 2002:a17:90a:ba97:b0:218:f5df:5cf1 with SMTP id t23-20020a17090aba9700b00218f5df5cf1mr5518212pjr.79.1669298310242; Thu, 24 Nov 2022 05:58:30 -0800 (PST) Received: from [127.0.0.1] (cpe-72-132-29-68.dc.res.rr.com. [72.132.29.68]) by smtp.gmail.com with ESMTPSA id a28-20020aa795bc000000b00560cdb3784bsm1250769pfk.60.2022.11.24.05.58.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Nov 2022 05:58:29 -0800 (PST) From: Jens Axboe To: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Ye Bin Cc: ming.lei@redhat.com, syzbot+746a4eece09f86bc39d7@syzkaller.appspotmail.com, Ye Bin In-Reply-To: <20221107033956.3276891-1-yebin@huaweicloud.com> References: <20221107033956.3276891-1-yebin@huaweicloud.com> Subject: Re: [PATCH] block: fix crash in 'blk_mq_elv_switch_none' Message-Id: <166929830905.100836.12987821454081099289.b4-ty@kernel.dk> Date: Thu, 24 Nov 2022 06:58:29 -0700 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailer: b4 0.11.0-dev-28747 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 7 Nov 2022 11:39:56 +0800, Ye Bin wrote: > From: Ye Bin > > Syzbot found the following issue: > general protection fault, probably for non-canonical address 0xdffffc000000001d: 0000 [#1] PREEMPT SMP KASAN > KASAN: null-ptr-deref in range [0x00000000000000e8-0x00000000000000ef] > CPU: 0 PID: 5234 Comm: syz-executor931 Not tainted 6.1.0-rc3-next-20221102-syzkaller #0 > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/11/2022 > RIP: 0010:__elevator_get block/elevator.h:94 [inline] > RIP: 0010:blk_mq_elv_switch_none block/blk-mq.c:4593 [inline] > RIP: 0010:__blk_mq_update_nr_hw_queues block/blk-mq.c:4658 [inline] > RIP: 0010:blk_mq_update_nr_hw_queues+0x304/0xe40 block/blk-mq.c:4709 > RSP: 0018:ffffc90003cdfc08 EFLAGS: 00010206 > RAX: 0000000000000000 RBX: dffffc0000000000 RCX: 0000000000000000 > RDX: 000000000000001d RSI: 0000000000000002 RDI: 00000000000000e8 > RBP: ffff88801dbd0000 R08: ffff888027c89398 R09: ffffffff8de2e517 > R10: fffffbfff1bc5ca2 R11: 0000000000000000 R12: ffffc90003cdfc70 > R13: ffff88801dbd0008 R14: ffff88801dbd03f8 R15: ffff888027c89380 > FS: 0000555557259300(0000) GS:ffff8880b9a00000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 00000000005d84c8 CR3: 000000007a7cb000 CR4: 00000000003506f0 > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > Call Trace: > > nbd_start_device+0x153/0xc30 drivers/block/nbd.c:1355 > nbd_start_device_ioctl drivers/block/nbd.c:1405 [inline] > __nbd_ioctl drivers/block/nbd.c:1481 [inline] > nbd_ioctl+0x5a1/0xbd0 drivers/block/nbd.c:1521 > blkdev_ioctl+0x36e/0x800 block/ioctl.c:614 > vfs_ioctl fs/ioctl.c:51 [inline] > __do_sys_ioctl fs/ioctl.c:870 [inline] > __se_sys_ioctl fs/ioctl.c:856 [inline] > __x64_sys_ioctl+0x193/0x200 fs/ioctl.c:856 > do_syscall_x64 arch/x86/entry/common.c:50 [inline] > do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 > entry_SYSCALL_64_after_hwframe+0x63/0xcd > > [...] Applied, thanks! [1/1] block: fix crash in 'blk_mq_elv_switch_none' commit: 90b0296ece4bd8f70419f0addc1171be6feee195 Best regards, -- Jens Axboe