Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1cc97d84-da4d-c8cc-dbcd-fcdc34c6d11c@suse.com>
Date:   Thu, 24 Nov 2022 14:33:28 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH v2] x86: Avoid relocation information in final vmlinux
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
Cc:     tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com,
        x86@kernel.org, hpa@zytor.com, nicolas@fjasle.eu,
        masahiroy@kernel.org, kirill.shutemov@linux.intel.com,
        tony.luck@intel.com, michael.roth@amd.com, nathan@kernel.org,
        ndesaulniers@google.com, linux-kernel@vger.kernel.org
References: <20220927084632.14531-1-petr.pavlu@suse.com>
 <Y34SXeU6JEk+UGfV@zn.tnic> <1af5ee66-5ab1-45b2-f229-182f89dc6b94@suse.com>
 <Y35CNdPVwq11NCYN@zn.tnic> <765e1e78-c540-0753-7a19-7d335bcc998b@suse.com>
 <Y39lwk3itVnsADrP@zn.tnic>
From:   Petr Pavlu <petr.pavlu@suse.com>
In-Reply-To: <Y39lwk3itVnsADrP@zn.tnic>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QUlJUmtldExRR1RzeEIzc3pNU1ZCbTRTZTQvNG9xN3dOZ242OEd2cVd2d1pU?=
 =?utf-8?B?eHI4SktXVWtjOGZzRG4zaFJra0s1NW45cmttRWRWc3JrMFh3UkVxc2lqQmhx?=
 =?utf-8?B?dU9OQmFZZTBLQStySnJrKy9uTDZYQkJHbW5ISG9NUDdZbk1DbURTdDFUdUp2?=
 =?utf-8?B?VUFHQVJYMXpBLzdGS3A3Zlc5a05nOGVMcmZ2V0piYUNPRERJNVByZ3hpaDlM?=
 =?utf-8?B?aGxmeDhobTZ3blZTQ0NHdHZVb3JtSy9IUVA1MFhJeWJoditpMHQxWGdncTl2?=
 =?utf-8?B?ZEhvdlFYQUNkb0tqRzFWWGk0TWFHK0tvQllDa3U4S1d2QXJMd1BzM2RxMkEz?=
 =?utf-8?B?Vm5jNmlQOFVKekhQSEo4ODMzQ1lHUjdVN2NtUTlrODlDQ3VZOFNwOStEc05W?=
 =?utf-8?B?dG9tcEM5SitQeUFtNDlGcEs2TzhuQ25jeFVIcDdqSHhCMjNLUHZDeEx1MS9v?=
 =?utf-8?B?VWltaWxUSEN1Tyt0djYzMTJxYXpZSVovNlVudEc1c0VFYyttTnM0YzlneDRR?=
 =?utf-8?B?TGJQWUpDbmduaG1pTFNmT0owc3oyRnkvbG9ZRFdQWW9hU3JUOUY5U25MSEZz?=
 =?utf-8?B?Mkh2T291QmVuUjM5RHh2NVoxS1V1NkNJTHNob0NVaGVqb2NSMS9KRXBDTjRn?=
 =?utf-8?B?R09kSmZINnlFbzdpZkMyN0x5OFNsNHJ3eXpFc0lLeTZJd3hqeGZzQ1lNeExX?=
 =?utf-8?B?NEczUTVld1h2YVhNNm1CdkdBM2ExTXBsRk1SOEJENURoYUszRjFEZ2JYaGIy?=
 =?utf-8?B?eGJVaU5mODNjcWh3c2FYTjZYcUNsSVc1aDl3aUtaOHROL3Y3OXFtYVFRdmZ5?=
 =?utf-8?B?WTlqWnZiOFRvYm11Vk5HdmFMTldLeEJYdE8xWlM4VVJITWZqYnpaWHFkK0Vy?=
 =?utf-8?B?S0grbHZ5K2NnRHE0RmZ0akwrMXhIcXpjQURYL21kdGdMbkI0eklabkJkeElU?=
 =?utf-8?B?VVV1UVduZW1VWXdSdE1Qb0wwcDNOaENFRnFtVDk2RFZUaHV5MEE0QXRrbFpo?=
 =?utf-8?B?OHRabzMzQmtwK2p5amEvSUVCb1h2U1B3SzlVWXZ2RkNKcXZGbFR2V2lxaURH?=
 =?utf-8?B?bGFPbytLcmxKS1l2S1VqQzJ3MU0yMFBPMUsyUVorbUluNUN6N3R1RFdZRHBq?=
 =?utf-8?B?YTUwbk5pMWpHT1poVFRGV0hNLzdwME9CSHRPOFJ6QXBCMHRlM253dzljUzBO?=
 =?utf-8?B?VDR1UmoxYTdKZDhLdXRpclY4NXcrRGEyYTU2WUs4RUl2a3oxeXVzVHJXRVFu?=
 =?utf-8?B?cnhpRHRyWmtxUk9KVGw1bFZZcUlMYjNlRUN4ZVovS2FwcllwTVZZNG1rZFh0?=
 =?utf-8?B?SGE5VkFXUCs0dFcvUzF0R28yYzA2bmJJWThKWFI3RmFJWHNtdlYxdEI3Umho?=
 =?utf-8?B?Ky9nWVdBUFpoYzNJaUZYM2MxQUxhNWs0c0E2WjdwRVJ1T0lJUkw1dnp6QzNM?=
 =?utf-8?B?TGFud3dFKzRyL3Z4OTk5c0xSUTFNMWZRZTFuOGhieWdnaVlHWWU3YThhbUpp?=
 =?utf-8?B?NVBsSmNnU25XaEpxZ2xORjVIUno4d0F6cldvdjRiOTg1dGVWbTBTMHNJOVRE?=
 =?utf-8?B?c3pGWWh6eGZjVWhYZ0N4TEVuT3k0Qm9nTXgwNmdwZ3NIc3JXcnpPQ3lhcHJ4?=
 =?utf-8?B?NTZZTFFNUkx6V0VCMXMxYW52MFkzV1FsQnAvQWU2NFprNDlNSC9GZ0NIOC9w?=
 =?utf-8?B?U3I1MHBab3Y4aGhEYmxTRHBNVnR6eVNCN0RuS0l4REx1eWNVaHovcnQ2UzVN?=
 =?utf-8?B?OGVsS0dHZmZCb3VoMmNSTkVvL3F3U0E5MHdDRVB1WGdPckJhbCtOY0xCZE9m?=
 =?utf-8?B?YkhyMjE5SXdZdEZiS0MxVU9BcWtyQVFKZWwxMHdKVFNlbVJUaWlacW1JelZ6?=
 =?utf-8?B?WTBKSkdxM0JiS3BxVTV6TTNVVVlMZjhucnNYSks2eW9EOHVickJrRU02T0ZT?=
 =?utf-8?B?a2FvWDIxMzU5ZVQyRGM1TXh0RFMyWDJiMHpJME5YSmRER202MW5VNUVLNXlK?=
 =?utf-8?B?VVIwZHNCMkVyTVY4UWVoNml2bWlyV0ZRd0Q5NUEyZ0RsZEM2V0U4QzlhTzNP?=
 =?utf-8?B?VklzNmt1Z09uOWs5bHBVK0xNTVFMdmhVNXRoV0NUaU03THA4emJhbTJDeXp5?=
 =?utf-8?Q?vra/KPxvf9RiXaN2rePDtdt7f?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9e5a52af-a846-40d5-3f14-08dace2079c5
X-MS-Exchange-CrossTenant-AuthSource: AM0PR0402MB3395.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2022 13:33:30.5935
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WrUq1YqOcp3e1VllXxixbXZErP4w9DEw+4y88NntuZMYSWkY/9qKkHm35HVK+odV+YhXD5doNHc1kjxNJOkXiQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7302
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/24/22 13:38, Borislav Petkov wrote:
> On Thu, Nov 24, 2022 at 10:21:33AM +0100, Petr Pavlu wrote:
>> Option CONFIG_RANDOMIZE_BASE=y needs to be enabled. Switching it on should
>> automatically select also CONFIG_X86_NEED_RELOCS=y which is what actually
>> enables use of --emit-relocs in arch/x86/Makefile.
> 
> Yeah, as I said in my previous mail:
> 
> "and before and after .configs simply have RANDOMIZE_BASE =n and =y,
> respectively."
> 
> I just did it again to make sure:
> 
> -rwxr-xr-x 1 boris boris 377666112 Nov 24 13:28 vmlinux.before
> -rwxr-xr-x 1 boris boris 377718768 Nov 24 13:33 vmlinux.after
> 
> With
> 
> $ grep -E "(NEED_RELOCS|RANDOMIZE)" .config
> CONFIG_RANDOMIZE_BASE=y
> CONFIG_X86_NEED_RELOCS=y
> CONFIG_RANDOMIZE_MEMORY=y
> CONFIG_RANDOMIZE_MEMORY_PHYSICAL_PADDING=0x0
> CONFIG_ARCH_HAS_ELF_RANDOMIZE=y
> CONFIG_HAVE_ARCH_RANDOMIZE_KSTACK_OFFSET=y
> CONFIG_RANDOMIZE_KSTACK_OFFSET=y
> 
> that second vmlinux file is even a bit larger (~51K) ...

If the before case is with RANDOMIZE_BASE=n and the after case is with
RANDOMIZE_BASE=y then it makes sense the resulting sizes are similar. With
RANDOMIZE_BASE=n, vmlinux is linked without --emit-relocs and so there will be
no relocation sections at all. With RANDOMIZE_BASE=y and my patch, the
sections get created but are stripped eventually. The increased size in the
second case is likely due to the logic to support the relocation process.

The case that the patch improves is with RANDOMIZE_BASE=y. Both the before and
after case need to have this option enabled. Comparison without my patch and
with it should then show that the patch significantly reduces the size of
vmlinux.

Petr