Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 24 Nov 2022 09:09:28 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     "Tian, Kevin" <kevin.tian@intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>, Joerg Roedel <joro@8bytes.org>,
        Will Deacon <will@kernel.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Marc Zyngier <maz@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        "Williams, Dan J" <dan.j.williams@intel.com>,
        Logan Gunthorpe <logang@deltatee.com>,
        "Raj, Ashok" <ashok.raj@intel.com>, Jon Mason <jdmason@kudzu.us>,
        Allen Hubbe <allenbh@gmail.com>
Subject: Re: [patch V2 27/33] genirq/msi: Provide constants for PCI/IMS
 support
Message-ID: <Y39tCFWB7I/fFEAa@nvidia.com>
References: <20221121083657.157152924@linutronix.de>
 <20221121091327.974140298@linutronix.de>
 <BN9PR11MB5276C9AE570B4CF854F6F5E48C0F9@BN9PR11MB5276.namprd11.prod.outlook.com>
 <87o7swd8gi.ffs@tglx>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87o7swd8gi.ffs@tglx>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?sPdMgIqWBTw7VB8BzZAxCjMkhIH/B9BKUjoZ24bHrpUJzcMZemcVlyLOkWwB?=
 =?us-ascii?Q?iecO7kqxR5Vd2XTAxaFv7z7Wg810eCRCLn/QtL32fLDP8LeRIqI0e+4Invbr?=
 =?us-ascii?Q?ft0f4tyxYNHlSSQ2QhwLqq6XkTdQPol7d5cjb/0Rn2Yol7ZWogVjfNsmDXRP?=
 =?us-ascii?Q?lgEaWq4SMyzWQcIdaDJe7DLYJThsELKpcSLdzevxLhpx92NA1rDeMMBDWDRe?=
 =?us-ascii?Q?TXPwDw1BLNd6EbG49Z71o0xRgXzx/GLIZdDHGuuv46pUXp/Ilolw/EeLcyQH?=
 =?us-ascii?Q?KZSRTRBu+i+DERBGcat4KeRILD/fbd+842Uve9CN+D79dhvGY2WyvVKh6N8/?=
 =?us-ascii?Q?6l3OgzlEliuI/8EFemod0EGfezlFOW2LI/RBemDBJa86KEWSIahwxc7uJ33+?=
 =?us-ascii?Q?mZ82+c7PVfSZCKomzoBrw/hSC0x4QQY3kr2+0mFS/p0bR1S5rixyhrhvD+gd?=
 =?us-ascii?Q?8jyoLw/wxJYRvqcnPkSVUtQdeltf+SnCwTlebD7/O7s2vLuo/Pimm9l68Xup?=
 =?us-ascii?Q?Y6IM3x3LsxWMFB7uKodC9pR0/L1gRQOWWApQJ2vlaseE0BDZfO1xaYyE/oFM?=
 =?us-ascii?Q?KSc/v4kNdB8mT9PsT9GylTbH8x7u1dco8eWq20QDOk6xunV80cwcOPkhUr72?=
 =?us-ascii?Q?9IuUE1X00h4CtWRWe+nhK2+7sS4Ng2J+gROAYaVIZaZ/gqzvBiU5kzyCWPrZ?=
 =?us-ascii?Q?j+E5qs/C8/j/ql+KpkJfabzop4MNm19VV9mYkKfka65/GNGH0c0N2pkExX6o?=
 =?us-ascii?Q?aL8LhsQYVJGyJRQIu86IViYzPUa23pkQx0zRYtEJJ2L2sLNmZduxtaxkL+/R?=
 =?us-ascii?Q?3+skf9ZPUorvqHbjscB4HsggmJt+ZD8oEtfbbUS6AWBmpVHIBPCXPZExLhza?=
 =?us-ascii?Q?bENiyhM/LhCyrhp4TStevuAHbGjsvzDB9Y0UYku8eVP/WaDRUInVPVSgYYte?=
 =?us-ascii?Q?4sjIEwen8dgIzYgV4i+iLMPV65OscC3qpSH/9t3/Aes26oAAFs/FONFdlr3S?=
 =?us-ascii?Q?6TecPq1+swbOBihzg9o/XrZtTnyfIHlqco6b7+7BDb0ZgE+OvkZtQE5zODOw?=
 =?us-ascii?Q?f585jVzVKB6NOK5IizHx9JJyn74dwqvxRbMDz6XeGEU51m8aNpelBtWifYFQ?=
 =?us-ascii?Q?LTFypd3z2ErNO3BRxA9a2cGecGvB4/4K6/OTHLzleuYoI+/PUiSApEGb0CHb?=
 =?us-ascii?Q?Wz+90ec0VfpHtkSNGZnoPMPOCdxLjXERsCpuzL24C8biEEzeAIV2DXo7IyDd?=
 =?us-ascii?Q?bTIR3ibtGINM3zl0LOCiKsCxYlRQDUZF6f0pEM8X40fnBeAedcQKeFmVI8FU?=
 =?us-ascii?Q?64M5hNTDrbrQBGxWt/qVe60tjF9mlGhNIWqsHE4e2ZC5DWr0hvIEx7APPRiW?=
 =?us-ascii?Q?rywCj1askRY63BTTyS0MrB/IdMOmfNFhdtjSQPKHGugaro8tTFe3mLCH8vQr?=
 =?us-ascii?Q?BvdlntoSziPl3GL6sxTgSjAMRMJ72v6/XKxt87JyiOySUOP+7/U+Ypr2cFJP?=
 =?us-ascii?Q?QkdK97wpyDANpMjo6rgLzPzTIyG+90B2WXfNoQh/FrQIorQfzExdP1fiEAhv?=
 =?us-ascii?Q?8yvFT8wJ3yVRtto1Ge8=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2be4b1f6-e736-473d-d612-08dace1d1e7b
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2022 13:09:28.8245
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: I0WdkfgJ3bAo366uWUz44dJlvhB3gFuBaLHuiEWhT0CcEcBcFjSRFd4XO9M+g24s
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5969
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Nov 24, 2022 at 10:10:05AM +0100, Thomas Gleixner wrote:
> On Thu, Nov 24 2022 at 03:01, Kevin Tian wrote:
> >> From: Thomas Gleixner <tglx@linutronix.de>
> >> @@ -15,6 +15,7 @@ struct device;
> >>   */
> >>  enum msi_domain_ids {
> >>  	MSI_DEFAULT_DOMAIN,
> >> +	MSI_SECONDARY_DOMAIN,
> >>  	MSI_MAX_DEVICE_IRQDOMAINS,
> >
> > SECONDARY or be explicit IMS? Are we envisioning non-IMS usages to
> > occupy this slot in the future?
> 
> I'm not really decided on that. Whatever the name or use-case for a
> secondary domain is. Not, that this is not restricted to PCI.

This is hierarchical right? So if a pci_device spawns an
auxiliary_device, its driver could stick a msi domain on the
MSI_DEFAULT_DOMAIN of the aux device as a child of the PCI device's
domain?

I don't know if we need per "ADI" msi domains, but it seems OK to me
to hav have two slots for now and be general about what can go in
those slots

Jason