Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 24 Nov 2022 13:46:21 +0000
From:   Sudeep Holla <sudeep.holla@arm.com>
To:     =?utf-8?B?546L5rSq6L6J?= <honghui.wang@ucas.com.cn>
Cc:     Mark Rutland <mark.rutland@arm.com>,
        Cristian Maruss <cristian.marussi@arm.com>,
        Sudeep Holla <sudeep.holla@arm.com>,
        Jassi Brar <jassisinghbrar@gmail.com>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] arm_scpi: modify to support acpi
Message-ID: <20221124134621.tmlfk7pqbmbkmzal@bogus>
References: <F813BC8072CDDB25+Y38Yq2QKFefSupZV@TP-P15V.lan>
 <Y39PetDhm9fpycwo@FVFF77S0Q05N>
 <tencent_049E1A8275A0742F2374507E@qq.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <tencent_049E1A8275A0742F2374507E@qq.com>
Precedence: bulk

On Thu, Nov 24, 2022 at 08:23:58PM +0800, 王洪辉 wrote:
> When boot from uefi on phytium ft2004(arm64) platform, can't show temp &
> freq of cpu, but well if boot from uboot for same kernel binary file.

Yes the same binary must work if you use right ACPI methods/AML/tables.
Everything needed is there in the kernel, you need to write correct ACPI
firmware/tables.

> So i modified arm_scpi.c and scpi-hwmon.c as patch, and tested ok.
>

Yes tested to be OK, but definitely not acceptable. Please look at the
ACPI spec and improve your firmware to use what you need here. I have
given all the pointers now.

-- 
Regards,
Sudeep