Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <c5fbff9f-6fad-fb1d-17a1-9d7da7761c4f@roeck-us.net>
Date:   Thu, 24 Nov 2022 06:25:46 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH V2 1/3] Modify to support Phytium FT2000/4 CPU for acpi
Content-Language: en-US
To:     Wang Honghui <honghui.wang@ucas.com.cn>,
        Jean Delvare <jdelvare@suse.com>, linux-hwmon@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <9CAB43B4193E4C62+Y37kSTHfZuJeOvI8@TP-P15V.lan>
From:   Guenter Roeck <linux@roeck-us.net>
In-Reply-To: <9CAB43B4193E4C62+Y37kSTHfZuJeOvI8@TP-P15V.lan>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/23/22 19:26, Wang Honghui wrote:
> Modify to support Phytium FT2000/4 CPU for acpi
> 
> Signed-off-by: Wang Honghui <honghui.wang@ucas.com.cn>
> ---
>   drivers/hwmon/scpi-hwmon.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hwmon/scpi-hwmon.c b/drivers/hwmon/scpi-hwmon.c
> index 6021ae00b334..a6ee9806e47e 100644
> --- a/drivers/hwmon/scpi-hwmon.c
> +++ b/drivers/hwmon/scpi-hwmon.c
> @@ -316,6 +316,7 @@ static struct platform_driver scpi_hwmon_platdrv = {
>   	.driver = {
>   		.name	= "scpi-hwmon",
>   		.of_match_table = scpi_of_match,
> +		.acpi_match_table = scpi_sensors_acpi_match,
>   	},
>   	.probe		= scpi_hwmon_probe,
>   };


This patch on its own doesn't make sense. It seems to be a fix of v1, not
a new version of v1. Your subject lines are off. Modify what ?
The subject should be something like "hwmon: (scpi) Add ACPI support for...".

Guenter